apt cache operations have potential for filesystem races
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Charm Helpers |
Fix Released
|
High
|
James Page | ||
ceph (Juju Charms Collection) |
Fix Released
|
High
|
James Page | ||
ceph-osd (Juju Charms Collection) |
Fix Released
|
High
|
Liam Young | ||
ceph-radosgw (Juju Charms Collection) |
Fix Released
|
High
|
Björn Tillenius | ||
landscape-client (Juju Charms Collection) |
Fix Committed
|
High
|
Chris Glass | ||
mysql (Juju Charms Collection) |
Fix Released
|
High
|
Chris Glass | ||
ntpmaster (Juju Charms Collection) |
Fix Released
|
High
|
Chris Glass | ||
rabbitmq-server (Juju Charms Collection) |
Fix Released
|
High
|
Chris Glass |
Bug Description
Got this backtrace while deploying cs:trusty/
2014-07-21 18:37:41 INFO identity-
2014-07-21 18:45:11 INFO mon-relation-
^M^MReading package lists... 99%^M^MReading package lists... Error!
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 INFO mon-relation-
2014-07-21 18:45:11 ERROR juju.worker.uniter uniter.go:486 hook failed: exit status 1
The apt.Cache() call should perhaps be placed in a try/except block with a few of retries.
This happened inside a container where ceph-radosgw is the principal and there are two subordinates: landscape-client and ntp.
Related branches
- James Page: Approve
-
Diff: 35 lines (+9/-5)1 file modifiedhooks/ceph.py (+9/-5)
- OpenStack Charmers: Pending requested
-
Diff: 35 lines (+9/-5)1 file modifiedhooks/ceph.py (+9/-5)
- charmers: Pending requested
-
Diff: 14 lines (+4/-0)1 file modifiedcharmhelpers/core/host.py (+4/-0)
- Liam Young (community): Approve
-
Diff: 475 lines (+189/-55)9 files modifiedhooks/ceph.py (+4/-18)
hooks/charmhelpers/contrib/storage/linux/utils.py (+1/-0)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/hookenv.py (+5/-4)
hooks/charmhelpers/core/host.py (+32/-12)
hooks/charmhelpers/fetch/__init__.py (+24/-16)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
hooks/hooks.py (+4/-3)
templates/ceph.conf (+1/-1)
- OpenStack Charmers: Pending requested
-
Diff: 491 lines (+198/-55)9 files modifiedhooks/ceph.py (+4/-18)
hooks/charmhelpers/contrib/storage/linux/utils.py (+1/-0)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/hookenv.py (+5/-4)
hooks/charmhelpers/core/host.py (+32/-12)
hooks/charmhelpers/fetch/__init__.py (+33/-16)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
hooks/hooks.py (+4/-3)
templates/ceph.conf (+1/-1)
- OpenStack Charmers: Pending requested
-
Diff: 475 lines (+189/-55)9 files modifiedhooks/ceph.py (+4/-18)
hooks/charmhelpers/contrib/storage/linux/utils.py (+1/-0)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/hookenv.py (+5/-4)
hooks/charmhelpers/core/host.py (+32/-12)
hooks/charmhelpers/fetch/__init__.py (+24/-16)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
hooks/hooks.py (+4/-3)
templates/ceph.conf (+1/-1)
- Liam Young (community): Approve
-
Diff: 450 lines (+185/-56)9 files modifiedhooks/ceph.py (+0/-19)
hooks/charmhelpers/contrib/storage/linux/utils.py (+1/-0)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/hookenv.py (+5/-4)
hooks/charmhelpers/core/host.py (+32/-12)
hooks/charmhelpers/fetch/__init__.py (+24/-16)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
hooks/hooks.py (+4/-3)
templates/ceph.conf (+1/-1)
- Liam Young (community): Approve
-
Diff: 222 lines (+143/-8)4 files modifiedcharm-helpers-sync.yaml (+1/-1)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/host.py (+24/-6)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
- Charles Butler (community): Approve
- Tim Van Steenburgh (community): Approve
- Chris Glass (community): Approve
-
Diff: 222 lines (+143/-8)4 files modifiedcharm-helpers-sync.yaml (+1/-1)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/host.py (+24/-6)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
- Liam Young (community): Approve
-
Diff: 222 lines (+143/-8)4 files modifiedcharm-helpers-sync.yaml (+1/-1)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/host.py (+24/-6)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
- David Britton (community): Approve
-
Diff: 2155 lines (+1453/-133)12 files modified.bzrignore (+1/-0)
Makefile (+8/-2)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/hookenv.py (+215/-29)
hooks/charmhelpers/core/host.py (+167/-23)
hooks/charmhelpers/core/services/__init__.py (+2/-0)
hooks/charmhelpers/core/services/base.py (+313/-0)
hooks/charmhelpers/core/services/helpers.py (+239/-0)
hooks/charmhelpers/core/templating.py (+51/-0)
hooks/charmhelpers/fetch/__init__.py (+274/-73)
hooks/charmhelpers/fetch/archiveurl.py (+64/-4)
hooks/charmhelpers/fetch/bzrurl.py (+3/-2)
- David Britton (community): Approve
- Review Queue (community): Needs Fixing (automated testing)
-
Diff: 1685 lines (+1204/-116)12 files modified.bzrignore (+1/-0)
Makefile (+7/-2)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/hookenv.py (+132/-7)
hooks/charmhelpers/core/host.py (+100/-12)
hooks/charmhelpers/core/services/__init__.py (+2/-0)
hooks/charmhelpers/core/services/base.py (+313/-0)
hooks/charmhelpers/core/services/helpers.py (+239/-0)
hooks/charmhelpers/core/templating.py (+51/-0)
hooks/charmhelpers/fetch/__init__.py (+192/-90)
hooks/charmhelpers/fetch/archiveurl.py (+49/-4)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
- David Britton (community): Approve
-
Diff: 3241 lines (+2078/-264)25 files modifiedhooks/charmhelpers/contrib/charmsupport/volumes.py (+5/-2)
hooks/charmhelpers/contrib/hahelpers/cluster.py (+59/-17)
hooks/charmhelpers/contrib/openstack/amulet/deployment.py (+94/-0)
hooks/charmhelpers/contrib/openstack/amulet/utils.py (+276/-0)
hooks/charmhelpers/contrib/openstack/context.py (+187/-47)
hooks/charmhelpers/contrib/openstack/ip.py (+79/-0)
hooks/charmhelpers/contrib/openstack/neutron.py (+31/-1)
hooks/charmhelpers/contrib/openstack/templating.py (+22/-23)
hooks/charmhelpers/contrib/openstack/utils.py (+18/-7)
hooks/charmhelpers/contrib/peerstorage/__init__.py (+77/-29)
hooks/charmhelpers/contrib/ssl/service.py (+1/-1)
hooks/charmhelpers/contrib/storage/linux/ceph.py (+1/-1)
hooks/charmhelpers/contrib/storage/linux/lvm.py (+1/-1)
hooks/charmhelpers/contrib/storage/linux/utils.py (+23/-5)
hooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/hookenv.py (+132/-7)
hooks/charmhelpers/core/host.py (+100/-12)
hooks/charmhelpers/core/services/__init__.py (+2/-0)
hooks/charmhelpers/core/services/base.py (+313/-0)
hooks/charmhelpers/core/services/helpers.py (+239/-0)
hooks/charmhelpers/core/templating.py (+51/-0)
hooks/charmhelpers/fetch/__init__.py (+192/-90)
hooks/charmhelpers/fetch/archiveurl.py (+49/-4)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
hooks/rabbit_utils.py (+8/-16)
- David Britton (community): Approve
- Chris Glass (community): Approve
-
Diff: 212 lines (+35/-37)8 files modified.bzrignore (+1/-0)
Makefile (+8/-2)
hooks/ceph.py (+4/-18)
hooks/charmhelpers/contrib/storage/linux/utils.py (+4/-0)
hooks/charmhelpers/core/host.py (+2/-6)
hooks/charmhelpers/fetch/__init__.py (+11/-7)
hooks/hooks.py (+4/-3)
templates/ceph.conf (+1/-1)
- David Britton (community): Approve
- Chris Glass (community): Approve
-
Diff: 213 lines (+35/-37)8 files modified.bzrignore (+1/-0)
Makefile (+8/-2)
hooks/ceph.py (+4/-18)
hooks/charmhelpers/contrib/storage/linux/utils.py (+4/-0)
hooks/charmhelpers/core/host.py (+2/-6)
hooks/charmhelpers/fetch/__init__.py (+11/-7)
hooks/hooks.py (+4/-3)
templates/ceph.conf (+1/-1)
- Fernando Correa Neto (community): Approve
- David Britton (community): Approve
- Adam Collard (community): Approve
-
Diff: 1471 lines (+1106/-49)10 files modifiedhooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/hookenv.py (+132/-7)
hooks/charmhelpers/core/host.py (+100/-12)
hooks/charmhelpers/core/services/__init__.py (+2/-0)
hooks/charmhelpers/core/services/base.py (+313/-0)
hooks/charmhelpers/core/services/helpers.py (+239/-0)
hooks/charmhelpers/core/templating.py (+51/-0)
hooks/charmhelpers/fetch/__init__.py (+102/-25)
hooks/charmhelpers/fetch/archiveurl.py (+49/-4)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
- Adam Collard (community): Needs Resubmitting
- Landscape: Pending requested
-
Diff: 1570 lines (+1131/-51)14 files modifiedhooks/charmhelpers/core/fstab.py (+116/-0)
hooks/charmhelpers/core/hookenv.py (+132/-7)
hooks/charmhelpers/core/host.py (+100/-12)
hooks/charmhelpers/core/services/__init__.py (+2/-0)
hooks/charmhelpers/core/services/base.py (+313/-0)
hooks/charmhelpers/core/services/helpers.py (+239/-0)
hooks/charmhelpers/core/templating.py (+51/-0)
hooks/charmhelpers/fetch/__init__.py (+102/-25)
hooks/charmhelpers/fetch/archiveurl.py (+49/-4)
hooks/charmhelpers/fetch/bzrurl.py (+2/-1)
hooks/common.py (+13/-0)
hooks/hooks.py (+1/-0)
hooks/install.py (+6/-2)
hooks/test_hooks.py (+5/-0)
Changed in ceph (Juju Charms Collection): | |
status: | New → In Progress |
assignee: | nobody → James Page (james-page) |
Changed in ceph-osd (Juju Charms Collection): | |
status: | New → In Progress |
Changed in charm-helpers: | |
status: | In Progress → Fix Released |
Changed in ceph-osd (Juju Charms Collection): | |
status: | In Progress → Fix Released |
Changed in ceph-radosgw (Juju Charms Collection): | |
status: | In Progress → Fix Released |
Changed in ceph (Juju Charms Collection): | |
status: | In Progress → Fix Released |
Changed in ntpmaster (Ubuntu): | |
status: | New → Fix Released |
assignee: | nobody → David Britton (davidpbritton) |
no longer affects: | ntpmaster (Ubuntu) |
Changed in ntpmaster (Juju Charms Collection): | |
assignee: | nobody → Chris Glass (tribaal) |
Changed in ntpmaster (Juju Charms Collection): | |
importance: | Undecided → High |
status: | New → Fix Released |
Changed in mysql (Juju Charms Collection): | |
assignee: | nobody → Chris Glass (tribaal) |
importance: | Undecided → High |
status: | New → Fix Released |
Changed in rabbitmq-server (Juju Charms Collection): | |
status: | New → Fix Released |
importance: | Undecided → High |
assignee: | nobody → Chris Glass (tribaal) |
Changed in ceph-osd (Juju Charms Collection): | |
assignee: | nobody → Liam Young (gnuoy) |
Changed in landscape-client (Juju Charms Collection): | |
status: | New → Fix Committed |
importance: | Undecided → High |
assignee: | nobody → Chris Glass (tribaal) |
I think we can make that run in memory, avoiding the need for filesystem locking.