Juju Charms Collection
jenkins package

Unable to relate to jenkins-slave: hook failed: "master-relation-changed"

Bug #1272520 reported by Antonio Rosales
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
jenkins (Juju Charms Collection)
Confirmed
High
Charles Butler

Bug Description

Following the readme instructions:

juju deploy jenkins
juju deploy -n 5 jenkins-slave
juju add-relation jenkins jenkins-slave

I get a hook failed error:

services:
  jenkins:
    charm: cs:precise/jenkins-8
    exposed: false
    relations:
      master:
      - jenkins-slave
    units:
      jenkins/0:
        agent-state: error
        agent-state-info: 'hook failed: "master-relation-changed"'
        agent-version: 1.17.0
        machine: "1"
        open-ports:
        - 8080/tcp
        public-address: 15.185.126.211

This may be related to bug 1232886, however I am using the defaults and not release=trunk.

Related branches

lp://staging/~timrchavez/charms/precise/jenkins-slave/jenkins-slave-fix-slave-relation-joined
Marco Ceppi (community): Approve
Diff: 15 lines (+2/-1)
2 files modified
hooks/slave-relation-joined (+1/-0)
revision (+1/-1)
Charles Butler (lazypower)
Changed in jenkins (Juju Charms Collection):
importance: Undecided → High
assignee: nobody → Charles Butler (lazypower)
Timothy R. Chavez (timrchavez)
Changed in jenkins (Juju Charms Collection):
status: New → Confirmed
Revision history for this message
Timothy R. Chavez (timrchavez) wrote :

You didn't provide any sort of logs, so I can't be 100% sure that we had the same problem, but the problem I had was due to the fact that the Jenkins master 'master-relation-changed' hook expects (assumes, rather) that the Jenkins slave 'slave-relation-joined' hook will pass a bunch of information during the 'add-relation' which it will then call the hooks/addnode script with. The problem I encountered is that the Jenkins slave does not set 'slaveaddress' and so it is passed by too 'hooks/addnode' via 'master-relation-changed' as an empty string and causes breakage. Once 'slaveaddress' is properly set by the Jenkins slave in 'slave-relation-joined', this particularly problem goes away.

Revision history for this message
Timothy R. Chavez (timrchavez) wrote :

passed to 'hooks/addnode'*
particular*

Revision history for this message
Ryan Beisner (1chb1n) wrote :

I also run into this while deploying. Logs, commands, configs are here: http://paste.ubuntu.com/8046165/

Revision history for this message
Matt Bruzek (mbruzek) wrote :

According to the latest test results by charm http://reports.vapour.ws/charm-tests-by-charm this charm is failing automated testing.

http://reports.vapour.ws/charm-tests/charm-bundle-test-802-results

The charm is failing charm proof and the 100-deploy test returns a non-zero return code.

charm proof output:
I: relation extension has no hooks
W: config.yaml: option password does not have the keys: default

100-deploy output:
Exception: Error on unit jenkins/0: hook failed: "master-relation-changed" for relation-sentry:requires-jenkins_master-jenkins-slave_slave

We should fix both problems so this charm can pass automated tests and that will help ensure quality in the charm store.

tags: added: auto-test
Revision history for this message
Antonio Rosales (arosales) wrote :

It appears work is underway to resolve testing failures:
https://code.launchpad.net/~hopem/charms/trusty/jenkins/python-redux/+merge/243958

Thus, this bug will not be moved into the unmaintained namespace of the charm store per:
 https://jujucharms.com/docs/charm-unmaintained-process
 https://lists.ubuntu.com/archives/juju/2014-December/004736.html

Thanks for working to resolve this issues, lets try to get this charm backing into a passing state asap.
-Antonio

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.