Empty servername no longer defaults to public-address
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
apache2 (Juju Charms Collection) |
Fix Released
|
Undecided
|
Andreas Hasenack |
Bug Description
Since r46 of the apache2 charm, the servername config key no longer defaults to public-address. It remains empty and that breaks deployments:
options:
servername:
type: string
default: ''
description: ServerName for vhost, defaults to the units public-address
Before r46 config_get had an exception for servername:
hooks/hooks.py:78:
def config_
(...)
if not config_
In r46, the charm started using charm helpers and that config_get obviously has no such exception.
On a side note, the commit for r46 didn't mention this huge change of using charm helpers ;)
Related branches
- Marco Ceppi (community): Approve
-
Diff: 44 lines (+16/-3)1 file modifiedhooks/hooks.py (+16/-3)
Changed in apache2 (Juju Charms Collection): | |
assignee: | nobody → Andreas Hasenack (ahasenack) |
status: | New → In Progress |
Changed in apache2 (Juju Charms Collection): | |
status: | In Progress → Fix Committed |
Changed in apache2 (Juju Charms Collection): | |
status: | Fix Committed → Fix Released |
tags: | added: landscape |