Empty servername no longer defaults to public-address

Bug #1243772 reported by Andreas Hasenack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apache2 (Juju Charms Collection)
Fix Released
Undecided
Andreas Hasenack

Bug Description

Since r46 of the apache2 charm, the servername config key no longer defaults to public-address. It remains empty and that breaks deployments:

options:
  servername:
    type: string
    default: ''
    description: ServerName for vhost, defaults to the units public-address

Before r46 config_get had an exception for servername:
hooks/hooks.py:78:
def config_get(scope=None):
(...)
        if not config_data["servername"]:
            config_data["servername"] = run(["unit-get", "public-address"]).rstrip()

In r46, the charm started using charm helpers and that config_get obviously has no such exception.

On a side note, the commit for r46 didn't mention this huge change of using charm helpers ;)

Tags: landscape

Related branches

Changed in apache2 (Juju Charms Collection):
assignee: nobody → Andreas Hasenack (ahasenack)
status: New → In Progress
Changed in apache2 (Juju Charms Collection):
status: In Progress → Fix Committed
Changed in apache2 (Juju Charms Collection):
status: Fix Committed → Fix Released
tags: added: landscape
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.