Comment 21 for bug 822979

Thanks for this rewrite! awesome to see ES as deployed via an ansible playbook!

In general, everything looks good. Few little things to fix or consider:

Test running:

  - tests expect python-nose, but `make test` runs nosetests3, the
    executable installed by python3-nose.

  - I had to install nose, mock, and py-yaml before I could get the
    tests to run. To allow for automated testing, installing the deps
    should be a requirement for the makefile test target,

  - To get the tests to run, I simplified command to
    `@PYTHONPATH=./hooks nosetests --nologcapture unit_tests`. I'm
    pretty sure this should work in or out of a virtualenv, provided
    the deps are installed.

metadata.yaml

  Charm proof throws a warning on the maintainer field having more
  than a single name and single email. Support is coming for multiple
  maintainers and it will expect a yaml list of names and emails.

playbook.yml

  I recommend encapsulating your ansible bits into a folder named
  `playbook` and naming your entry yaml file `hooks.yml`. The playbook
  looks great, you could improve the scannability a bit by
  consistently putting the tags at the end of each task declaration.

I'm going ahead and giving this a plus one. Thanks again Micheal!