Juju Charms Collection

New charm - IBM Spectrum Symphony Storage for review

Bug #1580017 reported by Prabakaran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juju Charms Collection
In Progress
Undecided
Unassigned

Bug Description

Hello Team,

Here is a new charm for IBM Spectrum Symphony Storage for review.

To test this charm, a license to IBM Spectrum Symphony is required.

To test the IBM Spectrum Symphony Storage, we need Symphony node charm and Symphony Master charm as well. As per the design changes, the Platform Symphony charm has been split into three charms:

IBM Spectrum Symphony Storage
IBM Spectrum Symphony Master
IBM Spectrum Symphony Node.

We need all three charms to be deployed to have a functional Symphony Cluster.

And, its source code can be found in the below repository

Repo : https://code.launchpad.net/~ibmcharmers/ibmlayers/layer-ibm-spectrum-symphony-storage

The charm has been pushed into charm store as well

branch : cs:~ibmcharmers/ibm-spectrum-symphony-storage-0

Thanks

See original description
Revision history for this message
Review Queue (review-queue) wrote : LXC Test Results: New charm - IBM Platform Symphony Storage for review

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/4120/

Revision history for this message
Review Queue (review-queue) wrote : AWS Test Results: New charm - IBM Platform Symphony Storage for review

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/4353/

Prabakaran (prabacha)
Changed in charms:
status: New → In Progress
Prabakaran (prabacha)
summary: - New charm - IBM Platform Symphony Storage for review
+ New charm - IBM Spectrum Symphony Storage for review
description: updated
Prabakaran (prabacha)
Changed in charms:
status: In Progress → Fix Committed
Revision history for this message
Konstantinos Tsakalozos (kos.tsakalozos) wrote :

Hi,

Thank you for your work on this charm. Here are some points that may need some improvement.

- Building the charm requires the "interface:nfsstorage" interface. However, since this interface is not registered at http://interfaces.juju.solutions/ you would need to checkout the code locally from a not so obvious repo location. You can go ahead and put the nfsstorage interface to the registry and (in case you haven't done that already) submit it for review.

- After building the charm you can run a "make lint" on the directory where the output files are. You will notice there that there are errors some of which come from the nfsstorage interface.

- The amulet tests need to be under a directory named "tests" and be marked as executable. For example, the 10-deploy.py file should be in tests/10-deploy.py and be executable.

- You mention that the IBM Spectrum Symphony Cluster is made of the Storage the node and the Master. It might make sense to pack all three charms in a bundle and have integration/amulet tests within that bundle. Also, is there some kind of evaluation version that can be deployed with no registration so that the tests can be more involved?

We appreciate your time and effort.

Thank you,
Konstantinos

Changed in charms:
status: Fix Committed → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.