Juju Charms Collection

Python rewrite of nrpe for trusty

Bug #1430732 reported by Liam Young
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juju Charms Collection
Fix Released
Undecided
Liam Young

Bug Description

There is currently no nrpe-external-master charm in trusty but there is one in precise. I have rewritten the nrpe charm in python with the services framework so that it includes the nrpe-external-master functionality and this bug is to track its submission.

This version of the charm should work as a direct replacement for both lp:charms/precise/nrpe-external-master and the existing lp:charms/trusty/nrpe

See original description

Related branches

lp://staging/~gnuoy/charms/trusty/nrpe/services-rewrite
Marco Ceppi (community): Approve
Adam Israel (community): Approve
Diff: 7281 lines (+5917/-888)
76 files modified
.bzrignore (+0/-1)
.coveragerc (+6/-0)
Makefile (+28/-0)
README (+0/-11)
README.md (+183/-0)
base-monitors.yaml (+0/-9)
bin/charm_helpers_sync.py (+253/-0)
charm-helpers-hooks.yaml (+5/-0)
charm-helpers-tests.yaml (+4/-0)
config.yaml (+85/-5)
copyright (+19/-3)
files/default_rsync (+7/-0)
files/nagios_plugin.py (+72/-0)
files/plugins/check_exit_status.pl (+189/-0)
files/plugins/check_mem.pl (+266/-0)
files/plugins/check_netns.sh (+35/-0)
files/plugins/check_status_file.py (+54/-0)
files/plugins/check_upstart_job (+72/-0)
files/rsyncd.conf (+12/-0)
hooks/charmhelpers/__init__.py (+38/-0)
hooks/charmhelpers/core/__init__.py (+15/-0)
hooks/charmhelpers/core/decorators.py (+57/-0)
hooks/charmhelpers/core/fstab.py (+134/-0)
hooks/charmhelpers/core/hookenv.py (+594/-0)
hooks/charmhelpers/core/host.py (+450/-0)
hooks/charmhelpers/core/services/__init__.py (+18/-0)
hooks/charmhelpers/core/services/base.py (+329/-0)
hooks/charmhelpers/core/services/helpers.py (+267/-0)
hooks/charmhelpers/core/strutils.py (+42/-0)
hooks/charmhelpers/core/sysctl.py (+56/-0)
hooks/charmhelpers/core/templating.py (+68/-0)
hooks/charmhelpers/core/unitdata.py (+477/-0)
hooks/charmhelpers/fetch/__init__.py (+439/-0)
hooks/charmhelpers/fetch/archiveurl.py (+161/-0)
hooks/charmhelpers/fetch/bzrurl.py (+78/-0)
hooks/charmhelpers/fetch/giturl.py (+71/-0)
hooks/config-changed (+0/-99)
hooks/general-info-relation-changed (+0/-12)
hooks/install (+0/-12)
hooks/local-monitors-relation-changed (+0/-30)
hooks/local-monitors-relation-departed (+0/-4)
hooks/monitors-relation-joined (+0/-17)
hooks/nrpe-relation-broken (+0/-5)
hooks/nrpe-relation-departed (+0/-7)
hooks/nrpe-relation-joined (+0/-23)
hooks/nrpe.common.bash (+0/-28)
hooks/nrpe_helpers.py (+277/-0)
hooks/nrpe_hooks.py (+3/-0)
hooks/nrpe_utils.py (+125/-0)
hooks/recursive_dictionary.py (+0/-63)
hooks/services.py (+64/-0)
hooks/start (+0/-4)
hooks/stop (+0/-3)
hooks/upgrade-charm (+0/-5)
lib/net.sh (+0/-188)
metadata.yaml (+10/-5)
plugins/check_mem.pl (+0/-266)
revision (+0/-1)
templates/export_host.cfg.tmpl (+10/-0)
templates/nrpe.tmpl (+16/-0)
templates/nrpe_command.tmpl (+3/-0)
templates/rsync-juju.d.tmpl (+10/-0)
test-mon.yaml (+24/-0)
test-monitors.yaml (+0/-15)
tests/00-setup (+3/-12)
tests/10-bundles-test.py (+0/-33)
tests/10-tests (+305/-0)
tests/11-monitors-configurations (+3/-1)
tests/13-monitors-config (+3/-1)
tests/bundles.yaml (+0/-25)
tests/charmhelpers/__init__.py (+38/-0)
tests/charmhelpers/contrib/__init__.py (+15/-0)
tests/charmhelpers/contrib/amulet/__init__.py (+15/-0)
tests/charmhelpers/contrib/amulet/deployment.py (+93/-0)
tests/charmhelpers/contrib/amulet/utils.py (+314/-0)
tests/tests.yaml (+2/-0)
Revision history for this message
Liam Young (gnuoy) wrote :

I have made a small(ish) addition to enable the monitor relation. The monitor relation is defined in the metadata.yaml of the precise bash version of the charm but not implemented.

Revision history for this message
Liam Young (gnuoy) wrote :

I'm assigning this back to myself because I want to put it on hold as we need to decide whether now is the time to merge the nrpe and nrpe-external-master charms.

Changed in charms:
assignee: nobody → Liam Young (gnuoy)
Liam Young (gnuoy)
summary: - Python rewrite of nrpe-external-master for trusty
+ Python rewrite of nrpe for trusty
Revision history for this message
Liam Young (gnuoy) wrote :

I have merged the nrpe and nrpe-external-master charm functionality in a service framework rewrite of the nrpe charm.

I've tested upgrading from the old nrpe charm and switching from the old nrpe-external-master charm to this charm.

description: updated
Changed in charms:
assignee: Liam Young (gnuoy) → nobody
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Manually kicked off lint, unit and amulet runs.

Amulet OK
  juju-test INFO : Results: 2 passed, 0 failed, 0 errored

Lint OK

Unit needs love.

Revision history for this message
Adam Israel (aisrael) wrote :

Hi Liam,

Thanks for your work rewriting this charm! There are a handful of other merge proposals blocked on having npre-external-master in trusty, so this will be a very welcome addition to the charm store.

`make lint` runs flake8 against unit_tests, which doesn't exist.

`make test`'s amulet tests fails if an environment is stood up. The automated testing will bootstrap a fresh environment between runs, and this will currently fail. To work around this, you can add a tests.yaml to the tests directory with the following:

makefile:
    - lint

This will tell bundletester to explicitly run make lint, and then it will auto-detect the tests in tests/ and run those.

Once these issues are resolved, I'll be happy to re-test it. Thanks again!

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Hi Liam,

I'm closing this bug as the review-queue has picked up the merge you proposed. All further conversation should take place on that merge.

Thanks for you work thus far!

Marco

Changed in charms:
status: New → In Progress
Revision history for this message
Felipe Reyes (freyes) wrote :

As the patch is already merged into lp:charms/trusty/nrpe , changing the status to 'Fix Released'

Changed in charms:
status: In Progress → Fix Released
assignee: nobody → Liam Young (gnuoy)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.