New charm: samhain

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-1149-results

Chris,

Thanks for your work on this charm, contributing it to the Juju community, and getting it ready for review.
Good job with "charm proof" passing cleanly.

I reviewed your Readme and I had some suggestions at:
1) correct types
2) How to verify a successful deployment
3) more details on how product is used.
     Think of it as someone wants to demo your charm.

I've added some more details to the README file to help with points 2 and 3, but I'm not sure what you mean by "correct types".

I've also updated the tests with specific charm locations, which should make the automatic tester happy.

The results (PASS) are in and available here: http://reports.vapour.ws/charm-tests/charm-bundle-test-1216-results

Chris, nice charm! This gets my +1, LGTM, but I do have some small suggestions if you're willing to make them before we merge this.

The TLDR is:

1. metadata: categories have changed to tags
2. amulet has new fixes so you don't have to specify branches explicitly.

Here's the diff:

> bzr diff
=== modified file 'metadata.yaml'
--- metadata.yaml 2014-09-22 16:07:30 +0000
+++ metadata.yaml 2014-10-29 14:03:41 +0000
@@ -14,8 +14,8 @@
   resistance + database and configuration files can be signed
   + logfile entries and e-mail reports are signed + support for
   stealth operation
-categories:
- - misc
+tags:
+ - security
 subordinate: true
 requires:
   juju-info:

=== modified file 'tests/10-basic-tests'
--- tests/10-basic-tests 2014-10-03 15:09:29 +0000
+++ tests/10-basic-tests 2014-10-29 14:13:06 +0000
@@ -1,12 +1,12 @@
-#!/usr/bin/python3
+#!/usr/bin/env python3

 import amulet
 import time

 d = amulet.Deployment(series="trusty")

-d.add('apache2', 'cs:trusty/apache2-4')
-d.add('samhain', 'cs:~chris-gondolin/trusty/samhain')
+d.add('apache2')
+d.add('samhain')
 d.add('nrpe-external-master', 'cs:~webteam-backend/trusty/nrpe-external-master-0')

 d.relate('apache2:juju-info', 'samhain:juju-info')
@@ -21,7 +21,7 @@
 except:
     raise

-unit = d.sentry.unit['apache2/0']
+unit = d.sentry['apache2/0']

 # Check config file was created
 if "samhainrc" not in unit.directory_contents("/etc/samhain")["files"]:

Changes made as recommended.

Howdy Chris, thanks for the charm,

I gave it the pinball test and LGTM so I'm giving it a +1. I'd also suggest running pep8 on your hooks.

-w

Fixed pep8