hortonworks hdp2.1 zookeeper charm

Looks to deploy fine. Checking proof: needs a copyright file and README.ex should be moved to README or README.txt (as it is not an example).

Did not run tests.

thanks whit, done:
1) add amulet test
2) remove README.ex
3) copyright file

Hello Amir,

Thank you very much for submitting this charm. The readme is a little light on details, specifically the upstream section is lacking links. I Would expect to see more links to Hortonworks and Zookeeper links.

$ charm proof
W: README.md includes line 13 of boilerplate README.ex
W: README.md includes line 14 of boilerplate README.ex

I am going to put this bug in incomplete. When you add more details to the README and feel your charm is ready for another review please put in "fix committed".

Thanks again for your submission. I look forward to the next review.

applied suggestions..

Greetings Amir,

Thank you for your patience during the review process. I've taken a look at the hortonworks zookeeper charm and have the following notes:

# Charm Proof
Charm Proof passes with no output, excellent!

# KnitPicks
Looking through the hook code, I see a solid use of charm-helpers, however its important to note that you have defined hooks that can safely be omitted. If there is no code to be executed on the charm, then you can remove the hook context within your hooks.py file. Juju by default with return 0 when no hook is present.

# Tests
The zookeeper service amulet tests do a fair job of ensuring that the service is deployed and stood up, however the power of amulet is in leveraging the relationships and testing that the service works well in a given deployment solution. I would like to see these tests expanded in the future to encompass being related to another consuming service, and validating the relationship data sent over the wire, and associated application config(s) that result from the relationship.

However the tests pass!
juju-test.conductor.10-deploy RESULT : ✔
juju-test INFO : Results: 1 passed, 0 failed, 1 errored

I've made a minor update to the readme that you will want to backport to your development branch(es) to keep from diverging, as the zookeeper_data_dir is an immutable config option. I can see why this is the case as changing it post deployment will be destructive.

The charm bug tracker can be found at: https://bugs.launchpad.net/charms/trusty/+source/hdp-zookeeper

The charm will subsequently show up in the store within the next 30 minutes. Congratulations!