Thank you for your continued work on this charm. Its progressing nicely, and the simplicity in approach to configuring the service leveraging MapR's existing list files is a nice touch. I've been reviewing the charm as is and I have some notes below:
Following along from the readme, the example instructions need some tweaks to work with recent revisions of Juju. I've tested this on 0.16.5 and 0.17.1 - using -constraints="instance-type=m1.xlarge" maprcharm MyCluster - 2 things with this statement. The new format of constraints if cpu=X mem=Y which I see you have illustrated in the test, but not the docs. And MyCluster seems to not be a valid service name, changing to "mycluster" worked a treat.
After the service was deployed and scaled, the web service was not configured correctly. Visiting http://ip:8443 the web server sent the server side include as a download. I restarted all the daemons on the system and still was unable to view the web management interface.
I'm going to move the status of the charm to "incomplete", and when these items have been cleared up set the status to "new" or "needs review" and someone will be along shortly to re-review the charm.
Greetings David,
Thank you for your continued work on this charm. Its progressing nicely, and the simplicity in approach to configuring the service leveraging MapR's existing list files is a nice touch. I've been reviewing the charm as is and I have some notes below:
Following along from the readme, the example instructions need some tweaks to work with recent revisions of Juju. I've tested this on 0.16.5 and 0.17.1 - using -constraints= "instance- type=m1. xlarge" maprcharm MyCluster - 2 things with this statement. The new format of constraints if cpu=X mem=Y which I see you have illustrated in the test, but not the docs. And MyCluster seems to not be a valid service name, changing to "mycluster" worked a treat.
After the service was deployed and scaled, the web service was not configured correctly. Visiting http:// ip:8443 the web server sent the server side include as a download. I restarted all the daemons on the system and still was unable to view the web management interface.
I'm going to move the status of the charm to "incomplete", and when these items have been cleared up set the status to "new" or "needs review" and someone will be along shortly to re-review the charm.
Thanks