Charm needed: pagekite

Hello, charmers!

I'm submitting this charm for the Charm Store. The branch can be accessed at lp:~jose/charms/precise/pagekite/trunk (https://code.launchpad.net/~jose/charms/precise/pagekite/trunk).

There are known limitations to the charm, but these are set by the service instead rather than the charm. As I said on the charm's README file:

"Pagekite only natively supports HTTP, HTTPS and some versions of the Minecraft protocol. If you want to connect to another service while tunneling it, you will need to tell the client to treat the kite's address as an HTTP Proxy."

Apart from that, deployment is successful and everything works as expecten when I deployed.

If you have any comments/find any bugs, please let me know and I'll fix them as soon as possible.

Thanks!

Jose,

Thanks for taking the time to charm up pagekite and getting it ready for review and inclusion into the Juju Charm Store. Your contribution to the Juju Charm Store and Juju community are very much appreciated.

This post is to let you know the ~charmer teams has seen this submission in the review queue and we will be giving you an in-depth review of your charm shortly.

If you have any questions in the mean time please ping us in #juju on Freenode.

-thanks,
Antonio

# I am providing a initial +1 review. A ~charmer will give a final review and merge this charm for inclusion in the Charm Store if they don't have any additional feedback.

## Review points:
- Charm passes charm proof
- Description in metadata.yaml
- Maintainer field set in metadata.yaml
-Copyright file included with GPL-3 license
- Successfully deploys in EC2 with default config.
- apt-get deb from upstream, pagekite.net (with apt-key)
- No tests. I talked with Jose about this in IRC and he is looking into Amulet. While our policy doesn't state tests must be included there is a current proposal out to include test[0]

### Knit pics
- Readme could have an explict "cookbook" example of how a user could execute each command and get a working deployment. For example, in addition to having the [charmname] example you could specifically mention a charm so a user could programmatically follow each step.
- The metadata.yaml could also mention what the charm specifically does in addition to the service description.

## Summary
- Initial review looks good and is ready for an in-depth review review by the ~charmers team.
- A plus would be to have tests and a "cook book" example in the Readme.
- Good first charm submission.

[0] https://lists.ubuntu.com/archives/juju/2013-December/003330.html

-thanks,
Antonio

Hey, Antonio!

I'm taking all your suggestions, but am currently blocked as the Amulet test would need to have some sensitive credentials on it - looking for the best way to manage that.

I'll be pushing the other fixes ASAP!

Charm currently has a bug which prevents it from relating to another instances. I'll make sure to tackle this down and mark it as `Fix Committed` again.

Thanks for taking a look at these problems in pagekite! Put the bug in "Fix Committed" when you are done.