"console=ttyS0,115200 console=tty0" is hard coded and triggers reboot required unnecessarily
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| charm-sysconfig |
Fix Committed
|
Medium
|
Ashley James | ||
Bug Description
juju deploy --series jammy sysconfig --config governor=
juju add-relation sysconfig "<workload-charm>"
Then, the sysconfig status becomes to:
> update-grub and reboot required Changes in: /etc/default/
This is unexpected because:
1. reboot is not required to apply CPU governor configuration since it can be on the fly.
2. the charm is very opinionated about the GRUB config but it hardcodes tty0 and ttyS0 even when the system already had those values from MAAS kernel parameters.
[/etc/default/
GRUB_CMDLINE_
GRUB_CMDLINE_
3. there is nothing changed in /etc/systemd/
Related branches
- Andrea Ieri: Approve
- 🤖 prod-jenkaas-bootstack: Approve (continuous-integration)
- Eric Chen: Approve
- BootStack Reviewers: Pending requested
-
Diff: 439 lines (+201/-85)4 files modifiedsrc/lib/lib_sysconfig.py (+43/-6)
src/tests/functional/conftest.py (+101/-0)
src/tests/functional/test_deploy.py (+18/-78)
src/tests/unit/test_lib.py (+39/-1)
- Eric Chen: Approve
- 🤖 prod-jenkaas-bootstack: Approve (continuous-integration)
- Robert Gildein: Approve
- JamesLin: Approve
- BootStack Reviewers: Pending requested
-
Diff: 100 lines (+28/-9)4 files modifiedsrc/lib/lib_sysconfig.py (+8/-0)
src/reactive/sysconfig.py (+10/-5)
src/templates/grub.j2 (+0/-1)
src/tests/functional/test_deploy.py (+10/-3)
- JamesLin: Approve
- 🤖 prod-jenkaas-bootstack: Approve (continuous-integration)
- Eric Chen: Approve
- Erhan Sunar (community): Needs Fixing
- BootStack Reviewers: Pending requested
-
Diff: 149 lines (+71/-7)5 files modifiedsrc/actions.yaml (+1/-1)
src/config.yaml (+3/-0)
src/lib/lib_sysconfig.py (+26/-1)
src/templates/grub.j2 (+0/-5)
src/tests/unit/test_lib.py (+41/-0)
- JamesLin: Approve
- 🤖 prod-jenkaas-bootstack: Approve (continuous-integration)
- Mert Kirpici (community): Approve
- BootStack Reviewers: Pending requested
- BootStack Reviewers: Pending requested
-
Diff: 32 lines (+3/-2)2 files modifiedsrc/lib/lib_sysconfig.py (+2/-1)
src/tests/functional/test_deploy.py (+1/-1)
| Nobuto Murata (nobuto) wrote | #1 |
| Nobuto Murata (nobuto) wrote | #2 |
| Nobuto Murata (nobuto) wrote | #3 |
| Changed in charm-sysconfig: | |
| importance: | Undecided → Medium |
| tags: | added: bseng-1027 |
| Changed in charm-sysconfig: | |
| status: | New → Triaged |
| Changed in charm-sysconfig: | |
| assignee: | nobody → Ashley James (dashmage) |
| Changed in charm-sysconfig: | |
| status: | Triaged → In Progress |
| Ashley James (dashmage) wrote | #4 |
| Changed in charm-sysconfig: | |
| status: | In Progress → Fix Committed |
| Changed in charm-sysconfig: | |
| milestone: | none → 23.07 |
| Changed in charm-sysconfig: | |
| status: | Fix Committed → Fix Released |
| Nobuto Murata (nobuto) wrote | #5 |
| Changed in charm-sysconfig: | |
| status: | Fix Released → Confirmed |
| Changed in charm-sysconfig: | |
| assignee: | Ashley James (dashmage) → nobody |
| Changed in charm-sysconfig: | |
| assignee: | nobody → Ashley James (dashmage) |
| status: | Confirmed → Fix Committed |
| Changed in charm-sysconfig: | |
| milestone: | 23.07 → 23.10 |
For the record, "clear-