OpenStack Swift Proxy Charm

stopped proxy can be inadvertently started by config change

Bug #1723427 reported by Edward Hope-Morley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Swift Proxy Charm
Triaged
High
Unassigned

Bug Description

During a ring sync across proxy units we stop proxy services until rings are synced to ensure consistency for api calls. We are not, however, disabling the service (we just stop it) which means that it could be restarted by an config changes made during a sync that would result in a restart_on_change(). We should permanently stop and disable the service until we are ready to start it.

If we don' do this we easily run into a situation where the charm does a start() following a sync and this has no effect because the service is already started but has failed due to rings not yet existing e.g. https://pastebin.canonical.com/200596/

I believe that this could actually be critical since it could result in the swift-proxy service never being restarted following sync.

Tags: openstack sts
James Page (james-page)
Changed in charm-swift-proxy:
milestone: 17.11 → 18.02
Ryan Beisner (1chb1n)
Changed in charm-swift-proxy:
milestone: 18.02 → 18.05
David Ames (thedac)
Changed in charm-swift-proxy:
milestone: 18.05 → 18.08
James Page (james-page)
Changed in charm-swift-proxy:
milestone: 18.08 → 18.11
David Ames (thedac)
Changed in charm-swift-proxy:
milestone: 18.11 → 19.04
Revision history for this message
David O Neill (dmzoneill) wrote :

Please consider:

https://review.openstack.org/#/c/636622/

Revision history for this message
Edward Hope-Morley (hopem) wrote :

@dmzoneill please ensure that the LP associated with a patch has its status correctly updated. Normally this is taken care of by gerrit but since in this case the format was nor correct on first submit the update didn't happen. I'll update this one but please remember for future patches.

Changed in charm-swift-proxy:
assignee: nobody → David O Neill (dmzoneill)
status: Confirmed → In Progress
David Ames (thedac)
Changed in charm-swift-proxy:
milestone: 19.04 → 19.07
David Ames (thedac)
Changed in charm-swift-proxy:
milestone: 19.07 → 19.10
David Ames (thedac)
Changed in charm-swift-proxy:
milestone: 19.10 → 20.01
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-swift-proxy (master)

Change abandoned by James Page (<email address hidden>) on branch: master
Review: https://review.opendev.org/636622
Reason: No response in 4 months to review feedback as requested - closing review.

Please re-open and address feedback if still required.

James Page (james-page)
Changed in charm-swift-proxy:
milestone: 20.01 → 20.05
David Ames (thedac)
Changed in charm-swift-proxy:
milestone: 20.05 → 20.08
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Assuming this is no longer being worked on since the patch was abandoned several months ago. I'll go ahead and remove the current assignee to allow someone else to take it on.

Changed in charm-swift-proxy:
assignee: David O Neill (dmzoneill) → nobody
status: In Progress → New
James Page (james-page)
Changed in charm-swift-proxy:
milestone: 20.08 → none
Alex Kavanagh (ajkavanagh)
Changed in charm-swift-proxy:
status: New → Triaged
importance: High → Wishlist
importance: Wishlist → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.