Newly added targets don't show up without restarting prometheus
Bug #1891942 reported by
Drew Freiberger
This bug affects 6 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Prometheus2 charm |
Fix Released
|
Critical
|
Unassigned | ||
Bug Description
This merge added code to use the web hook to reload the configuration file via web hook /-/reload, but the daemon argument --web.enable-
Ultimately, newly related targets don't cause config file reloads, so data doesn't start flowing into prometheus without the operator restarting the service or running kill -HUP on the service.
Recommend adding daemon arg --web.enable-
https:/
The runtime_args code doesn't seem like it would support value-less binary runtime args, however, so this may require a slight refactor.
Related branches
~aieri/charm-prometheus2:lp1891942-properly-reload-prom-process-via-sighup
- Jeremy Lounder (community): Approve
- Drew Freiberger: Pending requested
- Jose Guedez: Pending requested
- Alvaro Uria: Pending requested
-
Diff: 117 lines (+31/-16)3 files modifiedsrc/reactive/prometheus.py (+8/-12)
src/tests/functional/tests/tests_prometheus.py (+23/-1)
src/tests/unit/test_reactive_prometheus.py (+0/-3)
~exsdev/charm-prometheus2:lp1891942-properly-reload-prom-process-via-sighup
- Alvaro Uria (community): Needs Fixing
- Drew Freiberger (community): Approve
- Jose Guedez (community): Approve
-
Diff: 78 lines (+30/-7)2 files modifiedsrc/reactive/prometheus.py (+6/-7)
src/tests/functional/tests/tests_prometheus.py (+24/-0)
Revision history for this message
| Drew Freiberger (afreiberger) wrote | #1 |
| Changed in charm-prometheus2: | |
| importance: | Undecided → Critical |
| Changed in charm-prometheus2: | |
| assignee: | nobody → Edin S (exsdev) |
Revision history for this message
| Liam Young (gnuoy) wrote | #2 |
Revision history for this message
| Liam Young (gnuoy) wrote | #3 |
| Changed in charm-prometheus2: | |
| status: | New → In Progress |
| Changed in charm-prometheus2: | |
| assignee: | Edin S (exsdev) → Andrea Ieri (aieri) |
| status: | In Progress → Fix Committed |
Revision history for this message
| Andrea Ieri (aieri) wrote | #4 |
| Changed in charm-prometheus2: | |
| assignee: | Andrea Ieri (aieri) → nobody |
Revision history for this message
| David Coronel (davecore) wrote | #5 |
| tags: | added: sts |
| Changed in charm-prometheus2: | |
| status: | Fix Committed → Fix Released |
| milestone: | none → 20.10 |
To post a comment you must log in.
Suggest functional test that adds a new "target" relation and then checks that the new target exists in running prometheus via api endpoint /targets.