OpenStack Dashboard Charm

[19.04] websso path is incorrectly formatted if webroot is set to '/'

Bug #1828021 reported by Dmitrii Shcherbakov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard Charm
Fix Released
High
Dmitrii Shcherbakov
OpenStack Dashboard Charm 19.04

Bug Description

If webroot is '/' the resulting path becomes '//' after joining which leads to 'path: //auth/websso/' passed in relation data.

As a result authentication attempts fail with:

'ERROR https://dashboard.maas/auth/websso/ is not a trusted dashboard host'

Tags: cpe-onsite
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-openstack-dashboard (master)

Fix proposed to branch: master
Review: https://review.opendev.org/657566

Revision history for this message
Dmitrii Shcherbakov (dmitriis) wrote :

Subscribed ~field-high.

Revision history for this message
Dmitrii Shcherbakov (dmitriis) wrote :

See https://review.opendev.org/657566

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-openstack-dashboard (master)

Reviewed: https://review.opendev.org/657566
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=d28f593d6688b01ab48068b6f4868ef03ef9108d
Submitter: Zuul
Branch: master

commit d28f593d6688b01ab48068b6f4868ef03ef9108d
Author: Dmitrii Shcherbakov <email address hidden>
Date: Tue May 7 02:18:29 2019 +0300

    Fix websso path formatting

    If webroot is '/' the resulting path becomes '//' after joining which
    leads to 'path: //auth/websso/' passed in relation data.

    As a result authentication attempts fail with:

    'ERROR https://dashboard.maas/auth/websso/ is not a trusted dashboard
    host'

    Change-Id: I14e7ff1ec548de4ec98ee41fc27c8948b56fafec
    Closes-Bug: #1815205
    Closes-Bug: #1828021

Changed in charm-openstack-dashboard:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-openstack-dashboard (stable/19.04)

Fix proposed to branch: stable/19.04
Review: https://review.opendev.org/657668

Revision history for this message
David Ames (thedac) wrote :

Back port to stable:
https://review.opendev.org/#/c/657668/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-openstack-dashboard (stable/19.04)

Reviewed: https://review.opendev.org/657668
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=9ca74deceaac535334ec4cacd073feebbaa1d1aa
Submitter: Zuul
Branch: stable/19.04

commit 9ca74deceaac535334ec4cacd073feebbaa1d1aa
Author: Dmitrii Shcherbakov <email address hidden>
Date: Tue May 7 02:18:29 2019 +0300

    Fix websso path formatting

    If webroot is '/' the resulting path becomes '//' after joining which
    leads to 'path: //auth/websso/' passed in relation data.

    As a result authentication attempts fail with:

    'ERROR https://dashboard.maas/auth/websso/ is not a trusted dashboard
    host'

    Change-Id: I14e7ff1ec548de4ec98ee41fc27c8948b56fafec
    Closes-Bug: #1815205
    Closes-Bug: #1828021
    (cherry picked from commit d28f593d6688b01ab48068b6f4868ef03ef9108d)

Dmitrii Shcherbakov (dmitriis)
Changed in charm-openstack-dashboard:
milestone: none → 19.04
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.