make fip toplogy check configurable

Bug #1815032 reported by Edward Hope-Morley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard Charm
Fix Released
Medium
Edward Hope-Morley

Bug Description

We have seen cases in the field where, instead of having the common topology of one router per project, some users are prefering to have a single router owned by an admin project, connected to the external network and then have non-admin projects use that router for external networking i.e. floating ips. By default Horizon performs a network topology check [1] that prevent projects from associating a floating ip with an instance if the router is not owned by that same project. The proposal here is to make this configurable to enable both use cases.

[1] https://docs.openstack.org/horizon/latest/configuration/settings.html#enable-fip-topology-check

Tags: sts
Changed in charm-openstack-dashboard:
importance: Undecided → Medium
Changed in charm-openstack-dashboard:
status: New → In Progress
Revision history for this message
Edward Hope-Morley (hopem) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-openstack-dashboard (master)

Reviewed: https://review.openstack.org/635489
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=ac7793ffee62c5356980bc0011c43939f0e755e0
Submitter: Zuul
Branch: master

commit ac7793ffee62c5356980bc0011c43939f0e755e0
Author: Edward Hope-Morley <email address hidden>
Date: Thu Feb 7 11:42:38 2019 +0000

    Make fip topology check configurable

    Horizon will by default check that a project has
    a router with a port on an external network prior
    to allowing floating ips to be attached to
    instances. Since it is valid to use a shared
    router from a different project we make this
    configurable to allow disabling this check.

    Closes-Bug: #1815032
    Change-Id: I5c3e44e5daa683e14ac39979d6e9a7c2238dd120

Changed in charm-openstack-dashboard:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-openstack-dashboard (stable/18.11)

Fix proposed to branch: stable/18.11
Review: https://review.openstack.org/636308

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-openstack-dashboard (stable/18.11)

Reviewed: https://review.openstack.org/636308
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=c82490eabafe2060435da8718bc07d72912827f6
Submitter: Zuul
Branch: stable/18.11

commit c82490eabafe2060435da8718bc07d72912827f6
Author: Edward Hope-Morley <email address hidden>
Date: Thu Feb 7 11:42:38 2019 +0000

    Make fip topology check configurable

    Horizon will by default check that a project has
    a router with a port on an external network prior
    to allowing floating ips to be attached to
    instances. Since it is valid to use a shared
    router from a different project we make this
    configurable to allow disabling this check.

    Closes-Bug: #1815032
    Change-Id: I5c3e44e5daa683e14ac39979d6e9a7c2238dd120
    (cherry picked from commit ac7793ffee62c5356980bc0011c43939f0e755e0)

David Ames (thedac)
Changed in charm-openstack-dashboard:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.