Allow to configure password_autocomplete = on/off

Bug #1714676 reported by Nobuto Murata
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard Charm
Fix Released
Wishlist
Nobuto Murata

Bug Description

Horizon does not allow username/password auto-completion with browsers by default by putting a fake form before a real login form. It would be arguable to allow password completion by browsers, but it helps user to configure more complicated/strong password. It would be nice if the charm supports to configure on/off of password auto-completion.

[openstack_dashboard/local/local_settings.py.example]
# Turn off browser autocompletion for forms including the login form and
# the database creation workflow if so desired.
#HORIZON_CONFIG["password_autocomplete"] = "off"

[horizon/templates/auth/_login_form.html]
      {% if HORIZON_CONFIG.password_autocomplete != "on" %}
        <div class="fake_credentials" style="display: none">
          <input type="text" name="fake_email" value="" />
          <input type="password" name="fake_password" value="" />
        </div>
      {%endif%}

Tags: cpe-onsite
Changed in charm-openstack-dashboard:
importance: Undecided → Wishlist
status: New → Triaged
Chris Gregan (cgregan)
tags: added: cpe-onsite
Nobuto Murata (nobuto)
Changed in charm-openstack-dashboard:
assignee: nobody → Nobuto Murata (nobuto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-openstack-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/511522

Changed in charm-openstack-dashboard:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-openstack-dashboard (master)

Reviewed: https://review.openstack.org/511522
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=a0551816582a360e287e79a0a0b48744de8ad03b
Submitter: Zuul
Branch: master

commit a0551816582a360e287e79a0a0b48744de8ad03b
Author: Nobuto Murata <email address hidden>
Date: Thu Oct 12 12:25:30 2017 -0400

    Allow to enable password autocompletion by browser

    Horizon tries to inhibit browsers' password autocompletion by default.
    Offer a configurable option in the charm so that admin can allow
    password autocompletion if necessary.

    Change-Id: I461752d1d1175f777de5bff26953b200efb17137
    Closes-Bug: 1714676

Changed in charm-openstack-dashboard:
status: In Progress → Fix Committed
James Page (james-page)
Changed in charm-openstack-dashboard:
milestone: none → 17.11
James Page (james-page)
Changed in charm-openstack-dashboard:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.