OpenStack Nova Compute Charm

no neutron-plugin services checks

Bug #1530227 reported by JuanJo Ciarlante
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Neutron Open vSwitch Charm
Triaged
Wishlist
Unassigned
OpenStack Nova Compute Charm
Triaged
Wishlist
Unassigned
neutron-openvswitch (Juju Charms Collection)
Invalid
Low
Unassigned
nova-compute (Juju Charms Collection)
Invalid
Low
Unassigned

Bug Description

nova-compute nrpe hooks currently adds these service checks:

# grep ^c /etc/nagios/nrpe.d/check_{nova-compute,libvirt-bin}.cfg
/etc/nagios/nrpe.d/check_nova-compute.cfg:command[check_nova-compute]=/usr/local/lib/nagios/plugins/check_upstart_job nova-compute
/etc/nagios/nrpe.d/check_libvirt-bin.cfg:command[check_libvirt-bin]=/usr/local/lib/nagios/plugins/check_upstart_job libvirt-bin

but it misses to check required services when related to
neutron-plugin, e.g. for neutron-plugin-openvswitch-agent
it should also check for:
- openvswitch-switch
- neutron-plugin-openvswitch-agent

These checks 'logically' belong to the subordinate plugin charm
(neutron-openvswitch in this case), but afaiu it would be cumbersome
to have the nrpe checks *implemented* there, as it'd require
a *2nd* nrpe relation as subordinate<->subordinate:

juju add-relation nrpe-external-master neutron-openvswitch

, alonside already existing:

juju add-relation nrpe-external-master nova-compute

I'm not even sure that subord<->subord relations are supported, or
considered a good practice.

Related branches

lp://staging/~jjo/charms/trusty/nova-compute/add-neutron-plugin-nrpe-checks-lp1530227
OpenStack Charmers: Pending requested
Diff: 175 lines (+108/-2)
2 files modified
hooks/charmhelpers/contrib/charmsupport/nrpe.py (+100/-2)
hooks/nova_compute_hooks.py (+8/-0)
lp://staging/~jjo/charms/trusty/neutron-openvswitch/add-nrpe-checks-lp1530227
OpenStack Charmers: Pending requested
Diff: 998 lines (+914/-0)
7 files modified
charm-helpers-hooks.yaml (+1/-0)
config.yaml (+6/-0)
files/nrpe-external-master/neutron-check-tun_ids.py (+219/-0)
hooks/charmhelpers/contrib/charmsupport/__init__.py (+15/-0)
hooks/charmhelpers/contrib/charmsupport/nrpe.py (+458/-0)
hooks/charmhelpers/contrib/charmsupport/volumes.py (+175/-0)
hooks/neutron_ovs_hooks.py (+40/-0)
Revision history for this message
JuanJo Ciarlante (jjo) wrote :

FYI a PoC addition to nova-compute that implements these checks when
related to neutron-openvswitch: http://paste.ubuntu.com/14297836/
(note it also adds a check for OVS tun_ids to match neutron provider:segment_id)

Edward Hope-Morley (hopem)
Changed in neutron-openvswitch (Juju Charms Collection):
assignee: nobody → JuanJo Ciarlante (jjo)
Changed in nova-compute (Juju Charms Collection):
assignee: nobody → JuanJo Ciarlante (jjo)
Changed in neutron-openvswitch (Juju Charms Collection):
status: New → In Progress
Changed in nova-compute (Juju Charms Collection):
status: New → In Progress
Changed in neutron-openvswitch (Juju Charms Collection):
importance: Undecided → Low
Changed in nova-compute (Juju Charms Collection):
importance: Undecided → Low
Changed in neutron-openvswitch (Juju Charms Collection):
milestone: none → 16.04
Changed in nova-compute (Juju Charms Collection):
milestone: none → 16.04
James Page (james-page)
Changed in nova-compute (Juju Charms Collection):
milestone: 16.04 → 16.07
Changed in neutron-openvswitch (Juju Charms Collection):
milestone: 16.04 → 16.07
Liam Young (gnuoy)
Changed in nova-compute (Juju Charms Collection):
milestone: 16.07 → 16.10
Changed in neutron-openvswitch (Juju Charms Collection):
milestone: 16.07 → 16.10
James Page (james-page)
Changed in nova-compute (Juju Charms Collection):
milestone: 16.10 → 17.01
Changed in neutron-openvswitch (Juju Charms Collection):
milestone: 16.10 → 17.01
James Page (james-page)
Changed in charm-nova-compute:
assignee: nobody → JuanJo Ciarlante (jjo)
importance: Undecided → Low
status: New → In Progress
Changed in nova-compute (Juju Charms Collection):
status: In Progress → Invalid
James Page (james-page)
Changed in charm-neutron-openvswitch:
assignee: nobody → JuanJo Ciarlante (jjo)
importance: Undecided → Low
status: New → In Progress
Changed in neutron-openvswitch (Juju Charms Collection):
status: In Progress → Invalid
JuanJo Ciarlante (jjo)
Changed in charm-neutron-openvswitch:
assignee: JuanJo Ciarlante (jjo) → nobody
Changed in charm-nova-compute:
assignee: JuanJo Ciarlante (jjo) → nobody
Changed in neutron-openvswitch (Juju Charms Collection):
assignee: JuanJo Ciarlante (jjo) → nobody
Changed in nova-compute (Juju Charms Collection):
assignee: JuanJo Ciarlante (jjo) → nobody
Edward Hope-Morley (hopem)
Changed in neutron-openvswitch (Juju Charms Collection):
milestone: 17.01 → none
Changed in nova-compute (Juju Charms Collection):
milestone: 17.01 → none
Changed in charm-neutron-openvswitch:
status: In Progress → New
Changed in charm-nova-compute:
status: In Progress → New
James Page (james-page)
Changed in charm-neutron-openvswitch:
status: New → Triaged
Changed in charm-nova-compute:
status: New → Triaged
Revision history for this message
Lorenzo Cavassa (lorenzo-cavassa) wrote :

Hi,

This bug affects also a deployment on which I'm working on. No N-G and just local DHCP/Metadata services on the the compute nodes.
It would be really helpful to get those checks set up during the relation creation between nrpe and neuntron-openvswitch.

Revision history for this message
Alvaro Uria (aluria) wrote :

Hi,

I've updated Juanjo's script at [0]: 1) minor rewrite for py3, 2) works on keystonev3 environments.

Since the type of neutron-plugin is configured on charm-neutron-api, but charm-neutron-openvswitch is related to charm-nova-compute, I think this fix should be added in charm-neutron-openvswitch.

According to [1], nrpe-external-master relation doesn't exist, and I think "juju add-relation neutron-openvswitch:nrpe-external-master nrpe:nrpe-external-master" should trigger the addition of this check.

Output looks like:
"""
OK: all needed tun_ids present: [1031, 1064, 1097, 1128, 1041, 1078]
"""

NRPE check would need to be split in two:
1) cronjob run as nova user: 1) will have access to /etc/nova/nova.conf to gather keystone credentials to list instances, networks and ports; 2) will need to use rootwrap which enables "ovs-ofctl" command run_as root

2) nrpe check which parses generated output by step #1

0. https://pastebin.canonical.com/p/5jSJzW8t5V/
1. https://github.com/openstack/charm-neutron-openvswitch/blob/master/metadata.yaml

Alvaro Uria (aluria)
summary: - nrpe hook lacks neutron-plugin upstart services check
+ no neutron-plugin services checks
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

As this is new feature work, and there is no proposal to add these features, I don't believe this should be subscribed to field-medium.

Changed in charm-neutron-openvswitch:
importance: Low → Wishlist
Changed in charm-nova-compute:
importance: Low → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.