Neutron netns check CRIT/CRITICAL mismatch
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
NRPE Charm |
Triaged
|
Low
|
Unassigned | ||
OpenStack Neutron Gateway Charm |
New
|
Undecided
|
Unassigned |
Bug Description
The included check_netns.sh script for checking neutron gateway netns issues uses "CRIT" to report critical errors, but check_status_
The former script is here, and writes its output to a file when called by cron, so the "exit $STATE_CRIT" never reaches the check, which can only read the contents of the log file:
https:/
An error state will be recorded in the log file as e.g. "CRIT: [...] aren't responding".
But the script used by the check, check_status_
https:/
Related branches
- 🤖 prod-jenkaas-bootstack: Needs Fixing (continuous-integration)
- BootStack Reviewers: Pending requested
- BootStack Reviewers: Pending requested
-
Diff: 21 lines (+2/-2)1 file modifiedfiles/plugins/check_netns.sh (+2/-2)
tags: | added: bseng-761 |
Changed in charm-nrpe: | |
importance: | Undecided → Low |
status: | New → Triaged |
Marking this as also affecting the neutron-gateway charm, as that's where I came across it.
If desired, this could be worked around in that charm's code with something like:
- check_cmd= 'check_ status_ file.py -f /var/lib/ nagios/ netns-check. txt' 'check_ status_ file.py -c CRIT -f /var/lib/ nagios/ netns-check. txt'
+ check_cmd=
https:/ /opendev. org/openstack/ charm-neutron- gateway/ src/branch/ master/ hooks/neutron_ hooks.py# L347
Happy to propose that fix if desired.