OpenStack Neutron API Open Daylight Charm (Retired)

tox ERROR: py27: nothing to do

Bug #1642981 reported by Ryan Beisner on 2016-11-18

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
OpenStack AODH Charm	Fix Released	High	Ryan Beisner	OpenStack AODH Charm 17.02
OpenStack Barbican Charm	Fix Released	High	Ryan Beisner	OpenStack Barbican Charm 17.02
OpenStack Barbican SoftHSM Charm	Fix Released	High	Ryan Beisner	OpenStack Barbican SoftHSM Charm 17.02
OpenStack Charm Test Infra	Fix Released	High	Ryan Beisner	OpenStack Charm Test Infra 17.02
OpenStack Designate Charm	Fix Released	High	Ryan Beisner	OpenStack Designate Charm 17.02
OpenStack Designate-Bind Charm	Fix Released	High	Ryan Beisner	OpenStack Designate-Bind Charm 17.02
OpenStack Neutron API Open Daylight Charm (Retired)	Fix Released	High	Ryan Beisner	OpenStack Neutron API Open Daylight Charm (Retired) 17.02
OpenStack Tempest Charm (Deprecated)	Fix Released	High	Ryan Beisner	OpenStack Tempest Charm (Deprecated) 17.02
OpenStack openvswitch-odl charm	Fix Released	High	Ryan Beisner	OpenStack openvswitch-odl charm 17.02
neutron-api-odl (Juju Charms Collection)	Invalid	High	Ryan Beisner
openvswitch-odl (Juju Charms Collection)	Invalid	High	Ryan Beisner

Bug Description

tox ERROR: nothing to do

All of the source (layer) OpenStack Charms are failing py27 in upstream gate tests. These charm unit tests are Python3-only, and should not have a py27 test declared in upstream project-config.

To illustrate, here is a batch of README changes, all failing on the non-existent py27 test:

https://review.openstack.org/#/q/topic:update-readme+owner:%22Ryan+Beisner%22+status:open

WIP project-config changes are here:

https://review.openstack.org/#/c/399299/

Example of tox output failure on py27:

2016-11-17 21:13:28.744743 | ERROR: Commands not specified. Please update relevant section of /home/jenkins/workspace/gate-charm-aodh-python27-ubuntu-xenial/tox.ini
2016-11-17 21:13:28.744826 | ___________________________________ summary ____________________________________
2016-11-17 21:13:28.744869 | ERROR: py27: nothing to do

Tags:

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2016-11-18:

Looking back, previous changes passed the missing py27 test. There must have been a behavior change in one of the test runners. I've not dug too deeply, as I agree with the current fail-when-missing behavior.

Changed in charm-aodh:
assignee:	nobody → Ryan Beisner (1chb1n)
Changed in charm-barbican:
assignee:	nobody → Ryan Beisner (1chb1n)
Changed in charm-barbican-softhsm:
assignee:	nobody → Ryan Beisner (1chb1n)
Changed in charm-designate:
assignee:	nobody → Ryan Beisner (1chb1n)
Changed in charm-designate-bind:
assignee:	nobody → Ryan Beisner (1chb1n)
Changed in charm-tempest:
assignee:	nobody → Ryan Beisner (1chb1n)
Changed in charm-aodh:
importance:	Undecided → Critical
Changed in charm-barbican:
importance:	Undecided → Critical
Changed in charm-barbican-softhsm:
importance:	Undecided → Critical
Changed in charm-designate:
importance:	Undecided → Critical
Changed in charm-designate-bind:
importance:	Undecided → Critical
Changed in charm-tempest:
importance:	Undecided → Critical
Changed in charm-aodh:
status:	New → In Progress
Changed in charm-barbican:
status:	New → In Progress
Changed in charm-barbican-softhsm:
status:	New → In Progress
Changed in charm-designate:
status:	New → In Progress
Changed in charm-designate-bind:
status:	New → In Progress
Changed in charm-tempest:
status:	New → In Progress

Ryan Beisner (1chb1n) on 2016-11-18

summary:

- tox ERROR: nothing to do
+ tox ERROR: py27: nothing to do

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2016-11-18:

Triaged critical, as it's impossible to land code in these repos until resolved.

Revision history for this message

Jeremy Stanley (fungi) wrote on 2016-11-18:

This appears to be a behavior change in the tox 2.5 release from Wednesday.

Revision history for this message

Jeremy Stanley (fungi) wrote on 2016-11-18:

"2.5.0: slightly backward incompatible: fix issue310: the {posargs} substitution now properly preserves the tox command line positional arguments..." https://github.com/tox-dev/tox/blob/master/CHANGELOG

Revision history for this message

Jeremy Stanley (fungi) wrote on 2016-11-18:

Actually, no, it's "fix #316: Lack of commands key in ini file is now treated as an error" but I can't figure out what command should actually be set to in the [testenv] section to retain the proper behavior for built-in env names.

Revision history for this message

Jeremy Stanley (fungi) wrote on 2016-11-18:

I was able to solve this in the openstack-infra/gerritlib repo by copying the testenv.commands key from our openstack/cookiecutter tox.ini template: https://review.openstack.org/399795

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2016-11-21:

Many thanks @fungi for the info.

Reference for future travelers:

https://github.com/tox-dev/tox/issues/316

https://github.com/tox-dev/tox/pull/407

https://github.com/tox-dev/tox/blob/1e888ce9b87d87045479ed4c320be803b05b0f38/CHANGELOG#L40

FWIW, with the affected subset of charm projects, we're not going to try to make py27 pass. Instead, we'll redefine the project-config for them so that py27 isn't attempted.

Ryan Beisner (1chb1n) on 2016-11-28

Changed in charm-test-infra:
status:	New → Confirmed
importance:	Undecided → Critical
assignee:	nobody → Ryan Beisner (1chb1n)

Ryan Beisner (1chb1n) on 2016-11-29

Changed in neutron-api-odl (Juju Charms Collection):
status:	New → In Progress
assignee:	nobody → Ryan Beisner (1chb1n)
Changed in openvswitch-odl (Juju Charms Collection):
status:	New → Triaged
status:	Triaged → In Progress
assignee:	nobody → Ryan Beisner (1chb1n)
importance:	Undecided → High
Changed in neutron-api-odl (Juju Charms Collection):
importance:	Undecided → High
Changed in charm-tempest:
importance:	Critical → High
Changed in charm-designate-bind:
importance:	Critical → High
Changed in charm-designate:
importance:	Critical → High
Changed in charm-test-infra:
importance:	Critical → Medium
Changed in charm-barbican-softhsm:
importance:	Critical → High
Changed in charm-barbican:
importance:	Critical → High
Changed in charm-aodh:
importance:	Critical → High

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-29: Fix proposed to charm-neutron-api-odl (master)

Fix proposed to branch: master
Review: https://review.openstack.org/403952

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-29: Fix proposed to charm-openvswitch-odl (master)

Fix proposed to branch: master
Review: https://review.openstack.org/403953

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2016-11-29:

#10

Please see batch of changes:

https://review.openstack.org/#/q/topic:bug/1642981

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-30: Fix merged to charm-neutron-api-odl (master)

#11

Reviewed: https://review.openstack.org/403952
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-api-odl/commit/?id=270f66adcd943921c4cbd6840f6a85e9d9fbb95a
Submitter: Jenkins
Branch: master

commit 270f66adcd943921c4cbd6840f6a85e9d9fbb95a
Author: Ryan Beisner <email address hidden>
Date: Mon Nov 28 18:21:14 2016 -0600

Update tox.ini for py27 requirement

Reactive source charms are Python3-only, but have py27 unit tests
declared in project-config.

The Tox tool recently changed behavior. It used to pass when a tox
target was missing commands. Now it fails in that case.

This commit places a py27 no-op shim to allow gate tests to pass,
effectively restoring the original behavior for these py3x-only repos.

Change-Id: I547c0ae0ac93fe7a9321a8d4d9a9711190dd5249
Partial-Bug: 1642981

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-02: Fix merged to charm-openvswitch-odl (master)

#12

Reviewed: https://review.openstack.org/403953
Committed: https://git.openstack.org/cgit/openstack/charm-openvswitch-odl/commit/?id=57460f71ea7180870b3d23fc15e40cd18133e691
Submitter: Jenkins
Branch: master

commit 57460f71ea7180870b3d23fc15e40cd18133e691
Author: Ryan Beisner <email address hidden>
Date: Mon Nov 28 18:21:20 2016 -0600

Update tox.ini for py27 requirement

Reactive source charms are Python3-only, but have py27 unit tests
declared in project-config.

The Tox tool recently changed behavior. It used to pass when a tox
target was missing commands. Now it fails in that case.

This commit places a py27 no-op shim to allow gate tests to pass,
effectively restoring the original behavior for these py3x-only repos.

Change-Id: I3b53e36874805f453b29de28b76184aaf2da5c97
Partial-Bug: 1642981

Ryan Beisner (1chb1n) on 2016-12-05

Changed in charm-test-infra:
status:	Confirmed → In Progress
Changed in charm-aodh:
status:	In Progress → Fix Committed
Changed in charm-barbican-softhsm:
status:	In Progress → Fix Committed
Changed in charm-designate:
status:	In Progress → Fix Committed
Changed in charm-designate-bind:
status:	In Progress → Fix Committed
Changed in neutron-api-odl (Juju Charms Collection):
status:	In Progress → Fix Committed
Changed in openvswitch-odl (Juju Charms Collection):
status:	In Progress → Fix Committed
Changed in charm-tempest:
status:	In Progress → Fix Committed
Changed in charm-test-infra:
importance:	Medium → High

Ryan Beisner (1chb1n) on 2016-12-05

Changed in charm-barbican:
status:	In Progress → Fix Committed
Changed in charm-test-infra:
milestone:	none → 17.02
status:	In Progress → Fix Committed

Ryan Beisner (1chb1n) on 2017-01-05

Changed in charm-test-infra:
status:	Fix Committed → Fix Released

James Page (james-page) on 2017-02-22

Changed in charm-aodh:
milestone:	none → 17.02
Changed in charm-barbican:
milestone:	none → 17.02
Changed in charm-barbican-softhsm:
milestone:	none → 17.02
Changed in charm-tempest:
milestone:	none → 17.02
Changed in charm-designate:
milestone:	none → 17.02
Changed in charm-designate-bind:
milestone:	none → 17.02

James Page (james-page) on 2017-02-23

Changed in charm-neutron-api-odl:
assignee:	nobody → Ryan Beisner (1chb1n)
importance:	Undecided → High
status:	New → Fix Committed
Changed in neutron-api-odl (Juju Charms Collection):
status:	Fix Committed → Invalid

James Page (james-page) on 2017-02-23

Changed in charm-openvswitch-odl:
assignee:	nobody → Ryan Beisner (1chb1n)
importance:	Undecided → High
status:	New → Fix Committed
Changed in openvswitch-odl (Juju Charms Collection):
status:	Fix Committed → Invalid

James Page (james-page) on 2017-02-23

Changed in charm-neutron-api-odl:
milestone:	none → 17.02
Changed in charm-openvswitch-odl:
milestone:	none → 17.02

James Page (james-page) on 2017-02-23

Changed in charm-aodh:
status:	Fix Committed → Fix Released
Changed in charm-barbican:
status:	Fix Committed → Fix Released
Changed in charm-barbican-softhsm:
status:	Fix Committed → Fix Released
Changed in charm-tempest:
status:	Fix Committed → Fix Released
Changed in charm-designate:
status:	Fix Committed → Fix Released
Changed in charm-designate-bind:
status:	Fix Committed → Fix Released
Changed in charm-neutron-api-odl:
status:	Fix Committed → Fix Released
Changed in charm-openvswitch-odl:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

auto-github-tox-dev-tox #316
[closed wontfix] Edit

Bug watches keep track of this bug in other bug trackers.