OpenStack Masakari Charm

Masakari charm does not configure correctly rabbitmq with ssl

Bug #2007567 reported by Aymen Frikha
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Masakari Charm
Fix Committed
High
James Page
Train
Won't Fix
Undecided
Unassigned
Ussuri
Fix Released
Undecided
Unassigned
Victoria
Fix Released
Undecided
Unassigned
Wallaby
Fix Released
Undecided
Unassigned
Xena
Fix Released
Undecided
Unassigned
Yoga
Fix Released
Undecided
Unassigned
Zed
Fix Released
Undecided
Unassigned

Bug Description

Hello,

In a deployment where we have charm rabbitmq related to Vault charm for SSL (AMQPS):

- ['vault:certificates', 'rabbitmq-server:certificates']

When masakari charm is related to rabbitmq: masakari:amqp rabbitmq-server:amqp

the charm does not correctly configure the rabbitmq integration. In the masakari.conf file we only have that:

transport_url = rabbit://masakari:C8MbX6mXS8mdWNZbVVGYbPbbZGTP2HNBr36jJF3VmskkZSdHNKFY6GGwkLRT3yKJ@10.25.1.154:5671,masakari:C8MbX6mXS8mdWNZbVVGYbPbbZGTP2HNBr36jJF3VmskkZSdHNKFY6GGwkLRT3yKJ@10.25.1.86:5671,masakari:C8MbX6mXS8mdWNZbVVGYbPbbZGTP2HNBr36jJF3VmskkZSdHNKFY6GGwkLRT3yKJ@10.25.1.92:5671/masakari

And we are missing that part:
[oslo_messaging_rabbit]
ssl = True
ssl_ca_file = /etc/masakari/rabbit-client-ca.pem

And we end up having those lines in the masakari-engine.log file:

2023-02-16 10:07:05.959 41952 ERROR oslo.messaging._drivers.impl_rabbit [-] Connection failed: Server unexpectedly closed connection (retrying in 0 seconds): OSError: Server unexpectedly closed connection
2023-02-16 10:07:05.963 41952 ERROR oslo.messaging._drivers.impl_rabbit [-] Connection failed: Server unexpectedly closed connection (retrying in 0 seconds): OSError: Server unexpectedly closed connection
2023-02-16 10:07:05.967 41952 ERROR oslo.messaging._drivers.impl_rabbit [-] Connection failed: Server unexpectedly closed connection (retrying in 14.0 seconds): OSError: Server unexpectedly closed connection

I'm using :
Openstack: Wallaby/stable
Ubuntu: Focal

Revision history for this message
Aymen Frikha (aym-frikha) wrote :

subscribed ~field-critical

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-masakari (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874091

Changed in charm-masakari:
status: New → In Progress
James Page (james-page)
Changed in charm-masakari:
status: In Progress → Triaged
importance: Undecided → High
assignee: nobody → James Page (james-page)
status: Triaged → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-masakari (master)

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874091
Committed: https://opendev.org/openstack/charm-masakari/commit/f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0
Submitter: "Zuul (22348)"
Branch: master

commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567

Changed in charm-masakari:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-masakari (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874432

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-masakari (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874433

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-masakari (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874434

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-masakari (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874435

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-masakari (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874436

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-masakari (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874437

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-masakari (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874432
Committed: https://opendev.org/openstack/charm-masakari/commit/3a560c49f453883de098c4b71a4528caa5dbfddc
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 3a560c49f453883de098c4b71a4528caa5dbfddc
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567
    (cherry picked from commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0)

tags: added: in-stable-zed
tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-masakari (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874433
Committed: https://opendev.org/openstack/charm-masakari/commit/5dd6f7f2c0db3bdecea4b11678df24dd6e5cc3b6
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 5dd6f7f2c0db3bdecea4b11678df24dd6e5cc3b6
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567
    (cherry picked from commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-masakari (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874434
Committed: https://opendev.org/openstack/charm-masakari/commit/144b0d04a4fb0b45f8ac6964538fc595e70cfe8a
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 144b0d04a4fb0b45f8ac6964538fc595e70cfe8a
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567
    (cherry picked from commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-masakari (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874435
Committed: https://opendev.org/openstack/charm-masakari/commit/5b0387c5f343488b1fcb3154ecf049d6c3f350bc
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 5b0387c5f343488b1fcb3154ecf049d6c3f350bc
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567
    (cherry picked from commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-masakari (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874436
Committed: https://opendev.org/openstack/charm-masakari/commit/d0bbaa0be20daccde4873c4c7235a3ac04af611c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit d0bbaa0be20daccde4873c4c7235a3ac04af611c
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567
    (cherry picked from commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0)

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Added releases/series that were affected. This was fixed in the wallaby branch and is already available to users, which was what was used for field-critical so unsubscribing the field-critical team here.

Revision history for this message
Jadon Naas (jadonn) wrote :

The fix for Ussuri was merged successfully today. The review can be seen at https://review.opendev.org/c/openstack/charm-masakari/+/874437. This issue should be fixed for all the releases except Train as noted.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.