OpenStack Manila Charm

upgrading does not update 'openstack-release-version' and installs wrong dependencies

Bug #1981736 reported by Rodrigo Barbieri
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Gnocchi Charm
In Progress
Undecided
Unassigned
OpenStack AODH Charm
In Progress
Undecided
Unassigned
OpenStack Designate Charm
In Progress
Undecided
Unassigned
OpenStack Manila Charm
In Progress
High
Alex Kavanagh
charms.openstack
In Progress
High
Alex Kavanagh

Bug Description

There is a property in the sqlite .unit-state.db file named "charmers.openstack-release-version" which tracks the openstack release should be installed.

Unfortunately, when upgrading manila openstack release from queens to rocky for example, or rocky to stein, and so on, does not update this property. This results in the following reproducible issues:

1) upgrading from queens to rocky changes the dependencies from py2 to py3. Therefore, due to the above mentioned issues, both dependencies end up being installed:

$ dpkg --list | grep pymysql
ii python-pymysql 0.8.0-1 all Pure-Python MySQL driver - Python 2.x
ii python3-pymysql 0.8.0-1 all Pure-Python MySQL Driver - Python 3.x

This issue is not immediately detectable since there are no charm/hook errors produced by that anomaly.

2) upgrading from bionic-ussuri to focal-ussuri, having upgraded from queens cause the following error:

unit-manila-4: 11:00:56 WARNING unit.manila/4.config-changed subprocess.CalledProcessError: Command '['apt-get', '--assume-yes', '--option=Dpkg::Options::=--force-confold', 'install', 'python-pymysql', 'python-memcache']' returned non-zero exit status 100.
unit-manila-4: 11:00:57 ERROR juju.worker.uniter.operation hook "config-changed" (via explicit, bespoke hook script) failed: exit status 1

however, the above errors are not immediately triggered upon a completed upgrade. They are only triggered when a config-changed invokes the install charm function, which may happen due to various reasons such as updating the ssl certs.

Certainly future errors would arise independently of being deployed on queens, such as when dependencies change again or are no longer available in newer ubuntu versions such as jammy.

The property should be updated every time the openstack version of manila is upgraded through the charm.

Steps to reproduce the sqlite inconsistency:
1) deploy any version of manila
2) upgrade it
3) check the .unit-state.db file, property charmers.openstack-release-version

Steps to reproduce the upgrade errors:
1) deploy manila on queens
2) upgrade to rocky
3) perform a ssl cert update
4) run dpkg --list | grep pymysql in the manila unit
5) upgrade further to ussuri, and then to focal
6) update ssl certs again, therefore hitting hook error

Rodrigo Barbieri (rodrigo-barbieri2010)
Changed in charm-manila:
assignee: nobody → Rodrigo Barbieri (rodrigo-barbieri2010)
Revision history for this message
Rodrigo Barbieri (rodrigo-barbieri2010) wrote (last edit ):
Download full text (6.4 KiB)

After a significant amount of investigation I've found out several things about this bug:

1) the unitdata.set() that happens at [1] is only actually written to the file at the end of successful hook/action execution.

2) In my deployment, running the action openstack-upgrade with --wait shows that the action actually fails, despite having upgraded the packages successfully. It fails at [2] and does not even get to perform a db migration sync.

3) Diving deeper into [2], at [3] it gets a list of relation interfaces to process and render config files based on. When running 3 manila units, the cluster interface is present with class relations.openstack-ha.peers.OpenstackHAPeers. When running only 1 manila unit, the cluster interface is not present, and the upgrade does not fail (for me, in my deployment)

4) Diving deeper at [3], at [4] it processes the interfaces, notice an interesting "except TypeError" there, more on this later. The constructor invoked through the variable class instantiation eventually reaches [5], where it iterates through the interfaces and at [6] it hits the problem where it tries to set the attribute to the relation adapters class. The attribute being 'cluster', and the value being the class OpenstackHAPeers.

When it fails, there are absolutely no errors in the logs. The action run with --wait finishes with the following fields:

message: can't set attribute
status: failed

Those are easily overlooked due to the other stdout printed, such as packages installed during the upgrade. Fortunately this is an action that can be repeated over and over until successful.

That message "can't set attribute" is actually an AttributeError (not a TypeError). By adding an extra try/except block I can capture it and confirm it. No traceback information though (if I did things correctly). Also, adding the AttributeError to the outer try/except definition does not solve the problem because it is just invoked again and fails the same way.

So I added extra logging such as:

hookenv.log("TEST LOG: {} {} {} {} {}".format(relation,adapter_name,adapter,self,self.__dict__))

just above [6] and it printed the following:

TEST DATA: <relations.openstack-ha.peers.OpenstackHAPeers object at 0x7fea21c85cf8> cluster <charms_openstack.adapters.PeerHARelationAdapter object at 0x7fea21c9c908> <charm.openstack.manila.ManilaRelationAdapters object at 0x7fea21c85780> {'_charm_instance_weakref': <weakref at 0x7fea21c7a3b8; to 'ManilaCharmRocky' at 0x7fea21c85ba8>, '_relations': {'options', 'amqp'}, 'options': <charms_openstack.adapters.DefaultConfigurationAdapter object at 0x7fea21c9c3c8>, '_adapters': {'amqp': <class 'charm.openstack.manila.TransportURLAdapter'>, 'shared_db': <class 'charms_openstack.adapters.DatabaseRelationAdapter'>, 'cluster': <class 'charms_openstack.adapters.PeerHARelationAdapter'>, 'coordinator_memcached': <class 'charms_openstack.adapters.MemcacheRelationAdapter'>}, 'amqp': <charm.openstack.manila.TransportURLAdapter object at 0x7fea21c9cb00>}

I was unsure whether this was correct or not, so I compared to the placement charm which does not fail. It prints the following:

TEST DATA: <relations.openstack-ha.peers.OpenstackHAPeers o...

Read more...

Rodrigo Barbieri (rodrigo-barbieri2010)
tags: added: sts
Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

So the full traceback for the error is:

unit-manila-0: 18:15:11 ERROR unit.manila/0.juju-log Error: 'ManilaRelationAdapters' object has no attribute '_OpenStackAPIRelationAdapters__resolved_cluster'
unit-manila-0: 18:15:11 ERROR unit.manila/0.juju-log Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-manila-0/charm/actions/openstack-upgrade", line 55, in main
    action(args)
  File "/var/lib/juju/agents/unit-manila-0/charm/actions/openstack-upgrade", line 36, in openstack_upgrade_action
    charm_instance.run_upgrade()
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/charms_openstack/charm/core.py", line 1145, in run_upgrade
    target_charm.do_openstack_upgrade_config_render(interfaces_list)
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/charms_openstack/charm/core.py", line 1227, in do_openstack_upgrade_config_render
    self.render_all_configs()
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/charms_openstack/charm/core.py", line 910, in render_all_configs
    adapters_instance=adapters_instance)
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/charms_openstack/charm/core.py", line 988, in render_configs
    _render(os.path.basename(conf))
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/charms_openstack/charm/core.py", line 985, in _render
    perms=self.permission_override_map.get(conf) or 0o640,
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/charmhelpers/core/templating.py", line 85, in render
    content = template.render(context)
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/jinja2/asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/jinja2/environment.py", line 1003, in render
    vars = dict(*args, **kwargs)
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/charms_openstack/adapters.py", line 1271, in __iter__
    yield relation, getattr(self, relation)
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/charms_openstack/adapters.py", line 1343, in <lambda>
    property(lambda x: x.__cluster()))
  File "/var/lib/juju/agents/unit-manila-0/.venv/lib/python3.6/site-packages/charms_openstack/adapters.py", line 1347, in __cluster
    if not self.__resolved_cluster:
AttributeError: 'ManilaRelationAdapters' object has no attribute '_OpenStackAPIRelationAdapters__resolved_cluster'

This is kind of awkward to fix as it's a dunder method which ManilaRelationAdapters doesn't have. I suspect they'll have to be changed to single under methods so that they can be inherited. This has been a bug for a long time.

Changed in charm-manila:
status: New → Triaged
importance: Undecided → High
Alex Kavanagh (ajkavanagh)
Changed in charms.openstack:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

Added charm-aodh, charm-gnocchi and charm-designate as they all subclass OpenStackAPIRelationAdapters and therefore are susceptible to this bug:

$ ag OpenStackAPIRelationAdapter
aodh/src/lib/charm/openstack/aodh.py
41:class AodhAdapters(charms_openstack.adapters.OpenStackAPIRelationAdapters):

manila/src/lib/charm/openstack/manila.py
155: charms_openstack.adapters.OpenStackAPIRelationAdapters):

designate/src/lib/charm/openstack/designate.py
288:class DesignateAdapters(openstack_adapters.OpenStackAPIRelationAdapters):

gnocchi/src/lib/charm/openstack/gnocchi.py
102:class GnocchiCharmRelationAdapters(adapters.OpenStackAPIRelationAdapters):

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charms.openstack/+/851765

Changed in charms.openstack:
status: Triaged → In Progress
Changed in charm-manila:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-manila/+/851766

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (master)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/851765
Committed: https://opendev.org/openstack/charms.openstack/commit/c924762a9c92bd97dcb61d1d9e16f41c961ef9db
Submitter: "Zuul (22348)"
Branch: master

commit c924762a9c92bd97dcb61d1d9e16f41c961ef9db
Author: Alex Kavanagh <email address hidden>
Date: Mon Aug 1 19:05:23 2022 +0100

    Ensure that the _resolved_cluster member is set

    In the OpenStackAPIRelationAdapters class, the _resolved_cluster member
    is used to determine the cluster relation had been resolved. However,
    it's possible that it is accessed prior to be used as it was originally
    an dunderscored method (__method). This patch makes it more robust by
    switching to a single-underscore (which is inherited and not class-
    mangled) and that it is always set to None initially in the __init__
    method.

    Change-Id: I9b119ba6848923c27844a2f758ae9e3c34c7722d
    Closes-Bug: #1981736

Changed in charms.openstack:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charms.openstack/+/851723

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charms.openstack/+/851724

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charms.openstack/+/851725

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charms.openstack/+/851726

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charms.openstack/+/851727

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/charms.openstack/+/851728

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/851723
Committed: https://opendev.org/openstack/charms.openstack/commit/ae6018c09aaf44cdcde66de7aa038635b9b248e1
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit ae6018c09aaf44cdcde66de7aa038635b9b248e1
Author: Alex Kavanagh <email address hidden>
Date: Mon Aug 1 19:05:23 2022 +0100

    Ensure that the _resolved_cluster member is set

    In the OpenStackAPIRelationAdapters class, the _resolved_cluster member
    is used to determine the cluster relation had been resolved. However,
    it's possible that it is accessed prior to be used as it was originally
    an dunderscored method (__method). This patch makes it more robust by
    switching to a single-underscore (which is inherited and not class-
    mangled) and that it is always set to None initially in the __init__
    method.

    Change-Id: I9b119ba6848923c27844a2f758ae9e3c34c7722d
    Closes-Bug: #1981736
    (cherry picked from commit c924762a9c92bd97dcb61d1d9e16f41c961ef9db)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/851724
Committed: https://opendev.org/openstack/charms.openstack/commit/e88f8efb084ca3e936cfdba40df0451bf53a64a6
Submitter: "Zuul (22348)"
Branch: stable/xena

commit e88f8efb084ca3e936cfdba40df0451bf53a64a6
Author: Alex Kavanagh <email address hidden>
Date: Mon Aug 1 19:05:23 2022 +0100

    Ensure that the _resolved_cluster member is set

    In the OpenStackAPIRelationAdapters class, the _resolved_cluster member
    is used to determine the cluster relation had been resolved. However,
    it's possible that it is accessed prior to be used as it was originally
    an dunderscored method (__method). This patch makes it more robust by
    switching to a single-underscore (which is inherited and not class-
    mangled) and that it is always set to None initially in the __init__
    method.

    Change-Id: I9b119ba6848923c27844a2f758ae9e3c34c7722d
    Closes-Bug: #1981736
    (cherry picked from commit c924762a9c92bd97dcb61d1d9e16f41c961ef9db)

tags: added: in-stable-xena
tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/851725
Committed: https://opendev.org/openstack/charms.openstack/commit/35a914fdc4d7efab23b8fbefea2fb58642e66afd
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 35a914fdc4d7efab23b8fbefea2fb58642e66afd
Author: Alex Kavanagh <email address hidden>
Date: Mon Aug 1 19:05:23 2022 +0100

    Ensure that the _resolved_cluster member is set

    In the OpenStackAPIRelationAdapters class, the _resolved_cluster member
    is used to determine the cluster relation had been resolved. However,
    it's possible that it is accessed prior to be used as it was originally
    an dunderscored method (__method). This patch makes it more robust by
    switching to a single-underscore (which is inherited and not class-
    mangled) and that it is always set to None initially in the __init__
    method.

    Change-Id: I9b119ba6848923c27844a2f758ae9e3c34c7722d
    Closes-Bug: #1981736
    (cherry picked from commit c924762a9c92bd97dcb61d1d9e16f41c961ef9db)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/851726
Committed: https://opendev.org/openstack/charms.openstack/commit/93460fb6fcef56e83428cfb04f033ec63e52990c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 93460fb6fcef56e83428cfb04f033ec63e52990c
Author: Alex Kavanagh <email address hidden>
Date: Mon Aug 1 19:05:23 2022 +0100

    Ensure that the _resolved_cluster member is set

    In the OpenStackAPIRelationAdapters class, the _resolved_cluster member
    is used to determine the cluster relation had been resolved. However,
    it's possible that it is accessed prior to be used as it was originally
    an dunderscored method (__method). This patch makes it more robust by
    switching to a single-underscore (which is inherited and not class-
    mangled) and that it is always set to None initially in the __init__
    method.

    Change-Id: I9b119ba6848923c27844a2f758ae9e3c34c7722d
    Closes-Bug: #1981736
    (cherry picked from commit c924762a9c92bd97dcb61d1d9e16f41c961ef9db)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/851727
Committed: https://opendev.org/openstack/charms.openstack/commit/0f2a9c2d2385fbc3cc68856172230572b180b8de
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 0f2a9c2d2385fbc3cc68856172230572b180b8de
Author: Alex Kavanagh <email address hidden>
Date: Mon Aug 1 19:05:23 2022 +0100

    Ensure that the _resolved_cluster member is set

    In the OpenStackAPIRelationAdapters class, the _resolved_cluster member
    is used to determine the cluster relation had been resolved. However,
    it's possible that it is accessed prior to be used as it was originally
    an dunderscored method (__method). This patch makes it more robust by
    switching to a single-underscore (which is inherited and not class-
    mangled) and that it is always set to None initially in the __init__
    method.

    Change-Id: I9b119ba6848923c27844a2f758ae9e3c34c7722d
    Closes-Bug: #1981736
    (cherry picked from commit c924762a9c92bd97dcb61d1d9e16f41c961ef9db)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/train)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/851728
Committed: https://opendev.org/openstack/charms.openstack/commit/40b616ef1cac12967f40303118c839acf163b380
Submitter: "Zuul (22348)"
Branch: stable/train

commit 40b616ef1cac12967f40303118c839acf163b380
Author: Alex Kavanagh <email address hidden>
Date: Mon Aug 1 19:05:23 2022 +0100

    Ensure that the _resolved_cluster member is set

    In the OpenStackAPIRelationAdapters class, the _resolved_cluster member
    is used to determine the cluster relation had been resolved. However,
    it's possible that it is accessed prior to be used as it was originally
    an dunderscored method (__method). This patch makes it more robust by
    switching to a single-underscore (which is inherited and not class-
    mangled) and that it is always set to None initially in the __init__
    method.

    Change-Id: I9b119ba6848923c27844a2f758ae9e3c34c7722d
    Closes-Bug: #1981736
    (cherry picked from commit c924762a9c92bd97dcb61d1d9e16f41c961ef9db)

Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

Unfortunately, the fix in charms.openstack is not helping according to reports. Please could you add model/bundle, and history fo model (e.g. any other upgrades, first install, charm upgrades, etc.)

Changed in charm-manila:
status: In Progress → Incomplete
Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

Re-opened the charms.openstack bug as it wasn't resolved. The issue turns out to be that by adding a property to the class, it affects that class going forwards, not just for the instance. Thus, the coming fix is to not use a lazy property, but just set the cluster attribute in the __init__ and allow it to be overwritten as required.

Changed in charms.openstack:
status: Fix Released → In Progress
assignee: nobody → Alex Kavanagh (ajkavanagh)
Changed in charm-manila:
assignee: Rodrigo Barbieri (rodrigo-barbieri2010) → Alex Kavanagh (ajkavanagh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charms.openstack/+/852158

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (master)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/852158
Committed: https://opendev.org/openstack/charms.openstack/commit/581300632b426e985bf3daaed426daf3c89f825a
Submitter: "Zuul (22348)"
Branch: master

commit 581300632b426e985bf3daaed426daf3c89f825a
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 4 11:57:02 2022 +0100

    Further fix to OpenStackAPIRelationAdapters

    The existing method of using a property to lazily load the cluster
    relation adapter permanently changes the class to include that as
    a cluster property. This means that a future (in the same hook
    execution) instantiation of the class would include that property,
    which means that 'real' cluster adapter could not be used. Sadly,
    this was happening with the manila charm, and possibly others.

    This patch changes it from a lazily loaded property, to a simple
    attribute.

    Change-Id: I704f362e0dd845ff00d0f0470b0235a4dead5f9f
    Closes-Bug: #1981736

Changed in charms.openstack:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charms.openstack/+/852411

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charms.openstack/+/852412

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charms.openstack/+/852413

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charms.openstack/+/852414

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charms.openstack/+/852415

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charms.openstack (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/charms.openstack/+/852416

Alex Kavanagh (ajkavanagh)
Changed in charms.openstack:
status: Fix Released → In Progress
Changed in charm-manila:
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/852411
Committed: https://opendev.org/openstack/charms.openstack/commit/f752938f95eb2f3be7cfefd8d7888d133aee39d0
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit f752938f95eb2f3be7cfefd8d7888d133aee39d0
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 4 11:57:02 2022 +0100

    Further fix to OpenStackAPIRelationAdapters

    The existing method of using a property to lazily load the cluster
    relation adapter permanently changes the class to include that as
    a cluster property. This means that a future (in the same hook
    execution) instantiation of the class would include that property,
    which means that 'real' cluster adapter could not be used. Sadly,
    this was happening with the manila charm, and possibly others.

    This patch changes it from a lazily loaded property, to a simple
    attribute.

    Change-Id: I704f362e0dd845ff00d0f0470b0235a4dead5f9f
    Closes-Bug: #1981736
    (cherry picked from commit 581300632b426e985bf3daaed426daf3c89f825a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/852412
Committed: https://opendev.org/openstack/charms.openstack/commit/2bf00963cf5368cbfd48f28e44ec25af57448f81
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 2bf00963cf5368cbfd48f28e44ec25af57448f81
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 4 11:57:02 2022 +0100

    Further fix to OpenStackAPIRelationAdapters

    The existing method of using a property to lazily load the cluster
    relation adapter permanently changes the class to include that as
    a cluster property. This means that a future (in the same hook
    execution) instantiation of the class would include that property,
    which means that 'real' cluster adapter could not be used. Sadly,
    this was happening with the manila charm, and possibly others.

    This patch changes it from a lazily loaded property, to a simple
    attribute.

    Change-Id: I704f362e0dd845ff00d0f0470b0235a4dead5f9f
    Closes-Bug: #1981736
    (cherry picked from commit 581300632b426e985bf3daaed426daf3c89f825a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/852413
Committed: https://opendev.org/openstack/charms.openstack/commit/8ec1be5f8d3f59290f5c7edb65a4eee6f377c9eb
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 8ec1be5f8d3f59290f5c7edb65a4eee6f377c9eb
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 4 11:57:02 2022 +0100

    Further fix to OpenStackAPIRelationAdapters

    The existing method of using a property to lazily load the cluster
    relation adapter permanently changes the class to include that as
    a cluster property. This means that a future (in the same hook
    execution) instantiation of the class would include that property,
    which means that 'real' cluster adapter could not be used. Sadly,
    this was happening with the manila charm, and possibly others.

    This patch changes it from a lazily loaded property, to a simple
    attribute.

    Change-Id: I704f362e0dd845ff00d0f0470b0235a4dead5f9f
    Closes-Bug: #1981736
    (cherry picked from commit 581300632b426e985bf3daaed426daf3c89f825a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/852414
Committed: https://opendev.org/openstack/charms.openstack/commit/76cc946e7a33795924c288db35c9d12d194bd28e
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 76cc946e7a33795924c288db35c9d12d194bd28e
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 4 11:57:02 2022 +0100

    Further fix to OpenStackAPIRelationAdapters

    The existing method of using a property to lazily load the cluster
    relation adapter permanently changes the class to include that as
    a cluster property. This means that a future (in the same hook
    execution) instantiation of the class would include that property,
    which means that 'real' cluster adapter could not be used. Sadly,
    this was happening with the manila charm, and possibly others.

    This patch changes it from a lazily loaded property, to a simple
    attribute.

    Change-Id: I704f362e0dd845ff00d0f0470b0235a4dead5f9f
    Closes-Bug: #1981736
    (cherry picked from commit 581300632b426e985bf3daaed426daf3c89f825a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/852415
Committed: https://opendev.org/openstack/charms.openstack/commit/b4a7ae2bb56feca711eaf46a53debe5f08e89181
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit b4a7ae2bb56feca711eaf46a53debe5f08e89181
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 4 11:57:02 2022 +0100

    Further fix to OpenStackAPIRelationAdapters

    The existing method of using a property to lazily load the cluster
    relation adapter permanently changes the class to include that as
    a cluster property. This means that a future (in the same hook
    execution) instantiation of the class would include that property,
    which means that 'real' cluster adapter could not be used. Sadly,
    this was happening with the manila charm, and possibly others.

    This patch changes it from a lazily loaded property, to a simple
    attribute.

    Change-Id: I704f362e0dd845ff00d0f0470b0235a4dead5f9f
    Closes-Bug: #1981736
    (cherry picked from commit 581300632b426e985bf3daaed426daf3c89f825a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.openstack (stable/train)

Reviewed: https://review.opendev.org/c/openstack/charms.openstack/+/852416
Committed: https://opendev.org/openstack/charms.openstack/commit/09284ed9535edbe470a6152b26e4f9335ad8bbb5
Submitter: "Zuul (22348)"
Branch: stable/train

commit 09284ed9535edbe470a6152b26e4f9335ad8bbb5
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 4 11:57:02 2022 +0100

    Further fix to OpenStackAPIRelationAdapters

    The existing method of using a property to lazily load the cluster
    relation adapter permanently changes the class to include that as
    a cluster property. This means that a future (in the same hook
    execution) instantiation of the class would include that property,
    which means that 'real' cluster adapter could not be used. Sadly,
    this was happening with the manila charm, and possibly others.

    This patch changes it from a lazily loaded property, to a simple
    attribute.

    Change-Id: I704f362e0dd845ff00d0f0470b0235a4dead5f9f
    Closes-Bug: #1981736
    (cherry picked from commit 581300632b426e985bf3daaed426daf3c89f825a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-manila/+/852875

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-manila/+/852902

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/21.10)

Fix proposed to branch: stable/21.10
Review: https://review.opendev.org/c/openstack/charm-manila/+/852904

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-manila (stable/21.10)

Change abandoned by "Alex Kavanagh <email address hidden>" on branch: stable/21.10
Review: https://review.opendev.org/c/openstack/charm-manila/+/852904
Reason: Raised on wrong branch as needs to be stacked onto unmerged charmhub migration.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-manila/+/852906

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-manila/+/852907

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-manila/+/852917

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-manila (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/charm-manila/+/852918

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-gnocchi (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-gnocchi/+/853471

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-gnocchi (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-gnocchi/+/853472

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-gnocchi (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-gnocchi/+/853485

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-gnocchi (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-gnocchi/+/853486

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-gnocchi (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/charm-gnocchi/+/853487

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-designate/+/853488

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-designate/+/853490

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-designate/+/853491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-designate (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/charm-designate/+/853492

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-aodh (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-aodh/+/853493

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-aodh (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-aodh/+/853494

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-aodh (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-aodh/+/853495

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-aodh (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-aodh/+/853496

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-aodh (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/charm-aodh/+/853497

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (stable/train)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/853492
Committed: https://opendev.org/openstack/charm-designate/commit/234955065622e58af4fbef1a9be6cef58d4ba079
Submitter: "Zuul (22348)"
Branch: stable/train

commit 234955065622e58af4fbef1a9be6cef58d4ba079
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 14:43:53 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: Icf4c4b6cddc5aa0851cd25f53479b0255f1f4805
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/853488
Committed: https://opendev.org/openstack/charm-designate/commit/99c0f9537fdd4f78753d4096802e90bdec953b0e
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 99c0f9537fdd4f78753d4096802e90bdec953b0e
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 14:43:53 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: Icf4c4b6cddc5aa0851cd25f53479b0255f1f4805
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/853491
Committed: https://opendev.org/openstack/charm-designate/commit/7ecc3301c2c4c0c9e548dec6f25d61c0c66eff8e
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 7ecc3301c2c4c0c9e548dec6f25d61c0c66eff8e
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 14:43:53 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: Icf4c4b6cddc5aa0851cd25f53479b0255f1f4805
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/charm-designate/+/853490
Committed: https://opendev.org/openstack/charm-designate/commit/1fffc9d3d52cd63104f48dba52f0145dad216e96
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 1fffc9d3d52cd63104f48dba52f0145dad216e96
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 14:43:53 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: Icf4c4b6cddc5aa0851cd25f53479b0255f1f4805
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-gnocchi (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/charm-gnocchi/+/853486
Committed: https://opendev.org/openstack/charm-gnocchi/commit/eb01788ff7f12ca0eb734be985e2511007a3b969
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit eb01788ff7f12ca0eb734be985e2511007a3b969
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 12:59:19 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I2dad153b11cc78d2d54bae4b69b1cd0b08972d1f
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-aodh (stable/train)

Reviewed: https://review.opendev.org/c/openstack/charm-aodh/+/853497
Committed: https://opendev.org/openstack/charm-aodh/commit/3db6220bd7feeb2535958d633a27f826d46c7ffb
Submitter: "Zuul (22348)"
Branch: stable/train

commit 3db6220bd7feeb2535958d633a27f826d46c7ffb
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 14:51:00 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I67a1ffea84b767d283d29598945bfbad9ba999bf
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-aodh (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/charm-aodh/+/853496
Committed: https://opendev.org/openstack/charm-aodh/commit/c80739d26fcb8cc0c472320ea62d3e300a9edcdc
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit c80739d26fcb8cc0c472320ea62d3e300a9edcdc
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 14:51:00 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I67a1ffea84b767d283d29598945bfbad9ba999bf
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-aodh (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/charm-aodh/+/853495
Committed: https://opendev.org/openstack/charm-aodh/commit/72d72d212f42e113bcfb9dbde15c68d412fe8e59
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 72d72d212f42e113bcfb9dbde15c68d412fe8e59
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 14:51:00 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I67a1ffea84b767d283d29598945bfbad9ba999bf
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-aodh (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/charm-aodh/+/853494
Committed: https://opendev.org/openstack/charm-aodh/commit/ffd59817f6e40d2c8205f248165e85ffdd83357a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ffd59817f6e40d2c8205f248165e85ffdd83357a
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 14:51:00 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I67a1ffea84b767d283d29598945bfbad9ba999bf
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-gnocchi (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/charm-gnocchi/+/853485
Committed: https://opendev.org/openstack/charm-gnocchi/commit/2ba671831aff965c7df27728e653516a7ea74dfe
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 2ba671831aff965c7df27728e653516a7ea74dfe
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 12:59:19 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I2dad153b11cc78d2d54bae4b69b1cd0b08972d1f
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-gnocchi (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/charm-gnocchi/+/853472
Committed: https://opendev.org/openstack/charm-gnocchi/commit/20f17498fe9242e884cbf32c190052371010ec63
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 20f17498fe9242e884cbf32c190052371010ec63
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 12:59:19 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I2dad153b11cc78d2d54bae4b69b1cd0b08972d1f
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-gnocchi (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charm-gnocchi/+/853471
Committed: https://opendev.org/openstack/charm-gnocchi/commit/b7edbf3f364f941f8ec378eff7521d758a1a04be
Submitter: "Zuul (22348)"
Branch: stable/xena

commit b7edbf3f364f941f8ec378eff7521d758a1a04be
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 12:59:19 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I2dad153b11cc78d2d54bae4b69b1cd0b08972d1f
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-aodh (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charm-aodh/+/853493
Committed: https://opendev.org/openstack/charm-aodh/commit/2ce95a35837d47d62d39ee94fdba6f308d33af0b
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 2ce95a35837d47d62d39ee94fdba6f308d33af0b
Author: Alex Kavanagh <email address hidden>
Date: Wed Aug 17 14:51:00 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I67a1ffea84b767d283d29598945bfbad9ba999bf
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-manila (stable/wallaby)

Change abandoned by "Alex Kavanagh <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-manila/+/852906
Reason: Abandoning as the associated stacked on review has merged and it picked up the charms.openstack patch for the bug.

Alex Kavanagh (ajkavanagh)
Changed in charm-designate:
status: New → In Progress
Changed in charm-aodh:
status: New → In Progress
Changed in charm-gnocchi:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-manila (master)

Change abandoned by "Alex Kavanagh <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-manila/+/851766
Reason: This is overtaken by events. The charm has been rebuild on master and new releases made since the review was uploaded.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-manila (stable/ussuri)

Change abandoned by "Alex Kavanagh <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-manila/+/852917
Reason: This is no longer needed as a patch has been merged to the stable/ussuri branch since this was uploaded which means the bug fix has been incorporated.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-gnocchi (stable/train)

Change abandoned by "Alex Kavanagh <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/charm-gnocchi/+/853487
Reason: This review is no longer needed as a commit has been landed to this branch since and this means the the bug fix has been included.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/charm-manila/+/852875
Committed: https://opendev.org/openstack/charm-manila/commit/4f746a35690c73e9656d093c283411e007fdbdb6
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 4f746a35690c73e9656d093c283411e007fdbdb6
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 11 15:38:32 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I1a3ae8cef13659fc6ade3883346c591e176eff3a
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/charm-manila/+/852902
Committed: https://opendev.org/openstack/charm-manila/commit/889d74a9e426a61f2ca180531dd87608cdc5bced
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 889d74a9e426a61f2ca180531dd87608cdc5bced
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 11 15:38:32 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I1a3ae8cef13659fc6ade3883346c591e176eff3a
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/charm-manila/+/852907
Committed: https://opendev.org/openstack/charm-manila/commit/ea2095f4eae60ae1f8967eb3b86d4fc0d739eee3
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit ea2095f4eae60ae1f8967eb3b86d4fc0d739eee3
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 11 15:38:32 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I1a3ae8cef13659fc6ade3883346c591e176eff3a
    Closes-Bug: #1981736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-manila (stable/train)

Reviewed: https://review.opendev.org/c/openstack/charm-manila/+/852918
Committed: https://opendev.org/openstack/charm-manila/commit/6a86e599429d3369a484d9839935f3ee704b027b
Submitter: "Zuul (22348)"
Branch: stable/train

commit 6a86e599429d3369a484d9839935f3ee704b027b
Author: Alex Kavanagh <email address hidden>
Date: Thu Aug 11 15:38:32 2022 +0100

    Rebuild charm to pick up fix upgrade-bug 1981736

    This is a rebuild trigger to bring in the latest stable
    charms.openstack (for the branch) that contains the fix for the
    linked bug that caused the charm to fail (almost silently) during
    and action managed upgrade.

    Change-Id: I1a3ae8cef13659fc6ade3883346c591e176eff3a
    Closes-Bug: #1981736

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.