config "override" silently accept incomplete override options
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
logrotate-charm |
Fix Released
|
Undecided
|
Chi Wai CHAN |
Bug Description
The config option "override" will silently accept incomplete "override" options.
In charm-logrotated rev 10, the "override" option accept a JSON formatted string to override the logrotate directives for each file in "/etc/logrotate
'[ {"path": "/etc/logrotate
. In this example, this will override directives "rotate" and "interval" "for /etc/logrotate.
'[ {"path": "/etc/logrotate
It will not override directive "interval" for "/etc/logrotate
Reference line that causes the issue: https:/
Related branches
- Robert Gildein: Approve
- 🤖 prod-jenkaas-bootstack: Approve (continuous-integration)
- Erhan Sunar (community): Approve
- JamesLin: Approve
-
Diff: 132 lines (+70/-8)2 files modifiedsrc/lib/lib_logrotate.py (+18/-8)
src/tests/unit/test_logrotate.py (+52/-0)
tags: | added: bseng-1143 |
Changed in charm-logrotated: | |
assignee: | nobody → Chi Wai CHAN (raychan96) |
Changed in charm-logrotated: | |
status: | New → Fix Committed |
Changed in charm-logrotated: | |
milestone: | none → 23.07 |
Changed in charm-logrotated: | |
status: | Fix Committed → Fix Released |