Excessive calls to set_zookeeper_active()

This is the current code in reactive/zookeeper.py:

@when('zookeeper-k8s.configured')
def set_zookeeper_active():
    """Set zookeeper status active

    Conditions:
        - zookeeper-k8s.configured
    """
    layer.status.active('configured')

The problem is that the 'zookeeper-k8s.configured' flag is always set, so every hook execution re-executes the call to layer.status.active('configured').

This has unintended side-effects, such as overwriting the state when other actions are occurring, such as sending config during relation handling.

I would suggest the following changes:

Set the 'zookeeper-k8s.active' flag once here. This will ensure set_zookeeper_active() isn't executed on every hook execution when the configured flag is set.

@when('zookeeper-k8s.configured')
@when_not('zookeeper-k8s.active')
def set_zookeeper_active():
    """Set zookeeper status active

    Conditions:
        - zookeeper-k8s.configured
    """
    layer.status.active('configured')
    set_flag('zookeeper-k8s.active')

Second, instead of checking if the configured flag is set for send_config(), check the active flag. When the relation is joined, call set_zookeeper_active explicitly to reset the status.

@when('zookeeper-k8s.active', 'zookeeper.joined')
def send_config():
    [..]
        clear_flag('zookeeper.joined')
        set_zookeeper_active()

This will make sure that a) we're resetting the state after it's been put into maintenance mode earlier in send_config().