charm-k8s-jenkins-agent

limited coverage of generate_pod_config

Bug #1888640 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
charm-k8s-jenkins-agent
Fix Released
Medium
Unassigned

Bug Description

There is only a single test in:
https://git.launchpad.net/charm-k8s-jenkins-agent/tree/tests/unit/test_charm.py

which only tests the 'generate_pod_config' code, and doesn't even cover the 'secure' case. (jenkins_api_token is a mandatory config item that will raise KeyError if you actually tried to set a pod spec without it)

It also doesn't test what would happen if you *did* set any of the other items (like jenkins_master_url).

John A Meinel (jameinel)
summary: - missing coverage of is_valid_config
+ limited coverage of generate_pod_config
Tom Haddon (mthaddon)
Changed in charm-k8s-jenkins-agent:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Tom Haddon (mthaddon) wrote :

We've since updated tests for this charm, and currently have 100% unit test coverage.

Changed in charm-k8s-jenkins-agent:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.