Code simplification suggestions
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
charm-iscsi-connector |
Won't Fix
|
Wishlist
|
Unassigned |
Bug Description
It may not be necessary to render_config upon charm install, as config-changed hook which also calls render_config is to follow immediately after an install hook. Suggest removing:
self.
Setting the initiator_name in _iscsi_initiator() could be simplified to:
if hostname not in initiator_dict:
Functional test bundles could be set up with base.yaml and symlinks from focal.yaml and bionic.yaml along with moving "series: <distro>" to overlay templates, and charm_name variable should be lower-cased in the overlay templates. i.e. a suggested overlay template focal.yaml.j2:
series: focal
applications:
{{ charm_name }}:
charm: {{ CHARM_BUILD_DIR }}/{{ charm_name }}.charm
Changed in charm-iscsi-connector: | |
importance: | Undecided → Wishlist |
status: | New → Confirmed |
This charm is no longer being actively maintained.