Charm Helpers

action_get does not catch ValueError

Bug #1489541 reported by Chris Holcombe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Charm Helpers
New
Undecided
Unassigned

Bug Description

This is a simple fix. action_get in hookenv.py does not catch ValueError if juju returns bad data. I don't know if it would be appropriate to return None or raise the error.

Revision history for this message
Adam Collard (adam-collard) wrote :

... this begs the question of why/when Juju is returning "bad data"

Revision history for this message
Chris Holcombe (xfactor973) wrote : Re: [Bug 1489541] Re: action_get does not catch ValueError

Well.. it's not returning any malformed json that I'm aware of but the
library assumes it will never do so.

On 08/28/2015 01:10 AM, Adam Collard wrote:
> ... this begs the question of why/when Juju is returning "bad data"
>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.