relation_set broken under Python3
Bug #1458546 reported by
Stuart Bishop
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Charm Helpers |
Fix Released
|
Critical
|
Stuart Bishop |
Bug Description
Due to Juju not reporting version information, relation_set needs to sniff to see if the --file argument is available to relation-set or not. Unfortunately, the code that does this is broken under Python 3.
accepts_file = "--file" in subprocess.
subprocess.
Related branches
lp://staging/~stub/charm-helpers/bug-1458546-fix-relation-set-py3
Rejected
for merging
into
lp://staging/charm-helpers
- Chris Glass: Pending requested
-
Diff: 26 lines (+3/-2)2 files modifiedcharmhelpers/core/hookenv.py (+1/-1)
tests/core/test_hookenv.py (+2/-1)
lp://staging/~free.ekanayaka/charm-helpers/relation-set-file
- Chris Glass (community): Approve
- Björn Tillenius (community): Approve
-
Diff: 155 lines (+91/-10)2 files modifiedcharmhelpers/core/hookenv.py (+27/-6)
tests/core/test_hookenv.py (+64/-4)
Changed in charm-helpers: | |
status: | New → In Progress |
assignee: | nobody → Stuart Bishop (stub) |
importance: | Undecided → Critical |
Changed in charm-helpers: | |
status: | In Progress → Fix Committed |
Changed in charm-helpers: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.