Make scheduler_default_filters configurable

Bug #1956727 reported by Giuseppe Petralia
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Charm Guide
Fix Released
Undecided
Samuel Walladge
OpenStack Cinder Charm
Fix Released
Medium
Samuel Walladge

Bug Description

Currently cinder charm doesn't not provide a way to configure default scheduler filters and they are always set to the default value:

#scheduler_default_filters = AvailabilityZoneFilter,CapacityFilter,CapabilitiesFilter

Ideally this should work similar to nova-cloud-controller charm option scheduler-default-filters

Revision history for this message
Felipe Reyes (freyes) wrote :

using `juju cinder config-flags` should work as a workaround (e.g. `juju cinder config-flags="scheduler_default_filters=MyFiter"` ), more details on the format(s) accepted at https://github.com/openstack/charm-cinder/blob/master/charmhelpers/contrib/openstack/utils.py#L1900

Changed in charm-cinder:
status: New → Triaged
importance: Undecided → Medium
tags: added: good-first-bug
Changed in charm-cinder:
assignee: nobody → Samuel Walladge (swalladge)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-cinder (master)
Revision history for this message
Aurelien Lourot (aurelien-lourot) wrote :

Added charm-guide as affected project so we add this new feature to the release notes.

Changed in charm-cinder:
status: In Progress → Fix Committed
milestone: none → 22.04
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-cinder (master)

Reviewed: https://review.opendev.org/c/openstack/charm-cinder/+/826194
Committed: https://opendev.org/openstack/charm-cinder/commit/7f97a6d30efa27f0738b10f411114e1f85919363
Submitter: "Zuul (22348)"
Branch: master

commit 7f97a6d30efa27f0738b10f411114e1f85919363
Author: Samuel Walladge <email address hidden>
Date: Tue Jan 25 09:39:30 2022 +1030

    Add support to configure scheduler_default_filters

    Add new config option: `scheduler-default-filters`.
    This is unset by default, so cinder retains the default value for
    scheduler_default_filters.

    Closes-Bug: #1956727
    Change-Id: I9777bf8fe5ddbb69689db60c2790e8a4be57e1ab

Changed in charm-guide:
assignee: nobody → Samuel Walladge (swalladge)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-guide (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-guide/+/826774

Changed in charm-guide:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-guide (master)

Reviewed: https://review.opendev.org/c/openstack/charm-guide/+/826774
Committed: https://opendev.org/openstack/charm-guide/commit/82f75159a2c0dc11d3f13f8e6a3106379c16d50b
Submitter: "Zuul (22348)"
Branch: master

commit 82f75159a2c0dc11d3f13f8e6a3106379c16d50b
Author: Samuel Walladge <email address hidden>
Date: Fri Jan 28 07:49:55 2022 +1030

    Add release notes for `scheduler-default-filters`

    This is a new option in the cinder charm.

    Related-Bug: #1956727
    Change-Id: Ifdfdab1ca7b09ae25195c68eadbce5082b2d0364

Changed in charm-guide:
status: In Progress → Fix Committed
milestone: none → 22.04
Changed in charm-cinder:
status: Fix Committed → Fix Released
Changed in charm-guide:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.