feature: enable admin socket and log file for librbd client

Bug #1786874 reported by dongdong tao
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Charm Helpers
Triaged
Wishlist
Unassigned
OpenStack Cinder Charm
Triaged
Wishlist
Unassigned
OpenStack Glance Charm
In Progress
Wishlist
dongdong tao
OpenStack Nova Compute Charm
Triaged
Wishlist
Unassigned

Bug Description

currently, we don't have admin socket and log file for librbd client.
it would be hard for us to debug if something wrong in librbd client.
we need to enable this on glance, nova-compute, cinder.

Revision history for this message
dongdong tao (taodd) wrote :

we can add below two lines to ceph.conf to enable this

log file = /var/log/ceph/$name.$pid.log
admin socket = /var/run/ceph/$name.$pid.asok

dongdong tao (taodd)
Changed in glance:
assignee: nobody → dongdong tao (taodd)
status: New → In Progress
affects: glance → charm-glance
Changed in charm-glance:
milestone: none → 18.08
importance: Undecided → Wishlist
Revision history for this message
Edward Hope-Morley (hopem) wrote :
Revision history for this message
Edward Hope-Morley (hopem) wrote :
James Page (james-page)
Changed in charm-glance:
milestone: 18.08 → 18.11
James Page (james-page)
Changed in charm-nova-compute:
status: New → Triaged
importance: Undecided → Wishlist
Changed in charm-cinder:
importance: Undecided → Wishlist
Changed in charm-helpers:
importance: Undecided → Wishlist
status: New → Triaged
Changed in charm-cinder:
status: New → Triaged
summary: - Need to enable admin socket and log file for librbd client
+ feature: enable admin socket and log file for librbd client
James Page (james-page)
Changed in charm-glance:
milestone: 18.11 → 19.04
David Ames (thedac)
Changed in charm-glance:
milestone: 19.04 → 19.07
David Ames (thedac)
Changed in charm-glance:
milestone: 19.07 → 19.10
David Ames (thedac)
Changed in charm-glance:
milestone: 19.10 → 20.01
James Page (james-page)
Changed in charm-glance:
milestone: 20.01 → 20.05
David Ames (thedac)
Changed in charm-glance:
milestone: 20.05 → 20.08
James Page (james-page)
Changed in charm-glance:
milestone: 20.08 → none
Revision history for this message
Trent Lloyd (lathiat) wrote :

For the logfile I proposed a new charm-helpers commit here to enable 'log to syslog' and 'err to stderr' (instead of 'log to file') in ceph.conf to solve the logging issue. Full description at the link.
https://github.com/juju/charm-helpers/pull/608

For the admin socket, it's more complicated, so I will do it separately. Currently /run/ceph is managed by systemd-tmpfiles /usr/lib/tmpfiles.d/ceph.conf and is creates as '0770' ceph:ceph which libvirt/qemu process cannot write to. I think probably this should switch to a world writable tmpdir like /var/log/ceph but am evaluating that change. We could potentially write to an alternative location but then the 'ceph' command wont find it automatically and we need to specify th epath manually. After making that change whatever it is there is also code in the various charms around /var/run/ceph and /run/ceph including charm code that does a chgrp to kvm (that doesn't survive a reboot) that needs cleaning up from old bugs like https://bugs.launchpad.net/charm-cinder-ceph/+bug/1779676. Also on focal /run/ceph exists in apparmor but on bionic it doesn't (see: bug #1779674) and also the charm versions of the apparmor profiles that override the packages versions might need a sync.

Revision history for this message
Trent Lloyd (lathiat) wrote :

Also once approved sync to the charms is needed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-nova-compute (master)

Change abandoned by "Billy Olsen <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-nova-compute/+/594082
Reason: Patch has not been updated to address feedback in > 180 days.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.