move apparmor profile related osd restarts to an action

Bug #1782725 reported by Edward Hope-Morley
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ceph OSD Charm
Confirmed
High
Dan Hill

Bug Description

Currently if you change the aa-profile-mode config option all OSDs will be restarted. Recently landed patch 9f5d342 "fixed" the charm so that changes to a profile definition will also trigger a restart of all OSDs. Restarting all OSDs in a Ceph cluster is a particularly risky action to take even under ideal conditions and it is for this reason that the charms will not do so for any other type of config change. So, while I understand that for security reasons if your profile is enabled or changes you want that change applied as quickly as possible, I think that we need to allow the operator to have greater control of this action. To that end, I propose that we move the restarting of OSDs to a charm action.

James Page (james-page)
Changed in charm-ceph-osd:
milestone: 18.08 → 18.11
Revision history for this message
Ryan Beisner (1chb1n) wrote :
David Ames (thedac)
Changed in charm-ceph-osd:
milestone: 18.11 → 19.04
David Ames (thedac)
Changed in charm-ceph-osd:
status: New → Confirmed
David Ames (thedac)
Changed in charm-ceph-osd:
milestone: 19.04 → 19.07
David Ames (thedac)
Changed in charm-ceph-osd:
milestone: 19.07 → 19.10
David Ames (thedac)
Changed in charm-ceph-osd:
milestone: 19.10 → 20.01
tags: added: cold-start
James Page (james-page)
Changed in charm-ceph-osd:
milestone: 20.01 → 20.05
David Ames (thedac)
Changed in charm-ceph-osd:
milestone: 20.05 → 20.08
Dan Hill (hillpd)
Changed in charm-ceph-osd:
assignee: nobody → Dan Hill (hillpd)
Revision history for this message
Trent Lloyd (lathiat) wrote :

I'm fairly sure these restarts are not needed at all. The only note I can find is that if a process was started before the apparmor kernel module was reloaded, you would need to restart it for apparmor to track it.

But once the module is loaded, new apparmor profiles will be applied at runtime and dont require an OSD restart. So I think this restart code can just be removed.

James Page (james-page)
Changed in charm-ceph-osd:
milestone: 20.08 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.