Ceph OSD Charm

multiple ceph charm actions broken by broken imports

Bug #1726275 reported by Frode Nordahl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceph Monitor Charm
Fix Released
High
Edward Hope-Morley
Ceph Monitor Charm 17.11
Ceph OSD Charm
Fix Released
High
Frode Nordahl
Ceph OSD Charm 17.08
OpenStack Ceph Charm (Retired)
Fix Released
High
Edward Hope-Morley
OpenStack Ceph Charm (Retired) 17.11
OpenStack Ceph-Proxy Charm
Invalid
High
Unassigned
OpenStack Ceph-Proxy Charm 17.11

Bug Description

2017-10-23 06:45:25 DEBUG add-disk Traceback (most recent call last):
2017-10-23 06:45:25 DEBUG add-disk File "/var/lib/juju/agents/unit-ceph-osd-0/charm/actions/add-disk", line 77, in <module>
2017-10-23 06:45:25 DEBUG add-disk bucket=action_get("bucket"))
2017-10-23 06:45:25 DEBUG add-disk File "/var/lib/juju/agents/unit-ceph-osd-0/charm/actions/add-disk", line 42, in add_device
2017-10-23 06:45:25 DEBUG add-disk ceph.osdize(dev, config('osd-format'),
2017-10-23 06:45:25 DEBUG add-disk AttributeError: 'module' object has no attribute 'osdize'

2017-10-23 06:48:50 DEBUG list-disks Traceback (most recent call last):
2017-10-23 06:48:50 DEBUG list-disks File "/var/lib/juju/agents/unit-ceph-osd-0/charm/actions/list-disks", line 31, in <module>
2017-10-23 06:48:50 DEBUG list-disks from ceph import unmounted_disks
2017-10-23 06:48:50 DEBUG list-disks ImportError: cannot import name unmounted_disks

Revision history for this message
Frode Nordahl (fnordahl) wrote :

Review: https://review.openstack.org/#/c/514166/

Changed in charm-ceph-osd:
assignee: nobody → Frode Nordahl (fnordahl)
status: New → In Progress
importance: Undecided → High
tags: added: backport-potential sts
Revision history for this message
Edward Hope-Morley (hopem) wrote :

This also affects the ceph and ceph-mon charms since the same code was synced into those but the actions were not updated accordingly. I will make the title of this LP more generic since it affects different actions in different charms and target the other charms accordingly.

Changed in charm-ceph-osd:
milestone: none → 17.11
Changed in charm-ceph-mon:
milestone: none → 17.11
Changed in charm-ceph:
milestone: none → 17.11
Edward Hope-Morley (hopem)
Changed in charm-ceph-proxy:
milestone: none → 17.11
importance: Undecided → High
Changed in charm-ceph:
importance: Undecided → High
Changed in charm-ceph-mon:
importance: Undecided → High
summary: - add-disk, list-disk and replace-osd actions not working, causing
- Traceback
+ multiple ceph charm actions broken by broken imports
Edward Hope-Morley (hopem)
Changed in charm-ceph-mon:
assignee: nobody → Edward Hope-Morley (hopem)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph-mon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/514606

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph (master)

Fix proposed to branch: master
Review: https://review.openstack.org/514607

Edward Hope-Morley (hopem)
Changed in charm-ceph:
assignee: nobody → Edward Hope-Morley (hopem)
status: New → In Progress
Changed in charm-ceph-mon:
status: New → In Progress
Changed in charm-ceph-proxy:
status: New → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-osd (master)

Reviewed: https://review.openstack.org/514166
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=52306f841910825ed632307415f31155f0b0c4a6
Submitter: Zuul
Branch: master

commit 52306f841910825ed632307415f31155f0b0c4a6
Author: Frode Nordahl <email address hidden>
Date: Mon Oct 23 09:20:54 2017 +0200

    Fix imports for actions

    Commit 4bcdddc4a36e5ac7ddfd97d491183995f6ca2221 code cleanup did
    not address actions.

    Fixed.

    Change-Id: Ic5de38e4d56022e3f72e5dcb08f6a4253e3306ee
    Closes-bug: #1726275

Changed in charm-ceph-osd:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph-osd (stable/17.08)

Fix proposed to branch: stable/17.08
Review: https://review.openstack.org/514709

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph-osd (master)

Fix proposed to branch: master
Review: https://review.openstack.org/515074

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-ceph-osd (stable/17.08)

Change abandoned by Frode Nordahl (<email address hidden>) on branch: stable/17.08
Review: https://review.openstack.org/514709
Reason: New back-port based on https://review.openstack.org/515074 will follow

Frode Nordahl (fnordahl)
tags: added: stable-backport
removed: backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-ceph-osd (master)

Change abandoned by Frode Nordahl (<email address hidden>) on branch: master
Review: https://review.openstack.org/515074
Reason: Superseded by https://review.openstack.org/#/c/515056/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-osd (stable/17.08)

Reviewed: https://review.openstack.org/514709
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=6fe924d9c239f98375f92437cdd498d9c20f03a0
Submitter: Zuul
Branch: stable/17.08

commit 6fe924d9c239f98375f92437cdd498d9c20f03a0
Author: Frode Nordahl <email address hidden>
Date: Mon Oct 23 09:20:54 2017 +0200

    Fix imports for actions

    Change-Id: Ic5de38e4d56022e3f72e5dcb08f6a4253e3306ee
    Closes-bug: #1726275
    (cherry picked from commit b15237b3c54175f412bd0228c46d1cdc6dc546eb)
    (cherry picked from commit 52306f841910825ed632307415f31155f0b0c4a6)

Frode Nordahl (fnordahl)
Changed in charm-ceph-osd:
milestone: 17.11 → 17.08
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-mon (master)

Reviewed: https://review.openstack.org/514606
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-mon/commit/?id=712766c0945498e59fbbb398b3f9ba3473b9d5b7
Submitter: Zuul
Branch: master

commit 712766c0945498e59fbbb398b3f9ba3473b9d5b7
Author: Edward Hope-Morley <email address hidden>
Date: Tue Oct 24 12:04:49 2017 +0100

    Fix actions broken import

    Change-Id: I1f5f24fb31cdb04cf00a1ecbbd942f84cd7b19f5
    Partial-Bug: 1726275

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph (master)

Reviewed: https://review.openstack.org/514607
Committed: https://git.openstack.org/cgit/openstack/charm-ceph/commit/?id=b210d18d00e2b7e1c5b5b97ab403dd0951c90935
Submitter: Zuul
Branch: master

commit b210d18d00e2b7e1c5b5b97ab403dd0951c90935
Author: Edward Hope-Morley <email address hidden>
Date: Tue Oct 24 12:15:56 2017 +0100

    Fix actions broken import

    Change-Id: I04645d8ede55c3e5b3f97fcc5a9c0accc98f8f81
    Partial-Bug: 1726275

Edward Hope-Morley (hopem)
Changed in charm-ceph:
status: In Progress → Fix Committed
Changed in charm-ceph-mon:
status: In Progress → Fix Committed
James Page (james-page)
Changed in charm-ceph-mon:
status: Fix Committed → Fix Released
Changed in charm-ceph:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.