test_configure_compression fails with 'Services not running that should be: rbd-target-api'

ubuntu@juju-7d8e6f-zaza-ff9976283e4c-1:~$ journalctl -xe

Feb 16 20:52:56 juju-7d8e6f-zaza-ff9976283e4c-1 rbd-target-api[13633]: Invaid cluster_client_name or setting in /etc/ceph/ceph.conf - [errno 2] RADOS object not found (error calling conf_read_file)

ubuntu@juju-7d8e6f-zaza-ff9976283e4c-0:/var/lib/juju/agents/unit-ceph-iscsi-0/charm$ ls -al /etc/ceph
total 12
drwxr-xr-x 2 root root 4096 Feb 16 20:53 .
drwxr-xr-x 103 root root 4096 Feb 16 20:52 ..
lrwxrwxrwx 1 root root 27 Feb 16 20:53 ceph.conf -> /etc/alternatives/ceph.conf
-rw-r--r-- 1 root root 92 Dec 8 09:31 rbdmap

There should be an /etc/ceph/iscsi-gateway.cfg that gets rendered into /etc/ceph, and that will contain "cluster_client_name = client.ceph-iscsi".

/etc/ceph/ceph.conf from a failing unit

Tests were successful here in Sept: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/806947

I'm running a local test with this commit ^ to see if it's still successful.

I've confirmed this is limited to the new bundle changes in: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/828160

Specifically I tested with a charm built from the commit "Add support for Ceph dashboard support" and run with focal.yaml from that commit is successful, but fails with this one: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/828160/3/tests/bundles/focal.yaml

ceph-iscsi units seem to go from "1 is an invalid unit count" to "Services not running that should be: rbd-target-api".

This appears to be happening due to this change in ceph-mon:
https://opendev.org/openstack/charm-ceph-mon/commit/da798bdd95f8fa19ce42363be6bfb268d62fe690

Running with the prior commit in the ceph-mon git tree is succesful (commit 05a03bd10d885d161b07e6acf47d030549562768).

I'm seeing errors like this in the ceph-mon/leader juju log:

2022-02-17 21:22:36 INFO unit.ceph-mon/1.juju-log server.go:327 osd:7: Creating pool 'iscsi-foo-metadata' (replicas=3)
2022-02-17 21:22:36 ERROR unit.ceph-mon/1.juju-log server.go:327 osd:7: Failed to discover crush profile named None
2022-02-17 21:22:36 ERROR unit.ceph-mon/1.juju-log server.go:327 osd:7: Failed to discover crush profile named None

This line in class ReplicatedPool's __init__():

self.profile_name = op.get('crush-profile', profile_name)

the value of op['crush-profile'] is None. If I force that line to the following it works:

self.profile_name = profile_name

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-ceph-mon/+/829970

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-mon/+/829970
Committed: https://opendev.org/openstack/charm-ceph-mon/commit/d695ab315f7808f90eedad36a194f3d29d66eb4d
Submitter: "Zuul (22348)"
Branch: master

commit d695ab315f7808f90eedad36a194f3d29d66eb4d
Author: Corey Bryant <email address hidden>
Date: Fri Feb 18 12:25:37 2022 -0500

    Fix handling of profile-name

    The current code:
    self.profile_name = op.get('crush-profile', profile_name)

    will only default to profile_name if the 'crush-profile' key
    doesn't exist in the op dictionary. If the 'crush-profile' key
    exists and is set to None, the default profile_name is not used.

    This change will use the default profile_name in both cases.

    A full charm-helpers sync is done here.

    Closes-Bug: #1960622
    Change-Id: If9749e16eadfab5523d06c82f3899a83b8c6fdc1

I'm moving charm-ceph-iscsi to fix released since the fix has landed charm-ceph-mon.