Ceph Dashboard Charm

openstack-loadbalancer typo leads to connection failures through HAProxy

Bug #1998871 reported by Samuel Walladge
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceph Dashboard Charm
Fix Committed
Undecided
Samuel Walladge

Bug Description

There's a typo in the code where it requests a loadbalancer from the openstack-loadbalancer, so haproxy isn't configured with the desired http-check.

When ceph-dashboard is deployed and made relation with ceph-mon, in ceph-mon units, there will only be one unit active with ceph-dashboard, so if there are 3 ceph-mon units, 2 out of ceph-mon will be in standby for ceph-dashboard feature.
Therefore, it is expected to check http in haproxy configuration to avoid unnecessary redirect to standby unit.
Otherwise, you will get a 2 out of 3 chance to be redirected to a standby ceph-mon unit.
When you reload the page, eventually you will get access to the one where it is active, however this is far from ideal.

See original description
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph-dashboard (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-ceph-dashboard/+/866636

Changed in charm-ceph-dashboard:
status: New → In Progress
Revision history for this message
Samuel Walladge (swalladge) wrote : Re: openstack-loadbalancer typo in configuration

opened https://review.opendev.org/c/openstack/charm-ceph-dashboard/+/866636

Changed in charm-ceph-dashboard:
status: In Progress → Incomplete
status: Incomplete → In Progress
assignee: nobody → Samuel Walladge (swalladge)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-dashboard (master)

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-dashboard/+/866636
Committed: https://opendev.org/openstack/charm-ceph-dashboard/commit/03b85fc56ba177264b0cc60a0f3ec1287c098480
Submitter: "Zuul (22348)"
Branch: master

commit 03b85fc56ba177264b0cc60a0f3ec1287c098480
Author: Samuel Walladge <email address hidden>
Date: Tue Dec 6 12:33:10 2022 +1030

    Fix typo in requesting loadbalancer

    ceph-dashboard requires the `http-check expect status 200` configured
    in haproxy.
    openstack-loadbalancer only sets this up if the check_type is set
    to 'http'.

    Closes-Bug: #1998871
    Change-Id: Iea74aff1205813749cee71436af14ee3579db41a

Changed in charm-ceph-dashboard:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph-dashboard (stable/quincy)

Fix proposed to branch: stable/quincy
Review: https://review.opendev.org/c/openstack/charm-ceph-dashboard/+/870503

Revision history for this message
Yoshi Kadokawa (yoshikadokawa) wrote : Re: openstack-loadbalancer typo in configuration

I think the impact of this is issue was not so clear, so I would like to add that in this comment.

When ceph-dashboard is deployed and made relation with ceph-mon, in ceph-mon units, there will only be one unit active with ceph-dashboard, so if there are 3 ceph-mon units, 2 out of ceph-mon will be in standby for ceph-dashboard feature.
Therefore, it is expected to check http in haproxy configuration to avoid unnecessary redirect to standby unit.
Otherwise, you will get a 2 out of 3 chance to be redirected to a standby ceph-mon unit.
When you reload the page, eventually you will get access to the one where it is active, however this is far from ideal.

Yoshi Kadokawa (yoshikadokawa)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph-dashboard (stable/quincy.2)

Fix proposed to branch: stable/quincy.2
Review: https://review.opendev.org/c/openstack/charm-ceph-dashboard/+/872299

Nobuto Murata (nobuto)
summary: - openstack-loadbalancer typo in configuration
+ openstack-loadbalancer typo leads to connection failures through HAProxy
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-dashboard (stable/quincy.2)

Reviewed: https://review.opendev.org/c/openstack/charm-ceph-dashboard/+/872299
Committed: https://opendev.org/openstack/charm-ceph-dashboard/commit/bd04ab87f9351b162ae7c46d01a85377c0531464
Submitter: "Zuul (22348)"
Branch: stable/quincy.2

commit bd04ab87f9351b162ae7c46d01a85377c0531464
Author: Samuel Walladge <email address hidden>
Date: Tue Dec 6 12:33:10 2022 +1030

    Fix typo in requesting loadbalancer

    ceph-dashboard requires the `http-check expect status 200` configured
    in haproxy.
    openstack-loadbalancer only sets this up if the check_type is set
    to 'http'.

    Closes-Bug: #1998871
    Change-Id: Iea74aff1205813749cee71436af14ee3579db41a
    (cherry picked from commit 03b85fc56ba177264b0cc60a0f3ec1287c098480)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on charm-ceph-dashboard (stable/quincy)

Change abandoned by "Samuel Walladge <email address hidden>" on branch: stable/quincy
Review: https://review.opendev.org/c/openstack/charm-ceph-dashboard/+/870503

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.