"Go to Gmail Account" button opens several web browser instances

I can reproduce this problem in Hardy Heron.

Can reproduce with 0.5 in Hardy also. Happens around a dozen times for me, rendering the button useless.

I can confirm this for Ubuntu 7.10 64-bit.

It happens also in Epiphany browser...
and, by mistake, I've notice this bug on another post

I'm also experiencing this issue with cGmail 0.5 and Hardy Heron.

Marco Ferragina, is there any information that we could provide you to help track this one down?

After looking at the problem a little more closely and trying to find where it is in the code, I've noticed a few details:

cGmail tries to open one browser for every notification window that has been shown.

For example, if cGmail has shown me 5 notifications, and I click "Go to Gmail Account," cGmail tries to open 5 browsers.

I think the problem is in lib/notify.py, maybe in the __init__ method of the Notifier class.

Okay, I have created a patch for the 0.5 release. If you are only checking one mail account, this might fix the problem. If you are checking multiple accounts, the "Go to Gmail Account" button may sometimes take you to the wrong account, but at least it will only launch one browser.

My change doesn't truly fix the problem but maybe it will lead to a better solution. This is my first time submitting a patch somewhere, so please let me know if I should do something differently.

I've got this exact same problem one my laptop : ubuntu gutsu 7.10 / firefox 3.0 beta 4

ubuntu 7.10 / FF3b5 / cgmail .5; same here. Using multiple accounts, one gmail.com, one gmail hosted Mine opens my gmail account then four instances of my hosted account.

How exactly to I apply the patch? I'm pretty new to linux and was having the same issue with multiple instances of firefox opening. I tried using Ubuntu 7.10's search features and even tried googling for the location of notifier.py but can't find it to patch it. Help? Thanks. XD

Hi. thepumpkinkingx, if you are still interested, notifier.py gets installed to /usr/lib/python2.5/site-packages/cGmail/lib/notifier.py. In this case, you can apply the patch directly to the installed file if you want. I'm not sure if it's a good idea, but here's how I would do it:

sudo patch -p3 -i not_exactly_fix.patch /usr/lib/python2.5/site-packages/cGmail/lib/notifier.py

Make sure you have cgmail 0.5.

I can confirm in 0.5
It seems that if I open the same message 10 times it will open a new tab/window for every message that was shown.
I am using only one gmail account so I will try the patch proposed above.

I just wanted to alert that this bug is a showkiller for new cGmail users.
A fix should be made and a 0.5.1 version should be released...

This happens to me as well on Hardy and FF 3. There doesn't seem to be any pattern on how many windows it opens, but it seems like they increase over time. It really is unusable at this point.

I figured out the problem, and it should work for multiple accounts.

A new notification object is created for each notification window, and each one connects to the ActionInvoked signal. I found out that all the notifications objects were having their actions invoked, but they could keep track of an ID returned by the Notify method to make sure they only respond to actions on their window.

The code is still probably missing a close connection on this signal after the pop up disappears. Otherwise all these closed notifications wouldn't have having an affect.

I am not sure if this patch is in the right format. I haven't submitted patches to this project before, so let me know what the procedure is for submitting commits/patches.

Dylan attached a patch for this bug, please review it and commit it :)

This bug is very annoying for a great app like this!

Applied Ismael Carnales patch. Thanks

All the credit goes to Dylan Smith, I've only assigned the bug to you Marco :)

Thanks for the quick review, and keep the good work.

Ops :) Sorry Dylan. Thanks for the patch

When I apply the patch with this command:

sudo patch -p3 -i open-browser-once.patch /usr/lib/python2.5/site-packages/cGmail/lib/notifier.py

I get the following error in the terminal:

"missing header for unified diff at line 15 of patch"

But it seems as if the patch is applied anyway. Can someone explain this?

patch works fine!

last patch ( By: Dylan ) working and now it open one instance no more ..

I added the patch: i have 2 Gmail accounts, and now almost everything works ok, but cgmail opens automatically only the first time opened account. So, for the second account i have to log out and log in manually. Can anyone tells if these bug are fixed (will be) because the application is very good? Btw, i have Dell Mini 9 with Ubuntu 8.04 (LPIA).
Still, with this programm does very good job-the most important is to have overview over multiple accounts...