functional test for mysql are skipped with mysql+pymysql

Bug #1506777 reported by ZhiQiang Fan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
ZhiQiang Fan
Liberty
Fix Committed
Undecided
gordon chung

Bug Description

devstack will setup ceilometer with mysql connection = mysql+pymysql://xxx

this is because default MYSQL_DRIVER is PyMySQL

but out functional test code doesn't recognize such prefix, so all functional test for mysql will be skipped, for i.e.:

ceilometer.tests.functional.storage.test_storage_scenarios.ComplexSampleQueryTest.test_query_complex_filter_with_regexp_metadata(mysql) ... SKIPPED: missing driver manager: No manager available for mysql+pymysql

reproduce:

1. setup devstack with default settings
2. export CEILOMETER_TEST_BACKEND=mysql
3. tox -efunctional

ZhiQiang Fan (aji-zqfan)
Changed in ceilometer:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235831

Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/235831
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=bf85df219e02dd1203457eb88eda32b3871aa3c4
Submitter: Jenkins
Branch: master

commit bf85df219e02dd1203457eb88eda32b3871aa3c4
Author: ZhiQiang Fan <email address hidden>
Date: Fri Oct 16 03:13:03 2015 -0700

    support mysql+pymysql in functional test

    Currently, if we use PyMySQL as MySQL driver, database connection
    url will be set to mysql+pymysql://, but our functional test doesn't
    recognize such engine name, which finally will skip all the functional
    test for mysql backend.

    This patch simply maps mysql+pymysql to mysql.

    Change-Id: I924de57e9f194f183a405846a6ac98968a2483d3
    Closes-Bug: #1506777

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/236038

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/liberty)

Reviewed: https://review.openstack.org/236038
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=be0f96599f89d5983643b825d9d35246da09f4c1
Submitter: Jenkins
Branch: stable/liberty

commit be0f96599f89d5983643b825d9d35246da09f4c1
Author: ZhiQiang Fan <email address hidden>
Date: Fri Oct 16 03:13:03 2015 -0700

    support mysql+pymysql in functional test

    Currently, if we use PyMySQL as MySQL driver, database connection
    url will be set to mysql+pymysql://, but our functional test doesn't
    recognize such engine name, which finally will skip all the functional
    test for mysql backend.

    This patch simply maps mysql+pymysql to mysql.

    Change-Id: I924de57e9f194f183a405846a6ac98968a2483d3
    Closes-Bug: #1506777
    (cherry picked from commit bf85df219e02dd1203457eb88eda32b3871aa3c4)

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/ceilometer 6.0.0.0b1

This issue was fixed in the openstack/ceilometer 6.0.0.0b1 development milestone.

Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ceilometer 5.0.1

This issue was fixed in the openstack/ceilometer 5.0.1 release.

Liusheng (liusheng)
Changed in ceilometer:
milestone: none → mitaka-1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.