Ceilometer

ceilometer identity.trust.* samples are not stored

Bug #1488707 reported by Ashwin Agate
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Rohit Jaiswal
Ceilometer 5.0.0 "liberty"
Kilo
Fix Released
Undecided
Rohit Jaiswal
Ceilometer 2015.1.3

Bug Description

Keystone generates trust notifications with event_type set to identity.OS-TRUST:trust.created and identity.OS-TRUST:trust.deleted, but these notifications are not stored in ceilometer, because of mismatch in meter name happens both in liberty and kilo.

To generate keystone notifications

openstack trust create --project demo --role admin admin demo
openstack delete <trust-id>

1.)
Recent change made in ceilometer (kilo)
https://bugs.launchpad.net/ceilometer/+bug/1392326 fixed problem where identity notification plugin's event_types method was modified to accept the new event type containing the "OS-TRUST:" namespace.

But the problem is if the pipeline.yaml contains documented meters "identity.trust.created" or "identity.trust.deleted", that sample gets thrown away since it doesnt match "identity.OS-TRUST:trust.created" (ceilometer.pipeline.SampleSource support_meter(..) returns False)

2.)
Similar mismatch exists in Liberty where event_type in meters.yaml is set to identity.trust.created and identity.trust.deleted
https://github.com/openstack/ceilometer/blob/master/ceilometer/meter/data/meters.yaml#L620-L629

Fix would be to change event_type in meters.yaml to identity.OS-TRUST:trust.created and identity.OS-TRUST:trust.deleted.

See original description
Ashwin Agate (ashwin-agate)
description: updated
Rohit Jaiswal (rohit-jaiswal-3)
Changed in ceilometer:
assignee: nobody → Rohit Jaiswal (rohit-jaiswal-3)
OpenStack Infra (hudson-openstack)
Changed in ceilometer:
status: New → In Progress
Revision history for this message
Rohit Jaiswal (rohit-jaiswal-3) wrote :

https://review.openstack.org/#/c/216979/ fixes it on master, probably need a doc bug to fix the docs on stable/kilo

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/217415

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/216979
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=cc3f6892ff8d4a71c390e2de7407670d360d5bcc
Submitter: Jenkins
Branch: master

commit cc3f6892ff8d4a71c390e2de7407670d360d5bcc
Author: Rohit Jaiswal <email address hidden>
Date: Wed Aug 26 05:38:34 2015 +0000

    Fixed identity trust event types

    Identity trust event types have resource_type
    prefixed with OS-TRUST:, this patch fixes
    the declarative meter definition file to
    include that change.

    Closes-Bug: 1488707
    DocImpact

    Change-Id: I1f82049a78b7693f8d03803ce500f8f4c268b0a1

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/kilo)

Reviewed: https://review.openstack.org/217415
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=c93ca9168e8f74e6b4f79d22ae4c1b34e36ef52c
Submitter: Jenkins
Branch: stable/kilo

commit c93ca9168e8f74e6b4f79d22ae4c1b34e36ef52c
Author: Rohit Jaiswal <email address hidden>
Date: Wed Aug 26 22:26:06 2015 +0000

    Fix meter name for identity.OS-TRUST:trust.* events

    Identity Trust notification plugin has event_types
    as identity.OS-TRUST:trust.created|deleted, but the
    sample name is also the same, which is different than
    the documented meter name for identity.trust:
    identity.trust.created|deleted.

    This causes the sample to be ignored by the pipeline
    (assuming the pipeline uses documented meter names).

    This fix aligns the sample name to be similar to
    the documented meter names for identity.trust and
    updates unit tests.

    This is a stable/kilo only change since master has
    moved on declarative meter definitions and no longer
    support plugins for each set of event types.

    A different fix has been done on master for the same
    problem and that cannot be cherry-picked to stable/kilo
    for the above reason.

    see: I1f82049a78b7693f8d03803ce500f8f4c268b0a1

    Change-Id: I331e087d1385046465d8faed5d0d3c62b31d9b3f
    Closes-Bug: 1488707

Thierry Carrez (ttx)
Changed in ceilometer:
milestone: liberty-3 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.