Ceilometer

collector unnecessarily converts Event dict message received back into object

Bug #1438285 reported by gordon chung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
gordon chung
Ceilometer 5.0.0 "liberty"

Bug Description

the collector currently receives a dictionary payload from notification translates it back to an Event object model, and then dispatches it to the appropriate target. this step is unnecessary as the model was built, validate, and seralised as part of notification agent.

Rohit Jaiswal (rohit-jaiswal-3)
summary: - collector unnecessarily converst Event dict message received back into
+ collector unnecessarily converts Event dict message received back into
object
Revision history for this message
Rohit Jaiswal (rohit-jaiswal-3) wrote :

Only thing is that event storage layer is tightly coupled to the Event model object, so i assume the storage layer will cast the dictionary back to the Event model object, otherwise, i expect a lot of work to make things work w.r.t expecting an object.

Revision history for this message
gordon chung (chungg) wrote :

yeah. i see that now... and the more i think about it, this isn't that big a deal as it's generally only one event... i'm going to try performance testing this to see if it actually makes a difference.

Changed in ceilometer:
status: Triaged → Incomplete
Revision history for this message
gordon chung (chungg) wrote :

this takes ~130us/event (depending on traits)... not nothing but not everything.

i think i can put this off for L* as it is slightly tied to problem_events... we seem to capture it right now... but nothing seems to be using it.

Changed in ceilometer:
status: Incomplete → Triaged
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/174039

Changed in ceilometer:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/174039
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=5521215dc8b5327606f3292f1479f8630bf7a15d
Submitter: Jenkins
Branch: master

commit 5521215dc8b5327606f3292f1479f8630bf7a15d
Author: gordon chung <email address hidden>
Date: Wed Apr 15 15:20:12 2015 -0400

    rebuild event model only for database writes

    we should only build event model when dispatching to database. we
    do not need to ensure type-correctness when writing to file or
    http.

    Change-Id: I553f9062299d7ddcfd0d694aad7a432692bdc953
    Closes-Bug: #1438285

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: liberty-1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.