Ceilometer

API service has unnecessary transitive dependencies on tooz and ceilometerclient

Bug #1413237 reported by Eoghan Glynn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Eoghan Glynn
Ceilometer 2015.1.0 "kilo"

Bug Description

The API service imports alarm.service without a strong justification:

  https://github.com/openstack/ceilometer/commit/3e8f8e98

creating transitive dependencies on python-tooz and python-ceilometerclient, which would otherwise not be required by the API service.

The relevant code could easily be moved out of alarm.service to avoid this dependency.

Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → kilo-2
assignee: nobody → Eoghan Glynn (eglynn)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148991

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/148991
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=8926a202028e43ce9c600fdff5efd34fcdd235f0
Submitter: Jenkins
Branch: master

commit 8926a202028e43ce9c600fdff5efd34fcdd235f0
Author: Eoghan Glynn <email address hidden>
Date: Wed Jan 21 17:10:59 2015 +0000

    Avoid unnecessary API dependency on tooz & ceilometerclient

    Previously, importing the alarm.service in the v2 API layer
    created an unnecessary transitive dependency on python-tooz
    and python-ceilometerclient.

    We avoid these dependencies simply by moving the relevant code.

    Change-Id: I1b936bf4dc2ad28afb7a45f61bfcd111adb20e1c
    Closes-Bug: #1413237

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.