Dependencies currently being built should be notified differently

Bug #1421337 reported by Caio Begotti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Capomastro
Fix Committed
High
Caio Begotti

Bug Description

Right now when a dependency is being built Capomastro will display a blue alert via python-django-bootstrap but that is not very user-friendly for the following reasons:

- When a build is finished, fails, or whatever, it is properly listed in the Builds section of the view
- Alerts should be alerts, not simple notifications
- It won't stop the user from submitting it again

IMHO we should add an entry with the current build to the Builds section of the view, along the fields Build Id, Duration and Result. Also, field Result could have a BUILDING: 'info' value in this case. This would complement the other statuses we have now:

/tmp/capomastro$ cat capomastro/site/templatetags/capomastro_bootstrap.py:
    known_statuses = {
        "SUCCESS": "success",
        "FAILURE": "danger",
        "ABORTED": "info"
    }

To be completely honest I think we should also changed ABORTED to 'warning' while we would be at it, but we can discuss it later if the others prefer to do things separately.

I know this is hard to visualize without screenshots, but I can't work on this now but it should be simple to change so I am filing this bug to be triaged.

Related branches

Revision history for this message
Caio Begotti (caio1982) wrote :

I would argue also that is the dependency is being built the submit button should be disabled (but visible) too.

Daniel Manrique (roadmr)
Changed in capomastro:
status: New → Triaged
importance: Undecided → High
milestone: none → 2015-04
Changed in capomastro:
assignee: nobody → Sheila Miguez (codersquid)
Changed in capomastro:
assignee: Sheila Miguez (codersquid) → nobody
Changed in capomastro:
assignee: nobody → Sheila Miguez (codersquid)
status: Triaged → In Progress
Changed in capomastro:
assignee: Sheila Miguez (codersquid) → nobody
Changed in capomastro:
assignee: nobody → Sheila Miguez (codersquid)
Revision history for this message
Sheila Miguez (codersquid) wrote :

We've been discussing this in IRC. The user experience for someone building from a Dependency page is different from the user experience for someone building from a Project page.

Revision history for this message
Caio Begotti (caio1982) wrote :

Ok so I'm adding this as a comment so we don't loose the original bug description in case this new attempt of explaining it is not very clear yet:

1. When you build a dependency directly (not through a project). On the top screen Capomastro will say the build has been queued, in a blue notification box. That's fine. But when you reload the page it says "Dependency currently building" in another blue notification. At the same time, the Builds sections has now a new blank line with no build ID, no duration, not result status, no nothing.

Even if we don't have a status coming back from Jenkins, or duration, we should still display a BUILDING result status and not show the blue notification with "Dependency currently building" IMHO.

2. Also, as said in the end of the description, we have:

        "ABORTED": "info"

in capomastro/site/templatetags/capomastro_bootstrap.py but an ABORTED build should be 'warning' IMHO.

Caio Begotti (caio1982)
Changed in capomastro:
assignee: Sheila Miguez (codersquid) → Caio Begotti (caio1982)
Revision history for this message
Caio Begotti (caio1982) wrote :

Just a sample screenshot showing the original view statuses and notification and at the bottom after changes (at the bottom) implemented by the linked branch.

Caio Begotti (caio1982)
Changed in capomastro:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.