Dependencies currently being built should be notified differently
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Capomastro |
Fix Committed
|
High
|
Caio Begotti | ||
Bug Description
Right now when a dependency is being built Capomastro will display a blue alert via python-
- When a build is finished, fails, or whatever, it is properly listed in the Builds section of the view
- Alerts should be alerts, not simple notifications
- It won't stop the user from submitting it again
IMHO we should add an entry with the current build to the Builds section of the view, along the fields Build Id, Duration and Result. Also, field Result could have a BUILDING: 'info' value in this case. This would complement the other statuses we have now:
/tmp/capomastro$ cat capomastro/
known_statuses = {
"SUCCESS": "success",
"FAILURE": "danger",
"ABORTED": "info"
}
To be completely honest I think we should also changed ABORTED to 'warning' while we would be at it, but we can discuss it later if the others prefer to do things separately.
I know this is hard to visualize without screenshots, but I can't work on this now but it should be simple to change so I am filing this bug to be triaged.
Related branches
- Daniel Manrique (community): Approve
-
Diff: 138 lines (+29/-15)6 files modifiedcapomastro/site/templatetags/capomastro_bootstrap.py (+7/-1)
capomastro/site/templatetags/tests/test_capomastro_bootstrap.py (+3/-2)
jenkins/models.py (+2/-1)
jenkins/tests/test_views.py (+1/-1)
projects/tests/test_views.py (+5/-4)
projects/views.py (+11/-6)
| Caio Begotti (caio1982) wrote | #1 |
| Changed in capomastro: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| milestone: | none → 2015-04 |
| Changed in capomastro: | |
| assignee: | nobody → Sheila Miguez (codersquid) |
| Changed in capomastro: | |
| assignee: | Sheila Miguez (codersquid) → nobody |
| Changed in capomastro: | |
| assignee: | nobody → Sheila Miguez (codersquid) |
| status: | Triaged → In Progress |
| Changed in capomastro: | |
| assignee: | Sheila Miguez (codersquid) → nobody |
| Changed in capomastro: | |
| assignee: | nobody → Sheila Miguez (codersquid) |
| Sheila Miguez (codersquid) wrote | #2 |
| Caio Begotti (caio1982) wrote | #3 |
| Changed in capomastro: | |
| assignee: | Sheila Miguez (codersquid) → Caio Begotti (caio1982) |
| Caio Begotti (caio1982) wrote | #4 |
| Changed in capomastro: | |
| status: | In Progress → Fix Committed |
I would argue also that is the dependency is being built the submit button should be disabled (but visible) too.