Close Dash Page header "extra" panel when selecting an option on the dash primary filter
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Medium
|
Unassigned | ||
canonical-scopes-project |
New
|
Undecided
|
Unassigned | ||
unity8 (Ubuntu) |
Fix Released
|
Medium
|
Josh Arenson |
Bug Description
We should close the Dash Page header extra panel (i.e. the one that contains old searches/
We will only allow "sigle selection filters" in there, so the single selection option or a radio group (when/if we have it), so we can perfectly close the panel when something on the filter has been selected.
Suggested solution to the bug by Albert: FilterWidget needs to have a "clicked/activated" signal that the FilterOptionSel
*******
Old description, comments up to #5 relate to this description
When you are using an option filter as the primary navigation widget, usually dismissing the filter widget by tapping results causes a result preview to display, but the user really wants to see all results and only dismiss the filter overly.
You can see this in the attached fake 500px click:
1) tap the search magnifying glass icon to display the filter overlay
2) expand "Discover" (that is the title of the nav filter in this case
3) select any option under Discover
4) collapse "Discover" so that the overlay is small enough that some results are visible
5) tap results area to dismiss the overlay
What happens: The preview for the result you tapped displays
What was expected: the filter overlay disappears showing results
Related branches
- Albert Astals Cid (community): Approve
- Unity8 CI Bot: Needs Fixing (continuous-integration)
-
Diff: 150 lines (+51/-0)6 files modifiedqml/Dash/Filters/FilterOptionSelector.qml (+4/-0)
qml/Dash/Filters/FilterWidgetFactory.qml (+8/-0)
qml/Dash/GenericScopeView.qml (+5/-0)
qml/Dash/PageHeaderExtraPanel.qml (+3/-0)
tests/mocks/Unity/fake_scope.cpp (+4/-0)
tests/qmltests/Dash/tst_Dash.qml (+27/-0)
summary: |
- dismissing primary nav filter shows a preview + Close Dash "extra" panel when selecting an option on the dash primary + filter |
summary: |
- Close Dash "extra" panel when selecting an option on the dash primary - filter + Close Dash Page header "extra" panel when selecting an option on the + dash primary filter |
description: | updated |
Changed in unity8 (Ubuntu): | |
status: | Incomplete → Triaged |
assignee: | nobody → Josh Arenson (josharenson) |
importance: | Undecided → Medium |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → Medium |
milestone: | none → 12 |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
This is how the panel always has worked, if you go to a scope that has departments instead of a primary filter, you'll see it behaves the same way.
If you disagree with this behaviour please ask design (probably Patricia) about it.