Canonical Pocket Desktop

Black layer when device switches from window to stage mode and side-stage open

Bug #1544479 reported by Jean-Baptiste Lallement on 2016-02-11

This bug affects 2 people

	Status	Importance	Assigned to	Milestone
Canonical Pocket Desktop	Fix Committed	Critical	kevin gunn
Canonical System Image	Fix Released	Critical	Michał Sawicz	Canonical System Image 10 "OTA10"
unity8 (Ubuntu)	Fix Released	Critical	Nick Dedekind

Bug Description

bq-aquaris-pd.en 18

On a device with side stage support.

Test Case:
1. In staged mode, open system-settings
2. Pair a mouse and keyboard to switch to window mode
3. Set system-settings to full-screen
4. Unpair the mouse and keyboard

Expected Result
System-settings is on the side and the dash is visible

Actual Result
System-settings is on the side but there is a black overlay on top of the dash.

Tags:

Related branches

lp://staging/~nick-dedekind/unity8/side-stage-redesign

Superseded for merging into lp://staging/unity8

Daniel d'Andrada (community): Approve on 2016-03-10

Unity8 CI Bot: Needs Fixing (continuous-integration) on 2016-03-10

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2016-02-23

Michael Zanetti (community): Needs Fixing on 2016-02-18

Lukáš Tinkl: Pending (code-review) requested 2016-02-16

Diff: 5646 lines (+3671/-447) (has conflicts)

55 files modified

CMakeLists.txt (+1/-1)
CODING (+2/-0)
debian/control (+7/-3)
libs/UbuntuGestures/Timer.h (+5/-0)
libs/UbuntuGestures/TouchRegistry.cpp (+15/-10)
plugins/Cursor/Cursor.qmltypes (+78/-0)
plugins/GlobalShortcut/GlobalShortcut.qmltypes (+31/-0)
plugins/Ubuntu/Gestures/CMakeLists.txt (+1/-0)
plugins/Ubuntu/Gestures/DirectionalDragArea.cpp (+3/-0)
plugins/Ubuntu/Gestures/Gestures.qmltypes (+87/-46)
plugins/Ubuntu/Gestures/TouchGestureArea.cpp (+875/-0)
plugins/Ubuntu/Gestures/TouchGestureArea.h (+229/-0)
plugins/Ubuntu/Gestures/plugin.cpp (+3/-0)
plugins/Unity/InputInfo/InputInfo.qmltypes (+71/-0)
plugins/Unity/Platform/Platform.qmltypes (+20/-0)
plugins/Utils/CMakeLists.txt (+1/-0)
plugins/Utils/globalfunctions.cpp (+56/-0)
plugins/Utils/globalfunctions.h (+42/-0)
plugins/Utils/plugin.cpp (+9/-0)
plugins/Utils/windowstatestorage.cpp (+36/-4)
plugins/Utils/windowstatestorage.h (+3/-0)
qml/Components/Showable.qml (+10/-0)
qml/Shell.qml (+2/-6)
qml/Stages/AbstractStage.qml (+1/-1)
qml/Stages/ApplicationWindow.qml (+3/-1)
qml/Stages/SideStage.qml (+118/-0)
qml/Stages/SpreadDelegate.qml (+10/-1)
qml/Stages/SurfaceContainer.qml (+1/-0)
qml/Stages/TabletSideStageTouchGesture.qml (+154/-0)
qml/Stages/TabletStage.qml (+402/-191)
qml/Stages/TransformedTabletSpreadDelegate.qml (+86/-58)
qml/Stages/graphics/sidestage_drag.svg (+207/-0)
qml/Stages/graphics/sidestage_open.svg (+181/-0)
src/MouseTouchAdaptor.cpp (+53/-9)
src/MouseTouchAdaptor.h (+5/-3)
tests/libs/UbuntuGestures/tst_TouchRegistry.cpp (+59/-0)
tests/mocks/Unity/Application/ApplicationManager.cpp (+10/-25)
tests/mocks/Unity/Application/ApplicationManager.h (+0/-8)
tests/mocks/Unity/Application/MirSurfaceItem.cpp (+17/-0)
tests/mocks/Unity/Application/MirSurfaceItem.h (+1/-0)
tests/mocks/Unity/Application/resources/MirSurfaceItem.qml (+59/-0)
tests/mocks/Utils/CMakeLists.txt (+1/-0)
tests/mocks/Utils/plugin.cpp (+9/-0)
tests/mocks/Utils/windowstatestorage.cpp (+13/-0)
tests/mocks/Utils/windowstatestorage.h (+4/-0)
tests/plugins/Ubuntu/Gestures/CMakeLists.txt (+7/-1)
tests/plugins/Ubuntu/Gestures/GestureTest.cpp (+44/-0)
tests/plugins/Ubuntu/Gestures/GestureTest.h (+13/-1)
tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp (+0/-56)
tests/plugins/Ubuntu/Gestures/tst_TouchGestureArea.cpp (+270/-0)
tests/plugins/Ubuntu/Gestures/tst_TouchGestureArea.qml (+90/-0)
tests/plugins/Unity/Launcher/launchermodeltest.cpp (+1/-0)
tests/qmltests/Stages/tst_TabletStage.qml (+143/-0)
tests/qmltests/tst_OrientedShell.qml (+55/-11)
tests/utils/modules/Unity/Test/UnityTestCase.qml (+67/-11)

lp://staging/~unity-team/unity8/side-stage-redesign

Merged into lp://staging/unity8 at revision 2287

Michael Zanetti (community): Abstain on 2016-03-15

Michael Terry: Approve on 2016-03-14

Unity8 CI Bot: Needs Fixing (continuous-integration) on 2016-03-11

PS Jenkins bot: Pending (continuous-integration) requested 2016-03-11

Lukáš Tinkl: Pending (code-review) requested 2016-03-11

Daniel d'Andrada: Pending requested 2016-03-11

Diff: 5700 lines (+3695/-449)

56 files modified

CMakeLists.txt (+1/-1)
CODING (+2/-0)
debian/control (+4/-4)
libs/UbuntuGestures/Timer.h (+5/-0)
libs/UbuntuGestures/TouchRegistry.cpp (+15/-10)
plugins/Cursor/Cursor.qmltypes (+78/-0)
plugins/GlobalShortcut/GlobalShortcut.qmltypes (+31/-0)
plugins/Ubuntu/Gestures/CMakeLists.txt (+1/-0)
plugins/Ubuntu/Gestures/DirectionalDragArea.cpp (+3/-0)
plugins/Ubuntu/Gestures/Gestures.qmltypes (+87/-46)
plugins/Ubuntu/Gestures/TouchGestureArea.cpp (+875/-0)
plugins/Ubuntu/Gestures/TouchGestureArea.h (+229/-0)
plugins/Ubuntu/Gestures/plugin.cpp (+3/-0)
plugins/Unity/InputInfo/InputInfo.qmltypes (+71/-0)
plugins/Unity/Platform/Platform.qmltypes (+20/-0)
plugins/Utils/CMakeLists.txt (+1/-0)
plugins/Utils/globalfunctions.cpp (+56/-0)
plugins/Utils/globalfunctions.h (+42/-0)
plugins/Utils/plugin.cpp (+9/-0)
plugins/Utils/windowstatestorage.cpp (+36/-4)
plugins/Utils/windowstatestorage.h (+3/-0)
qml/Components/Showable.qml (+10/-0)
qml/Shell.qml (+2/-6)
qml/Stages/AbstractStage.qml (+1/-1)
qml/Stages/ApplicationWindow.qml (+3/-1)
qml/Stages/SideStage.qml (+118/-0)
qml/Stages/SpreadDelegate.qml (+10/-1)
qml/Stages/SurfaceContainer.qml (+1/-0)
qml/Stages/TabletSideStageTouchGesture.qml (+154/-0)
qml/Stages/TabletStage.qml (+402/-187)
qml/Stages/TransformedTabletSpreadDelegate.qml (+86/-58)
qml/Stages/graphics/sidestage_drag.svg (+207/-0)
qml/Stages/graphics/sidestage_open.svg (+181/-0)
src/MouseTouchAdaptor.cpp (+53/-9)
src/MouseTouchAdaptor.h (+5/-3)
tests/libs/UbuntuGestures/tst_TouchRegistry.cpp (+59/-0)
tests/mocks/Unity/Application/ApplicationManager.cpp (+10/-25)
tests/mocks/Unity/Application/ApplicationManager.h (+0/-8)
tests/mocks/Unity/Application/MirSurfaceItem.cpp (+17/-0)
tests/mocks/Unity/Application/MirSurfaceItem.h (+1/-0)
tests/mocks/Unity/Application/resources/MirSurfaceItem.qml (+59/-0)
tests/mocks/Unity/Indicators/ModelActionRootState.qml (+27/-5)
tests/mocks/Utils/CMakeLists.txt (+1/-0)
tests/mocks/Utils/plugin.cpp (+9/-0)
tests/mocks/Utils/windowstatestorage.cpp (+13/-0)
tests/mocks/Utils/windowstatestorage.h (+4/-0)
tests/plugins/Ubuntu/Gestures/CMakeLists.txt (+7/-1)
tests/plugins/Ubuntu/Gestures/GestureTest.cpp (+44/-0)
tests/plugins/Ubuntu/Gestures/GestureTest.h (+13/-1)
tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp (+0/-56)
tests/plugins/Ubuntu/Gestures/tst_TouchGestureArea.cpp (+270/-0)
tests/plugins/Ubuntu/Gestures/tst_TouchGestureArea.qml (+90/-0)
tests/plugins/Unity/Launcher/launchermodeltest.cpp (+1/-0)
tests/qmltests/Stages/tst_TabletStage.qml (+143/-0)
tests/qmltests/tst_OrientedShell.qml (+55/-11)
tests/utils/modules/Unity/Test/UnityTestCase.qml (+67/-11)

kevin gunn (kgunn72) on 2016-02-11

Changed in canonical-pocket-desktop:
importance:	Undecided → High
Changed in canonical-devices-system-image:
importance:	Undecided → High
Changed in unity8 (Ubuntu):
importance:	Undecided → High
importance:	High → Critical
Changed in canonical-devices-system-image:
importance:	High → Critical
Changed in canonical-pocket-desktop:
importance:	High → Critical
Changed in canonical-devices-system-image:
assignee:	nobody → Michał Sawicz (saviq)
milestone:	none → ww08-2016
Changed in canonical-pocket-desktop:
assignee:	nobody → kevin gunn (kgunn72)

Revision history for this message

Michał Sawicz (saviq) wrote on 2016-02-11:

Can confirm, the tablet stage gets confused. Could use a test with the stage reimplementation:

https://requests.ci-train.ubuntu.com/#/ticket/736

Changed in unity8 (Ubuntu):
status:	New → Triaged
Changed in canonical-devices-system-image:
status:	New → Triaged
Changed in canonical-pocket-desktop:
status:	New → Triaged

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2016-02-24:

I could not see this issue with dednicks side stage rework. Linking that branch and setting to INPROGRESS

Changed in unity8 (Ubuntu):
assignee:	nobody → Nick Dedekind (nick-dedekind)
status:	Triaged → In Progress
Changed in canonical-devices-system-image:
status:	Triaged → In Progress
Changed in canonical-pocket-desktop:
status:	Triaged → In Progress

Jean-Baptiste Lallement (jibel) on 2016-03-24

Changed in canonical-pocket-desktop:
status:	In Progress → Fix Committed
Changed in canonical-devices-system-image:
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-03-25:

This bug was fixed in the package unity8 - 8.12+16.04.20160323.2-0ubuntu1

---------------
unity8 (8.12+16.04.20160323.2-0ubuntu1) xenial; urgency=medium

  [ Michael Terry ]
  *
  * Fix setting OSK layout in OOBE wizard
  * Stop the left edge tutorial from being shown when the bottom edge
    tutorial wants to be shown after receiving a call.

  [ Albert Astals Cid ]
  * Filter implementation with Option Selector filter as the only filter
  * Get the engine from the parent context
  * Implement the API changes due to filters
  * Match design visuals for the new dash navigation/page header popup
  * New Dash Navigation UX
  * Range Input filter
  * Value slider filter
  * Workaround SDK ListItem bug

[ Albert Astals Cid, Lukáš Tinkl ]
* Fix various tests

  [ CI Train Bot ]
  * Resync trunk.
  * Update translation template

  [ Lukáš Tinkl, Michael Terry ]
  * New first-run wizard for the phone (part of the OOBE effort) (LP:
    #1536688, #1536617, #1543790, #1555222)

[ Lukáš Tinkl, Michał Sawicz ]
* Keymap switching support (LP: #1524400, #1412492, #1491340)

[ Michael Terry, Michael Zanetti ]
* Redesign the first-boot edge tutorial

  [ Michael Zanetti ]
  * disabling some tests that are flaky in adt but can't be made fail on
    our machines

  [ Michael Zanetti, Michał Sawicz ]
  * Change the behavior alond with the switch in indicator-display (LP:
    #1538591)

  [ Michael Zanetti, Michał Sawicz, Nick Dedekind ]
  * Add support for low shell chrome. (LP: #1535397)
  * Sidestage load/unload redesign (LP: #1544479)

-- Michael Zanetti <email address hidden> Wed, 23 Mar 2016 09:53:17 +0000

Changed in unity8 (Ubuntu):
status:	In Progress → Fix Released

Pat McGowan (pat-mcgowan) on 2016-04-12

Changed in canonical-devices-system-image:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.