Inconsistent action buttons
Bug #948995 reported by
Stuart Metcalfe
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical SSO provider |
Fix Released
|
Low
|
Stuart Metcalfe | ||
Bug Description
With the update to the action buttons on the devices table for bug #948408 the application and email management pages are now inconsistent:
Application page: uses Ubuntu-style buttons but they're larger than in the devices table
Emails page: says "Remove" rather than "Delete" and uses the old Launchpad style, not the new Ubuntu style
Related branches
lp://staging/~stuartmetcalfe/canonical-identity-provider/more-2f-fixes
- Simon Davy (community): Approve
-
Diff: 349 lines (+104/-31)14 files modifiedidentityprovider/media/ubuntu/forms.css (+1/-1)
identityprovider/media/ubuntu/styles.css (+27/-1)
identityprovider/templates/account/applications.html (+3/-3)
identityprovider/templates/account/delete_email.html (+4/-4)
identityprovider/templates/account/emails.html (+3/-3)
identityprovider/templates/device/list.html (+5/-5)
identityprovider/templates/launchpad/registration/twofactor.html (+2/-2)
identityprovider/templates/ubuntu/registration/twofactor.html (+2/-2)
identityprovider/templates/widgets/ubuntu/logout-button.html (+10/-2)
identityprovider/tests/acceptance/applications/delete_app.py (+2/-2)
identityprovider/tests/acceptance/logout/logout_deep_pages.py (+36/-0)
identityprovider/tests/acceptance/shared/helpers.py (+2/-2)
identityprovider/views/account.py (+1/-1)
identityprovider/views/ui.py (+6/-3)
Revision history for this message
| Stuart Metcalfe (stuartmetcalfe) wrote | #1 |
| Changed in canonical-identity-provider: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-identity-provider: | |
| milestone: | none → 12.03.08 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The applications table uses <button> rather than <a> elements due to an inconsistency with the deletion workflow. I've filed bug #950020 but until that bug is fixed, the application delete buttons will be unstyled.