When SSO 2 Auth Fails, the 'New Account' frame is shown unintentially, mildly confusing
Bug #948434 reported by
Julien Funk
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical SSO provider |
Fix Released
|
Medium
|
Stuart Metcalfe | ||
Bug Description
When attempting to delete a 2F Auth device and entering the wrong password, the 'New Account' frame is shown next to the password form. This is an inappropriate time to show this frame and it should be removed.
Related branches
lp://staging/~stuartmetcalfe/canonical-identity-provider/more-2f-fixes
- Simon Davy (community): Approve
-
Diff: 349 lines (+104/-31)14 files modifiedidentityprovider/media/ubuntu/forms.css (+1/-1)
identityprovider/media/ubuntu/styles.css (+27/-1)
identityprovider/templates/account/applications.html (+3/-3)
identityprovider/templates/account/delete_email.html (+4/-4)
identityprovider/templates/account/emails.html (+3/-3)
identityprovider/templates/device/list.html (+5/-5)
identityprovider/templates/launchpad/registration/twofactor.html (+2/-2)
identityprovider/templates/ubuntu/registration/twofactor.html (+2/-2)
identityprovider/templates/widgets/ubuntu/logout-button.html (+10/-2)
identityprovider/tests/acceptance/applications/delete_app.py (+2/-2)
identityprovider/tests/acceptance/logout/logout_deep_pages.py (+36/-0)
identityprovider/tests/acceptance/shared/helpers.py (+2/-2)
identityprovider/views/account.py (+1/-1)
identityprovider/views/ui.py (+6/-3)
Revision history for this message
| Julien Funk (jaboing) wrote | #1 |
| Changed in canonical-identity-provider: | |
| importance: | Undecided → Medium |
| Changed in canonical-identity-provider: | |
| status: | New → Confirmed |
| milestone: | none → 2-factor-post-rollout |
| assignee: | nobody → Stuart Metcalfe (stuartmetcalfe) |
| Changed in canonical-identity-provider: | |
| milestone: | 2-factor-post-rollout → 2-factor-internal-rollout |
| Changed in canonical-identity-provider: | |
| status: | Confirmed → In Progress |
| Changed in canonical-identity-provider: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-identity-provider: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
