CAPTCHA_FAILURE mixes wrong captcha and network issues
Bug #1174917 reported by
Alejandro J. Cura
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical SSO provider |
Fix Released
|
Low
|
Simon Davy | ||
Bug Description
The json returned by the captcha API has the CAPTCHA_FAILURE code, but it is returned both when:
* the user enters a wrong captcha answer, or
* there's any other kind of error.
The code should be split, so it can be shown on the client in two different ways.
Related branches
lp://staging/~bloodearnest/canonical-identity-provider/1174917
- Ricardo Kirkner (community): Approve
- Michael Foord (community): Approve
-
Diff: 289 lines (+110/-29)7 files modifiedapi/v20/handlers.py (+9/-3)
api/v20/tests/test_registration.py (+47/-5)
api/v20/utils.py (+2/-0)
docs/resources/account.txt (+12/-0)
identityprovider/models/captcha.py (+22/-10)
identityprovider/tests/test_captcha.py (+17/-10)
requirements/config-manager.txt (+1/-1)
lp://staging/~bloodearnest/canonical-identity-provider/ssoclient-expose-recaptcha-errors
- Michael Foord (community): Approve
-
Diff: 252 lines (+87/-43)5 files modifiedREADME (+4/-0)
ssoclient/tests/test_v2.py (+34/-17)
ssoclient/v2/client.py (+1/-0)
ssoclient/v2/errors.py (+5/-0)
ssoclient/v2/http.py (+43/-26)
| Changed in canonical-identity-provider: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| tags: | added: u1-by-dev u1-on-dev |
| Changed in canonical-identity-provider: | |
| status: | Confirmed → Triaged |
| assignee: | Ricardo Kirkner (ricardokirkner) → Simon Davy (bloodearnest) |
| status: | Triaged → In Progress |
| Changed in canonical-identity-provider: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-identity-provider: | |
| assignee: | Simon Davy (bloodearnest) → nobody |
| Changed in canonical-identity-provider: | |
| assignee: | nobody → Simon Davy (bloodearnest) |
| Changed in canonical-identity-provider: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
