Bug #1523833 “Pressing Escape should close an open Dialog” : Bugs : Canonical System Image

Zsombor Egri (zsombi) on 2015-12-08

Changed in ubuntu-ui-toolkit (Ubuntu):
assignee:	nobody → Zsombor Egri (zsombi)
status:	New → Triaged
importance:	Undecided → High

Zsombor Egri (zsombi) on 2015-12-14

Changed in ubuntu-ui-toolkit (Ubuntu):
status:	Triaged → In Progress

Timo Jyrinki (timo-jyrinki) on 2015-12-14

Changed in canonical-devices-system-image:
assignee:	nobody → Zoltan Balogh (bzoltan)
milestone:	none → ww08-2016

Timo Jyrinki (timo-jyrinki) on 2015-12-14

Changed in canonical-devices-system-image:
milestone:	ww08-2016 → ww02-2016

Pat McGowan (pat-mcgowan) on 2015-12-14

Changed in canonical-devices-system-image:
status:	New → In Progress
importance:	Undecided → High

Cris Dywan (kalikiana) on 2015-12-15

Changed in ubuntu-ui-toolkit (Ubuntu):
status:	In Progress → Fix Committed

Zoltan Balogh (bzoltan) on 2015-12-15

Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status:	New → Fix Committed
importance:	Undecided → High
assignee:	nobody → Zoltan Balogh (bzoltan)
no longer affects:	ubuntu-ui-toolkit (Ubuntu)

Zoltan Balogh (bzoltan) on 2015-12-16

Changed in canonical-devices-system-image:
status:	In Progress → Fix Committed

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2015-12-16:

#1

Download full text (7.8 KiB)

This bug was fixed in the package ubuntu-ui-toolkit 1.3.1761+15.04.20151216.1-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ubuntu-ui-toolkit (1.3.1761+15.04.20151216.1-0ubuntu1) vivid; urgency=medium

  [ Zoltán Balogh ]
  * Drop dependency on qtc plugin script and wait for the shell with a local
    function.

  [ Christian Dywan ]
  * runtest.sh needs to add subdirs to the libpath. Fixes: LP: #1524710.
  * Explicit click/ touch threshold beyond handler.
  * Enter/Return/Space should trigger() Button. Fixes: LP: #1523794.
  * Only set ppmm in SwipeArea if screen has valid dpi. Fixes: LP: #1525174.

  [ Tim Peeters ]
  * Implement header slot management for convergence:
    - Adapt the number of action slots to the width of the view.
    - When a new action appears, show a quick fade-in.
    - Reverse the order of the actions in the header.
    - Update icon width to 4GU. Fixes: LP: #1428757.
  * To prevent an invalid sectionIndex, reset the value of sectionIndex to -1
    when the model of Sections is changed. Fixes: LP: #1513933.

[ Loïc Molinari ]
* UbuntuShape - Cleaned up includes.

  [ Albert Astals Cid ]
  * Simplify logic for emitting draggingChanged/pressedChanged
    No need for a switch that considers the possible cases, just store the
    status before and check after
    Fixes an issue in which the SwipeArea pressedChanged signal was not emitted
    if switching directly from WaitingForTouch to Recognized.
  * Fix memory leak in SwipeArea
    SwipeAreaPrivate is not deleted directly so make it part of the qobject
    hierarchy so it's auto deleted on parent destruction.

  [ Zsombor Egri ]
  * Add reset functionality to Action.shortcut property. Fixes: LP: #1518420.
  * Add contentWidth and contentHeight to Dialog so foreground can be resized.
    Fixes: LP: #1249325.
  * Fixing ListItem.selected and ListItem.selectMode bugs.
    Fixes: LP: #1493880, LP: #1493882, LP: #1514928.
  * Add private implementations to ActionItem, AbstractButton, BottomEdgeHint
    and BottomEdge. Fixes: LP: #1524234
  * Close Popups.Dialog when Esc key is pressed. Fixes LP: #1523833
  * Invoke the overridden trigger() function for Action and ActionItem
    derivates. Fixes LP: #1524234
  * Fix BottomEdge assertion when the content is committed by clicking on the
    hint. Fixes LP: #1524407

[ CI Train Bot ]
* No-change rebuild.

ubuntu-ui-toolkit (1.3.1742+16.04.20151209-0ubuntu1) xenial; urgency=medium

  [ Zoltán Balogh ]
  * Enable building the UITK tests in any case.
  * Remove Q_Q(UCStyledItemBase) because of unused variable warning.
  * Resolve Trusty specific compiler issue not resolving QPointer data on
    connections.
  * Use only the object name when selecting sections and labels in tests.

  [Zsombor Egri ]
  * Update BottomEdge with UI/UX agreed during the sprint. Fixes LP: #1368811.
  * BottomEdge component. Fixes LP: #1368811.
  * Remove build failure on Xenial caused by deprecated Qt functions.
  * Fix BottomEdgeHint consumes activeFocusOnPress handling. Fixes LP: #1517777
  * Migrate DirectionalDragArea from Unity8, named as SwipeArea. Original code
    (from lp...

This bug was fixed in the package ubuntu-ui-toolkit 1.3.1761+15.04.20151216.1-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ubuntu-ui-toolkit (1.3.1761+15.04.20151216.1-0ubuntu1) vivid; urgency=medium

[ Zoltán Balogh ]
  * Drop dependency on qtc plugin script and wait for the shell with a local
    function.

[ Christian Dywan ]
  * runtest.sh needs to add subdirs to the libpath. Fixes: LP: #1524710.
  * Explicit click/ touch threshold beyond handler.
  * Enter/Return/Space should trigger() Button. Fixes: LP: #1523794.
  * Only set ppmm in SwipeArea if screen has valid dpi. Fixes: LP: #1525174.

[ Tim Peeters ]
  * Implement header slot management for convergence:
    - Adapt the number of action slots to the width of the view.
    - When a new action appears, show a quick fade-in.
    - Reverse the order of the actions in the header.
    - Update icon width to 4GU. Fixes: LP: #1428757.
  * To prevent an invalid sectionIndex, reset the value of sectionIndex to -1
    when the model of Sections is changed. Fixes: LP: #1513933.

[ Loïc Molinari ]
  * UbuntuShape - Cleaned up includes.

[ Albert Astals Cid ]
  * Simplify logic for emitting draggingChanged/pressedChanged
    No need for a switch that considers the possible cases, just store the
    status before and check after
    Fixes an issue in which the SwipeArea pressedChanged signal was not emitted
    if switching directly from WaitingForTouch to Recognized.
  * Fix memory leak in SwipeArea
    SwipeAreaPrivate is not deleted directly so make it part of the qobject
    hierarchy so it's auto deleted on parent destruction.

[ Zsombor Egri ]
  * Add reset functionality to Action.shortcut property. Fixes: LP: #1518420.
  * Add contentWidth and contentHeight to Dialog so foreground can be resized.
    Fixes: LP: #1249325.
  * Fixing ListItem.selected and ListItem.selectMode bugs.
    Fixes: LP: #1493880, LP: #1493882, LP: #1514928.
  * Add private implementations to ActionItem, AbstractButton, BottomEdgeHint
    and BottomEdge. Fixes: LP: #1524234
  * Close Popups.Dialog when Esc key is pressed. Fixes LP: #1523833
  * Invoke the overridden trigger() function for Action and ActionItem
    derivates. Fixes LP: #1524234
  * Fix BottomEdge assertion when the content is committed by clicking on the
    hint. Fixes LP: #1524407

[ CI Train Bot ]
  * No-change rebuild.

ubuntu-ui-toolkit (1.3.1742+16.04.20151209-0ubuntu1) xenial; urgency=medium

[ Zoltán Balogh ]
  * Enable building the UITK tests in any case.
  * Remove Q_Q(UCStyledItemBase) because of unused variable warning.
  * Resolve Trusty specific compiler issue not resolving QPointer data on
    connections.
  * Use only the object name when selecting sections and labels in tests.

[Zsombor Egri ]
  * Update BottomEdge with UI/UX agreed during the sprint. Fixes LP: #1368811.
  * BottomEdge component. Fixes LP: #1368811.
  * Remove build failure on Xenial caused by deprecated Qt functions.
  * Fix BottomEdgeHint consumes activeFocusOnPress handling. Fixes LP: #1517777
  * Migrate DirectionalDragArea from Unity8, named as SwipeArea. Original code
    (from lp:unity8) by: Daniel d'Andrada <daniel.dandrada@canonical.com>.
  * Delete QQuickView when the application quits. Fixing segfault caused by the
    dangling objects in GestireDetector.
  * BottomEdgeHint API changes, deprecating state property, introducing locked
    property to drive visuals lock and click handling.
  * Fixing CheckBox and Switch getting checked property altered after clicked()
    signal is emitted. Fixes LP: #1510919.
  * Add ListItem.swipeEnabled property to block swiping when overlay MouseArea
    is used to drag content. Fixes swiping when leading/trailing actions list
    is empty. Fixes LP: #1500409, LP: #1500416.
  * Follow the new design in BottomEdgeHint.
  * Provide import version information for StyledItem and remove theme.version
    obsolete property.
  * Use QQuickItemChangeListener to listen parent changes, skipping the meta
    object model. Convert UCThemingExtension into a Q_INTERFACE so object_cast<>
    can work with it saving the need to memorise on an item whether it is an
    extended item or not.
  * Set mouseAttached to false to revert regression in UITK gallery.
  * Remove BottomEdgeHint from UITK gallery's MainPage.qml which occludes with
    the bottom-up dragging of the ListView.

[ Benjamin Zeller ]
  * Avoid unnecessary updates for i18n strings.
  * "MathUtils.clamp, min value should not be bigger than the max value".
    Fixes LP: #1520557.
  * Move MathUtils to Cpp.

[ Loïc Molinari ]
  * UbuntuShape - Fixed deprecation logging issues.
  * This fix prevents logging a deprecation warning for "image", "color" and
    "gradientColor" properties when the import version is less than 1.3. The
    logging of properties used internally (through the old image wrapper) have
    been removed too since the user might not even have used them.
    Fixes LP: #1519414.

[ Christian Dywan ]
  * Enable gallery target in qmake.
  * Don't set activeFocusOnPress on TextField but on child only.
    Fixes LP: #1486274, LP: #1513897.
  * Make runtest.sh work out of the box again.
  * Explicitly handle keyboard anchoring in dialog foreground.
    Fixes LP: #1376763.
  * Remove GestureDetector in favor of SwipeArea in BottomEdgeHint. Also make
    possible to assign Action to the component. Fixes LP: #1517771, LP: #1517798
  * Enforce !activeFocusOnPress on TextField primary/secondaryItem.
    Fixes LP: #1513897.
  * Only run ActivityIndicator if visible. Fixes LP: #1513450.
  * Use wait_select_single for _get_button in Popover CPO.
  * Include composite types in .api again.
  * More forgiving QML plugin/ version discovery.
  * Update toolkit and gallery po templates. Fixes LP: #1512924.
  * Improve handling of list types in apicheck.
  * Smaller handlers, entirely draggable caret. Fixes LP: #1450222.
  * Special-case leaked QQuickImageBase properties. Fixes LP: #1473890.
  * Don't use UniqueConnection in the image extension
  * Sync the height of the Page header with the other subheaders in the
    AdaptivePageLayout.

[ Tim Peeters ]
  * Add extension property to PageHeader.
  * Don't set the header.moving property when flickable contents height changes
    but the header does not actually move. Fixes LP: #1514143.
  * Fix the icon color in the AppHeader. Fixes LP: #1515593.
  * Use PageHeader in the UITK gallery.
  * Ensure PageHeader style works properly with run-time theme changes.
  * Add a back action to the Page.header automatically in PageStack and
    AdaptivePageLayout.
  * Add a navigationActions property to PageHeader.
  * Fix links to Page in the documentation.
  * Fix several header CPO related issues.
  * Only select visible header label instance in checkPageHeader().

[ Florian Boucault ]
  * DraggingArea: import Ubuntu.Components so that MathUtils is available and
    no warning is output.

[ Brendan Donegan ]
  * Account for presence of OSK in Flickable helpers and add a test for the same

[ Andrea Bernabei ]
  * ListItemLayout: set QML context of the predefined labels. Fixes lp1514173.
    Fixes LP: #1514173.
  * Add the ignoreSynthesizedEvents property. When the property is enabled, the
    Mouse filter ignores any synthesized mouse event, such as those created by
    the touch-to-mouse events synthesis. Enabling this property makes it
    possible to only trigger the hovering logic ONLY when using a mouse, and not
    when using a touchscreen (as it happens when using MouseArea).

[ Timo Jyrinki ]
  * Change HandlerType from int[2] to QVector<int> to make it work with Qt 5.5
    Fixes LP: #1484004, LP: #1450346
  * Workaround 'emit' declaration in Qt 5.5 Fixes LP: #1507910
  * Build depend on libxkbcommon-dev Fixes LP: #1508447

[ CI Train Bot ]
  * No-change rebuild.

-- Zoltan Balogh <zoltan.balogh@canonical.com>  Wed, 16 Dec 2015 10:01:47 +0000

Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status:	Fix Committed → Fix Released

Pat McGowan (pat-mcgowan) on 2016-01-27

Changed in canonical-devices-system-image:
status:	Fix Committed → Fix Released

Canonical System Image

Pressing Escape should close an open Dialog

Bug Description

Related branches

Other bug subscribers

Related blueprints

Remote bug watches

Affects		Status	Importance	Assigned to	Milestone
	Canonical System Image	Fix Released	High	Zoltan Balogh	Canonical System Image ww02-2016 "ota9"
	ubuntu-ui-toolkit (Ubuntu RTM)	Fix Released	High	Zoltan Balogh