ListItem needs keyboard focus support
Bug #1523815 reported by
Cris Dywan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Zoltan Balogh | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu RTM) |
Fix Released
|
High
|
Zsombor Egri |
Bug Description
ListItem needs to be able to take focus via (Shift)Tab and render a rectangle in focus color.
Related branches
lp://staging/~zsombi/ubuntu-ui-toolkit/oneUbuntuListView
- PS Jenkins bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 697 lines (+311/-84)12 files modifiedcomponents.api (+2/-1)
examples/ubuntu-ui-toolkit-gallery/MainPage.qml (+5/-27)
examples/ubuntu-ui-toolkit-gallery/UbuntuListViews.qml (+7/-3)
src/Ubuntu/Components/1.3/UbuntuListView.qml (+178/-9)
src/Ubuntu/Components/1.3/UbuntuListView11.qdoc (+0/-38)
src/Ubuntu/Components/ComponentModule.pro (+0/-2)
src/Ubuntu/Components/Themes/Ambiance/1.3/PullToRefreshStyle.qml (+4/-2)
src/Ubuntu/Components/qmldir (+1/-1)
tests/autopilot/ubuntuuitoolkit/__init__.py (+2/-0)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/__init__.py (+3/-1)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_ubuntulistview.py (+4/-0)
tests/unit_x11/tst_components/tst_ubuntulistview13.qml (+105/-0)
lp://staging/~zsombi/ubuntu-ui-toolkit/list_item_focus
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Cris Dywan: Approve
- PS Jenkins bot: Pending (continuous-integration) requested
- Tim Peeters: Pending requested
-
Diff: 1287 lines (+897/-29)16 files modifiedsrc/Ubuntu/Components/Themes/Ambiance/1.3/ListItemStyle.qml (+1/-0)
src/Ubuntu/Components/plugin/plugin.pri (+2/-0)
src/Ubuntu/Components/plugin/privates/listviewextensions.cpp (+151/-0)
src/Ubuntu/Components/plugin/privates/listviewextensions.h (+60/-0)
src/Ubuntu/Components/plugin/quickutils.cpp (+53/-0)
src/Ubuntu/Components/plugin/quickutils.h (+3/-0)
src/Ubuntu/Components/plugin/uclistitem.cpp (+110/-7)
src/Ubuntu/Components/plugin/uclistitem.h (+7/-0)
src/Ubuntu/Components/plugin/uclistitem_p.h (+5/-1)
src/Ubuntu/Components/plugin/ucstyleditembase.cpp (+16/-1)
src/Ubuntu/Components/plugin/ucstyleditembase.h (+2/-1)
src/Ubuntu/Components/plugin/ucstyleditembase_p.h (+1/-0)
src/Ubuntu/Components/plugin/ucviewitemsattached.cpp (+28/-10)
tests/resources/listitems/ListItemTest.qml (+10/-5)
tests/unit_x11/tst_components/tst_listitem_focus.qml (+417/-0)
tests/unit_x11/tst_components/tst_quickutils.qml (+31/-4)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | Christian Dywan (kalikiana) → Zsombor Egri (zsombi) |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Zoltan Balogh (bzoltan) |
milestone: | none → ww08-2016 |
Changed in canonical-devices-system-image: | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Triaged → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
status: | New → Invalid |
status: | Invalid → In Progress |
importance: | Undecided → High |
assignee: | nobody → Zsombor Egri (zsombi) |
no longer affects: | ubuntu-ui-toolkit (Ubuntu) |
Changed in canonical-devices-system-image: | |
status: | Confirmed → Fix Released |
no longer affects: | ubuntu-ui-toolkit (Ubuntu) |
Changed in canonical-devices-system-image: | |
status: | Fix Released → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Fix Released → Fix Committed |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit 1.3.1795+ 15.04.20160106- 0ubuntu1 in https:/ /launchpad. net/~ci- train-ppa- service/ +archive/ ubuntu/ stable- phone-overlay
---------------
ubuntu-ui-toolkit (1.3.1795+ 15.04.20160106- 0ubuntu1) vivid; urgency=medium
[ Christian Dywan ]
* Fix typo in runtest.sh: $? is the error code, not $*.
* Document use of RegExpValidator for password/ PIN input.
* Include filename derived QML class name in .api. Fixes LP: #1527138
* Use edit-clear for clear button instead of the invalid clear search.
* No transparency in focus outline.
* Give the original Toolbar its name back.
* Fix typo in runtest.sh: $? is the error code, not $*.
* Use resolved filename but add fragment. Fixes LP: #1401920
[ Zoltán Balogh ]
* Use build root for the Gestures library instead of relative path.
* Fix the tests for the gallery change
[ Zsombor Egri ]
* Add mnemonics support to Action. Fixes LP: #1527527
* Use original Image.source in image extension when no scaling is needed in
order to keep the formatting which would be otherwise removed from a
resolved file URL. Fixes LP: #1401920
* Move UbuntuListView 1.3 code into one single file. Fixes LP: #1523815
[ Albert Astals Cid ] :removeTimeCons traintsFromSwip eArea
* Add UCTestExtras:
For that needed to move ucswipearea.cpp from UbuntuComponents to
UbuntuGestures but made it in a private header so we don't have to care much
for the API/ABI stability for now.
[ Andrea Bernabei ]
* make scrollbars tests more robust.
[ Tim Peeters ]
* Update font sizes. Fixes LP: #1528263
[ CI Train Bot ]
* No-change rebuild.
ubuntu-ui-toolkit (1.3.1778+ 16.04.20151221- 0ubuntu1) xenial; urgency=medium
[ Tim Peeters ]
* Fix issue with trigger() for ListItems.Standard. (LP: #1527811)
ubuntu-ui-toolkit (1.3.1778+ 16.04.20151217. 1-0ubuntu1) xenial; urgency=medium
[ Andrea Bernabei ]
* Rework Scrollbars and add ScrollView component.
[ Zsombor Egri ]
* Refactor UCSwipeAreaPrivate to use QQuickItemPrivate instead of being
a QObject.
[ Tim Peeters ]
* Reduce toolbar height on phone in landscape orientation.
Fixes LP: #1336793.
* Introduce the new Toolbar component for the header edit mode.
* Reduce the PageHeader height by 1 GU on phone in landscape orientation.
Fixes LP: #1336793
* Fix AppHeader 1.2 to use the new MathUtils. This fixes a failing autopilot
CPO test.
[ Zoltan Balogh ]
* Do not wipe when provisioning for normal use and improve
regression detection.
* Try to link Gestures more explicitely. (kudos to xnox).
[ Christian Dywan ] modules_ dir.sh.
* Proper keyboard navigation and focus visuals for buttons.
Fixes LP: #1225139, LP: #1514850
* Escape should close popover. Fixes LP: #1523828
* Surround state overloading message with static boolean. Fixes LP: #1523399
* Don't exit, return 1 from export_
[ Michael Sheldon ]
* Set the activeFocus on the input component when a text input area receive
focus. Fixes LP: #1518352
[ Benjamin Zeller ]
* Move PageTreeNode to C++.
* Custom property flag needs to be set always even when the value itself does not chan...