Canonical System Image

Icon width is inconsistent when height is specified

Bug #1421293 reported by Albert Astals Cid
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Confirmed
Low
Zoltan Balogh
Canonical System Image backlog
ubuntu-ui-toolkit (Ubuntu)
Confirmed
Low
Zsombor Egri

Bug Description

The width of an Icon {} depends if the Icon is an SVG coming from image://theme/ or a JPG.

For the SVG the width grows as the units.gu grow, but for the JPEG it does not and one has to manually add code to maitain the aspect ratio.

See the attached code and files.

Related branches

lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk-fix-icon-svg-image-loading
Michał Sawicz: Disapprove
ubuntu-sdk-build-bot: Approve (continuous-integration)
Diff: 280 lines (+77/-66)
3 files modified
src/Ubuntu/Components/plugin/unitythemeiconprovider.cpp (+61/-51)
src/Ubuntu/Components/plugin/unitythemeiconprovider.h (+1/-1)
tests/unit_x11/tst_iconprovider/tst_iconprovider.cpp (+15/-14)
Tim Peeters: Approve
PS Jenkins bot: Needs Fixing (continuous-integration)
Diff: 316 lines (+96/-66)
4 files modified
src/Ubuntu/Components/plugin/unitythemeiconprovider.cpp (+61/-51)
src/Ubuntu/Components/plugin/unitythemeiconprovider.h (+1/-1)
tests/unit_x11/tst_components/tst_icon.qml (+19/-0)
tests/unit_x11/tst_iconprovider/tst_iconprovider.cpp (+15/-14)
lp://staging/~lukas-kde/ubuntu-ui-toolkit/staging-fix-icon-svg-image-loading
ubuntu-sdk-build-bot: Approve (continuous-integration)
Tim Peeters: Approve
Diff: 318 lines (+96/-66)
4 files modified
src/Ubuntu/Components/plugin/unitythemeiconprovider.cpp (+61/-51)
src/Ubuntu/Components/plugin/unitythemeiconprovider.h (+1/-1)
tests/unit_x11/tst_components/tst_icon.qml (+19/-0)
tests/unit_x11/tst_iconprovider/tst_iconprovider.cpp (+15/-14)
Revision history for this message
Albert Astals Cid (aacid) wrote :
Revision history for this message
Albert Astals Cid (aacid) wrote :
Revision history for this message
Zsombor Egri (zsombi) wrote :

Albert, haven't you provided recently a fix for this?

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Incomplete
Revision history for this message
Albert Astals Cid (aacid) wrote :

No, I haven't

just run the file with different pixel per grid unit and see how the error is still there.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Incomplete → New
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Zsombor Egri (zsombi) wrote :

Ahm, Albert, I have worst news for you: design said we have to set the implicit width/height to 2grid units... so you will have to do more calculations if we apply that :(

Perhaps we expose the image size so you can decide whether you want to bind to that or not.

Michał Sawicz (saviq)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Triaged → Fix Committed
status: Fix Committed → Fix Released
Albert Astals Cid (aacid)
description: updated
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Released → Triaged
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → Fix Committed
importance: Undecided → Low
milestone: none → 12
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1984+16.10.20160527.2

---------------
ubuntu-ui-toolkit (1.3.1984+16.10.20160527.2) yakkety; urgency=medium

  [ Christian Dywan ]
  * Slimmer frame for TextFields: 0.5dp. Fixes LP: #1578190.

  [ Albert Astals Cid ]
  * Add override
    The override specifier (since C++11) specifies that a virtual function
    overrides another virtual function. In a member function declaration or
    definition, override ensures that the function is virtual and is overriding
    a virtual function from the base class.

  [ Tim Peeters ]
  * Fix reference error in PullToRefreshStyle. Fixes LP: #1582843
  * Mark Tab, Tabs, TabBar, PageHeadConfiguration, PageHeadSections,
    PageHeadState, ToolbarButton, ToolbarItems as deprecated in the
    documentation. Fixes LP: #1566735, LP: #1566741.

  [ CI Train Bot ]
  * Resync trunk.

 -- Zoltan Balogh <email address hidden> Fri, 27 May 2016 07:08:44 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Albert Astals Cid (aacid) wrote :

As discussed in IRC a while back, this bug hsan't really been fixed.

Changed in canonical-devices-system-image:
status: Fix Committed → Confirmed
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Released → Confirmed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
assignee: nobody → Zoltan Balogh (bzoltan)
milestone: 12 → backlog
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Zsombor Egri (zsombi)
Revision history for this message
Albert Astals Cid (aacid) wrote :
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.