Cable

Quit on Ctrl+Q

Bug #952279 reported by Sergey "Shnatsel" Davidoff
70
This bug affects 11 people
Affects Status Importance Assigned to Milestone
AppCenter
Fix Released
Wishlist
Danielle Foré
AppCenter 0.1.4
BeatBox
Fix Released
Low
Scott Ringwelski
BeatBox 0.4 "Bilar"
Cable
Confirmed
Low
Unassigned
Cable 0.2
Calculator
Fix Released
Low
MarkoD
Calculator 0.1.2
Files
Fix Released
Low
Jeremy Wootten
Files 0.2
Mail
Fix Released
Low
Ralph Plawetzki
Mail 1.0
Noise
Fix Released
Low
Patrick Pace
Noise luna-beta2 "0.2 - Jimi Hendrix"
Scratch
Fix Released
Low
Mario Guerriero
Scratch 1.1.1
Screenshot
Fix Released
Low
Danielle Foré
Screenshot 0.1.2
Terminal
Invalid
Undecided
Unassigned

Bug Description

Quit on Ctrl+Q key combo, as described in the keyboard shortcuts document: https://docs.google.com/document/d/1jUtWkfqlwDydaO-B67F9PsOhE66AZ2y5N_uDRW9pOuQ/edit

See original description

Related branches

lp://staging/~jeremywootten/pantheon-files/all-views-vala
PerfectCarl (community): Approve
Danielle Foré: Approve (ux)
Jeremy Wootten: Pending requested
Cody Garver: Pending requested
Diff: 49548 lines (+17157/-29587)
96 files modified
.bzrignore (+1/-1)
AUTHORS (+2/-0)
CMakeLists.txt (+1/-1)
data/schemas/org.pantheon.files.gschema.xml (+2/-2)
libcore/AbstractSlot.vala (+76/-0)
libcore/CMakeLists.txt (+3/-2)
libcore/Plugin.vala (+1/-1)
libcore/PluginManager.vala (+1/-1)
libcore/eel-stock-dialogs.c (+0/-3)
libcore/fm-list-model.c (+60/-139)
libcore/fm-list-model.h (+3/-9)
libcore/gof-abstract-slot.c (+0/-47)
libcore/gof-abstract-slot.h (+0/-56)
libcore/gof-directory-async.vala (+45/-23)
libcore/gof-file.c (+46/-26)
libcore/gof-file.h (+4/-3)
libcore/marlin-file-changes-queue.c (+0/-3)
libcore/marlin-file-operations.c (+6/-10)
libcore/marlin-icon-info.c (+9/-5)
libcore/pantheon-files-core-C.vapi (+86/-16)
libwidgets/Animations.vala (+12/-3)
libwidgets/BreadcrumbsElements.vala (+1/-1)
libwidgets/LocationBar.vala (+15/-13)
plugins/network-places/plugin.vala (+12/-7)
plugins/pantheon-files-ctags/plugin.vala (+183/-55)
plugins/pantheon-files-trash/plugin.vala (+19/-15)
src/AbstractEditableLabel.vala (+96/-0)
src/Application.vala (+47/-76)
src/BookmarkList.vala (+5/-0)
src/CMakeLists.txt (+26/-20)
src/DndHandler.vala (+272/-0)
src/MimeActions.vala (+19/-11)
src/MultiLineEditableLabel.vala (+196/-0)
src/SingleLineEditableLabel.vala (+104/-0)
src/TextRenderer.vala (+307/-0)
src/View/AbstractDirectoryView.vala (+2778/-0)
src/View/AbstractTreeView.vala (+280/-0)
src/View/Browser.vala (+3/-18)
src/View/Chrome/ColorWidget.vala (+0/-183)
src/View/Chrome/TopMenu.vala (+81/-35)
src/View/Chrome/ViewSwicher.vala (+36/-27)
src/View/ColumnView.vala (+140/-0)
src/View/DbusTags.vala (+0/-100)
src/View/DirectoryNotFound.vala (+1/-1)
src/View/IconView.vala (+318/-0)
src/View/ListView.vala (+235/-0)
src/View/LocationBar.vala (+27/-44)
src/View/Miller.vala (+396/-0)
src/View/OverlayBar.vala (+58/-53)
src/View/PropertiesWindow.vala (+5/-4)
src/View/Resources.vala (+4/-1)
src/View/Sidebar.vala (+44/-40)
src/View/Slot.vala (+276/-0)
src/View/ViewContainer.vala (+246/-296)
src/View/ViewMode.vala (+0/-17)
src/View/Window.vala (+614/-604)
src/View/directory_view_popup.ui (+138/-0)
src/eel-editable-label.c (+0/-4417)
src/eel-editable-label.h (+0/-146)
src/exo-icon-view.c (+0/-11753)
src/exo-icon-view.h (+0/-347)
src/exo-tree-view.c (+0/-674)
src/exo-tree-view.h (+0/-91)
src/fm-abstract-icon-view.c (+0/-870)
src/fm-abstract-icon-view.h (+0/-60)
src/fm-columns-view.c (+0/-858)
src/fm-columns-view.h (+0/-60)
src/fm-directory-view-ui.xml (+0/-194)
src/fm-directory-view.c (+0/-4059)
src/fm-directory-view.h (+0/-446)
src/fm-icon-view-ui.xml (+0/-37)
src/fm-icon-view.c (+0/-147)
src/fm-icon-view.h (+0/-51)
src/fm-list-view.c (+0/-999)
src/fm-list-view.h (+0/-60)
src/gof-window-slot.c (+0/-315)
src/gof-window-slot.h (+0/-88)
src/gtk+-3.0.deps (+7/-0)
src/gtk+-3.0.vapi (+9698/-0)
src/main.vala (+1/-0)
src/marlin-cell-renderer-text-ellipsized.c (+0/-73)
src/marlin-cell-renderer-text-ellipsized.h (+0/-58)
src/marlin-clipboard-manager.c (+10/-0)
src/marlin-clipboard-manager.h (+3/-0)
src/marlin-dnd.c (+0/-230)
src/marlin-dnd.h (+0/-43)
src/marlin-enum-types.h (+2/-4)
src/marlin-global-preferences.h (+1/-0)
src/marlin-icon-renderer.c (+13/-4)
src/marlin-text-renderer.c (+0/-869)
src/marlin-text-renderer.h (+0/-76)
src/marlin-view-window.h (+25/-13)
src/marlin-window-columns.c (+0/-310)
src/marlin-window-columns.h (+0/-84)
src/marlin.vapi (+57/-104)
src/pantheon-files-ui.xml (+0/-75)
lp://staging/~purejava/pantheon-mail/ctrl-q-to-close
elementary Apps team: Pending requested
Diff: 22 lines (+3/-0)
1 file modified
src/client/application/geary-controller.vala (+3/-0)
lp://staging/~markodolar/pantheon-calculator/pantheon-calculator-fixes
Danielle Foré: Approve (ux)
Diff: 169 lines (+52/-12)
3 files modified
data/org.pantheon.calculator.gschema.xml (+10/-0)
src/MainWindow.vala (+28/-10)
src/PantheonCalculator.vala (+14/-2)
lp://staging/~elementary-apps/screenshot-tool/quit-on-ctrl-q
Adam Bieńkowski (community): Approve (code / testing)
Diff: 20 lines (+10/-0)
1 file modified
src/Screenshot.vala (+10/-0)
lp://staging/~elementary-apps/appcenter/quit-on-ctrl-q
Adam Bieńkowski (community): Approve (code / testing)
Diff: 20 lines (+10/-0)
1 file modified
src/Application.vala (+10/-0)
Sergey "Shnatsel" Davidoff (shnatsel)
tags: added: consistency
Revision history for this message
Cris Dywan (kalikiana) wrote :

Midori has switched to quitting on Ctrl+Shift+Q some time ago because users tend to accidentally hit Ctr+Q when aiming for Ctrl+W or Ctrl+A.

Changed in midori:
status: New → Won't Fix
Revision history for this message
Daniel Rollings (daniel-rollings) wrote :

I agree that the shortcut for quitting an app as opposed to closing a window should involve a meta key, but it's also important not to hard-code this. I think the blueprint for Consistent keyboard shortcuts is on the money, but there needs to be a central table of common shortcuts that is truly adhered to as part of the HIG. For Macs, if it's a menubar item, it can be set as a keyboard shortcut in a specific app or in all apps, and this for example lets me map Command-Shift-M to Zoom (close enough to maximize) across all apps. A similar level of consistency for sizing, tabbed navigation, document opening/saving, and app quitting is highly desirable and not just in Midori.

Scott Ringwelski (sgringwe)
Changed in beat-box:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Scott Ringwelski (sgringwe)
milestone: none → 0.4
status: Confirmed → Fix Committed
Scott Ringwelski (sgringwe)
Changed in beat-box:
status: Fix Committed → Fix Released
Sergey "Shnatsel" Davidoff (shnatsel)
description: updated
Mario Guerriero (mefrio-g)
Changed in scratch:
status: New → Confirmed
importance: Undecided → Low
milestone: none → luna-beta1
assignee: nobody → Mario Guerriero (mefrio-g)
Mario Guerriero (mefrio-g)
Changed in scratch:
status: Confirmed → Fix Committed
Revision history for this message
Danielle Foré (danrabbit) wrote :

Is there any way we can do this in Granite Application or as a function of Gala or something so that all apps just have this automatically for free?

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

With Gala we could call delete-event signal of the window when CTRL+Q is clicked. If it can be so I suggest to use the current implementation since many apps, such as scratch, do some functions before close themselves

Revision history for this message
Cris Dywan (kalikiana) wrote :

Keep in mind cases where Ctrl+Q is intentionally being disabled, such as Midori which uses Ctrl+Shift+Q.

Another point is, if this only works in Gala, we're going to see very strange and confused problem reports. Not even all of Elementary developers use Gala.

Revision history for this message
Tom Beckmann (tombeckmann) wrote :

Well, it would probably conflict with other apps using ctlr+q too, I'd rather say put it in GraniteApplication and make it disable-able for the worst case. We inherit some signals from GLibApplication and GtkApplication which could be useful here.

Cody Garver (codygarver)
Changed in granite:
status: New → Confirmed
importance: Undecided → Medium
Changed in noise:
status: New → Won't Fix
tags: added: hotkey
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Gala can only call closing the window, not the actual quit function (which are different things in many apps, e.g. BeatBox).

Danielle Foré (danrabbit)
Changed in scratch:
status: Fix Committed → Fix Released
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Cody, why this is "Won't Fix" for Noise?

Revision history for this message
Victor Martinez (victored) wrote :

It's actually fixed for noise

Changed in granite:
importance: Medium → Wishlist
status: Confirmed → Triaged
Changed in noise:
status: Won't Fix → Fix Committed
importance: Undecided → Low
milestone: none → luna-beta2
assignee: nobody → Patrick Pace (pqp)
Corentin Noël (tintou)
Changed in noise:
status: Fix Committed → Fix Released
Sergey "Shnatsel" Davidoff (shnatsel)
Changed in pantheon-files:
status: New → Confirmed
Julien Spautz (julien-spautz)
Changed in cable:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 0.2
David Gomes (davidgomes)
Changed in midori:
status: Won't Fix → Confirmed
status: Confirmed → Won't Fix
Cody Garver (codygarver)
Changed in pantheon-files:
importance: Undecided → Low
Revision history for this message
Timo Reimerdes (timorei) wrote :

I stumble upon this every single time I use files - avid keyboard user when laptop is not on docking. ;)

One of these details that are like a sore in the mouth: you just can't stop poking it once you know it's there. Just like that godaweful idea in midori: Everyone is ctrl+q - lets do it different.

Closing a series of windows right now looks like this:
fotos, midori, noise, files, terminal

fotos works
midori takes no simple shortcut (1 failure)
noise takes no shift-shortcut (1 failure)
files takes neither, but does react to alt+f4 (3 tries!)
And terminal uses something else entirely (usually I don't have to try all shortcuts, because terminals are so distinctive)

Ctrl+q -> Ctrl+q -> *wonders* -> Ctrl+Shift+q -> Ctrl+Shift+q -> *wonders* -> Ctrl+q -> *wonders*-> Alt+F4 -> *recognize* Ctrl+d

It might be minor, but it is REALLY anoying and feels... well... inconsistent.

Jeremy Wootten (jeremywootten)
Changed in pantheon-files:
assignee: nobody → Jeremy Wootten (jeremywootten)
status: Confirmed → In Progress
Revision history for this message
PerfectCarl (name-is-carl) wrote :

Fixed in files/all-views-vala

Danielle Foré (danrabbit)
Changed in pantheon-files:
status: In Progress → Fix Committed
milestone: none → freya-beta2
Danielle Foré (danrabbit)
Changed in pantheon-files:
status: Fix Committed → Fix Released
Cody Garver (codygarver)
Changed in pantheon-files:
milestone: freya-beta2 → 0.2
Revision history for this message
Cody Skinner (wskinner) wrote :

Ctrl + Shift + Q is the shortcut used to quit terminal. The CTRL key by itself in terminal is usually used for control commands, such as ^c.

Changed in pantheon-terminal:
status: New → Invalid
Danielle Foré (danrabbit)
Changed in appcenter:
importance: Undecided → Wishlist
no longer affects: midori
Changed in pantheon-mail:
importance: Undecided → Low
milestone: none → loki+1-beta1
status: New → Confirmed
Danielle Foré (danrabbit)
Changed in screenshot-tool:
importance: Undecided → Low
status: New → Confirmed
Changed in pantheon-calculator:
status: New → Confirmed
Ralph Plawetzki (purejava)
Changed in pantheon-mail:
assignee: nobody → Ralph Plawetzki (purejava)
status: Confirmed → In Progress
Danielle Foré (danrabbit)
Changed in pantheon-mail:
milestone: loki+1-beta1 → loki-rc1
status: In Progress → Fix Committed
Cody Garver (codygarver)
Changed in pantheon-mail:
milestone: loki-rc1 → 1.0
status: Fix Committed → Fix Released
Danielle Foré (danrabbit)
Changed in screenshot-tool:
milestone: none → juno-beta1
Changed in appcenter:
milestone: none → juno-beta1
Changed in pantheon-calculator:
milestone: none → juno-beta1
Cody Garver (codygarver)
Changed in pantheon-calculator:
importance: Undecided → Low
Danielle Foré (danrabbit)
Changed in appcenter:
status: New → Confirmed
Danielle Foré (danrabbit)
Changed in pantheon-calculator:
assignee: nobody → MarkoD (markodolar)
status: Confirmed → In Progress
Danielle Foré (danrabbit)
Changed in pantheon-calculator:
status: In Progress → Fix Committed
Danielle Foré (danrabbit)
Changed in screenshot-tool:
assignee: nobody → Daniel Fore (danrabbit)
status: Confirmed → In Progress
no longer affects: granite
Danielle Foré (danrabbit)
Changed in appcenter:
assignee: nobody → Daniel Fore (danrabbit)
status: Confirmed → In Progress
RabbitBot (rabbitbot-a)
Changed in appcenter:
status: In Progress → Fix Committed
Changed in screenshot-tool:
status: In Progress → Fix Committed
Cody Garver (codygarver)
Changed in pantheon-calculator:
status: Fix Committed → Fix Released
Cody Garver (codygarver)
Changed in screenshot-tool:
status: Fix Committed → Fix Released
Revision history for this message
melmolot1177 (melmolot1177-deactivatedaccount) wrote :

Is there any possibility of implementing Ctrl+Q on Evince (PDF Viewer packaged by default with elementary OS)? Currently, its default seems to be Ctrl+W, which doesn't settle well with the 'defaults just work' idea.

Cody Garver (codygarver)
Changed in appcenter:
milestone: juno-beta1 → 0.1.4
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.