Better error messages for bzr lp://

Right, the error messages should be improved.

It's not clear to me what would be the best way, since the current lp:// scheme just builds on the existing branch-reference redirection built into the launchpad webapp. Setting to Medium importance out of indecision.

This should be fixed by the recent lp:/// work. Assigning to myself so I can confirm during this release.

Here's how it behaves now.

jml@rhino:~/Desktop/muckaround$ bzr branch lp:no-such-project
bzr: ERROR: Invalid url supplied to transport: "lp:no-such-project": No such product: no-such-project
jml@rhino:~/Desktop/muckaround$ bzr branch lp:///no-such-project
bzr: ERROR: Invalid url supplied to transport: "lp:///no-such-project": No such product: no-such-project
jml@rhino:~/Desktop/muckaround$ bzr branch lp://no-such-project
bzr: ERROR: Invalid url supplied to transport: "lp://no-such-project"
jml@rhino:~/Desktop/muckaround$ bzr branch lp://python
bzr: ERROR: Invalid url supplied to transport: "lp://python"
jml@rhino:~/Desktop/muckaround$ bzr branch lp:///subunit/fix-stdout
bzr: ERROR: Invalid url supplied to transport: "lp:///subunit/fix-stdout": Project subunit has no series called "fix-stdout"
jml@rhino:~/Desktop/muckaround$ bzr branch lp:~exarkun/subunit/fix-stdout
lp:~exarkun/subunit/fix-stdout is redirected to bzr+ssh://<email address hidden>/~exarkun/subunit/fix-stdout/
Branched 46 revision(s)
$ cd fix-stdout
$ bzr push lp:///~jml/+junk/new-branch
lp:///~jml/+junk/new-branch is redirected to bzr+ssh://<email address hidden>/~jml/+junk/new-branch/
bzr: ERROR: lp:///~jml/+junk/new-branch is redirected to bzr+ssh://<email address hidden>/~jml/+junk/new-branch

The recent lp:/// work does make this better, but it doesn't fix it. Specifically, there's no reference to a place to get help, and "bzr: ERROR: Invalid url supplied to transport:" doesn't _really_ add any value to the message that the user sees.

I think the correct fix is to define a special exception class for BadLaunchpadURL.

Note that the flaw in the 'cannot push to new branch' message will be corrected by making it possible to push to new branches.

Re-assigning to Bazaar, since that's where the code change needs to happen.

I'd completely forgotten about this bug. Not going to work on it for the foreseeable future.

I think we also need to consider separately the cases of trying to create these locations vs trying to read from them.

On Wed, Oct 13, 2010 at 2:20 PM, Martin Pool <email address hidden> wrote:
> I think we also need to consider separately the cases of trying to
> create these locations vs trying to read from them.

We do, which is why I included on-demand creation pushes in the use
cases, I wasn't particularly clear that I was doing that in hindsight.

Code wise I don't think anything special will be needed.

-Rob

Here's what I got on a recent run of the test "script" above:

$ bzr branch lp:no-such-project
bzr: ERROR: Not a branch: "bzr+ssh://bazaar.launchpad.net/%2Bbranch/no-such-project/".
$ bzr branch lp://no-such-project
bzr: ERROR: Invalid url supplied to transport: "lp://no-such-project"
$ bzr branch lp:subunit/python3
bzr: ERROR: Permission denied: "Cannot create 'python3'. Only Bazaar branches are allowed."
$ bzr branch lp:~jml/subunit/no-such-branch
bzr: ERROR: Not a branch: "bzr+ssh://bazaar.launchpad.net/~jml/subunit/no-such-branch/".
$ bzr branch lp:ubuntu/no-such-package
bzr: ERROR: Not a branch: "bzr+ssh://bazaar.launchpad.net/%2Bbranch/ubuntu/no-such-package/".
$ bzr branch lp:ubuntu/natty/no-such-package
bzr: ERROR: Not a branch: "bzr+ssh://bazaar.launchpad.net/%2Bbranch/ubuntu/natty/no-such-package/".

$ bzr init trunk
Created a standalone tree (format: 2a)
$ cd !$
cd trunk
/trunk$ bzr push lp:no-such-project
bzr: ERROR: Permission denied: "+branch/no-such-project/": : Project 'no-such-project' does not exist.
/trunk$ bzr push lp://no-such-project
bzr: ERROR: Invalid url supplied to transport: "lp://no-such-project"
/trunk$ bzr push lp:subunit/python3
bzr: ERROR: Permission denied: "Cannot create 'python3'. Only Bazaar branches are allowed."
/trunk$ bzr push lp:ubuntu/no-such-package
bzr: ERROR: Permission denied: "+branch/ubuntu/no-such-package/": : No such source package: 'no-such-package'.
/trunk$ bzr push lp:ubuntu/natty/no-such-package
bzr: ERROR: Permission denied: "+branch/ubuntu/natty/no-such-package/": : No such source package: 'no-such-package'.
/trunk$ bzr push lp:~jml/no-such-project/trunk
bzr: ERROR: Invalid url supplied to transport: "lp:~jml/no-such-project/trunk": No such project: no-such-project

not currently scheduled in launchpad - putting it in low to reflect its backlogged status. Sorry about the noise on the bzr task, misclicked.

Some cents since I ran into a wall not understanding the error messages the other day, in particular (real names replaced):

bzr push lp:~pokemon/+bulbasaur
Working tree "/home/kalikiana/projects/bulbasaur/" has uncommitted changes (See bzr status). Uncommitted changes will not be pushed.
bzr: ERROR: Invalid url supplied to transport: "lp:~pokemon/+bulbasaur": No such project: %2Bbulbasaur
> bzr push lp:~pokemon/+dungeon/bulbasaur
Working tree "/home/kalikiana/projects/bulbasaur/" has uncommitted changes (See bzr status). Uncommitted changes will not be pushed.
bzr: ERROR: Access denied: »~pokemon/+dungeon/bulbasaur/«: : Project '+dungeon' does not exist.

After some explanations it turns out there's teams, groups and projects and teams can host code as projects can, and even if it may seem to be very clear, I didn't understand the error messages at all. The "invalid url" part was especially puzzling since I double-checked that the syntax is perfectly correct, except it shouldn't be used for a team.

It would help a lot if it gave better suggestions such as "there is a team, not a project, so maybe you wanted to push to +junk instead", which is what I was advised to do eventually.