remove LockableFiles

Bug #88848 reported by Martin Pool
2
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

There is a LockableFiles instance in most branch, repository and workingtree objects called _control_files. It's not particularly helping at this point and could be removed. Instead just have the objects talk directly to their transport and lock.

Tags: cleanup lock
Revision history for this message
Aaron Bentley (abentley) wrote :

LockableFiles itself may be an unnecessary abstraction, but at minimum, we ought to keep the lock itself abstract.

I think locking mechanisms should be the purview of the control directory format. So the hpss locking can be different from the http locking, and if we need to create a new lock mechanism at some point, we only need a new BzrMetaFormat-- we don't need new tree, branch and repository formats.

So I think the BzrDirFormat should control the locking mechanism used.

Martin Pool (mbp)
Changed in bzr:
importance: Undecided → Medium
status: New → Confirmed
Martin Pool (mbp)
Changed in bzr:
status: Confirmed → In Progress
assignee: nobody → Martin Pool (mbp)
Martin Pool (mbp)
Changed in bzr:
importance: Medium → Low
Martin Pool (mbp)
Changed in bzr:
status: In Progress → Confirmed
importance: Low → Medium
assignee: Martin Pool (mbp) → nobody
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.